update What to Test in Views

Author: Xronophobe

chapter_15_advanced_forms.asciidoc

@@ -886,7 +886,8 @@ real app.
 
 We have one unit test file for each of our key source code files.  Here's
 a recap of the biggest (and highest-level) one, 'test_views' (the listing
-shows just the key tests and assertions):
+shows just the key tests and assertions, and your order may vary):
+// CSANAD: Why are we only showing ListViewTest? HomePageTest, NewListTest
 
 .What to Test in Views
 ******************************************************************************
@@ -898,7 +899,7 @@ shows just the key tests and assertions):
 ----
 class ListViewTest(TestCase):
   def test_uses_list_template(self):
-      response = self.client.get(f'/lists/{list_.id}/') #<1>
+      response = self.client.get(f'/lists/{mylist.id}/') #<1>
       self.assertTemplateUsed(response, 'list.html') #<2>
   def test_passes_correct_list_to_template(self):
       self.assertEqual(response.context['list'], correct_list) #<3>
@@ -924,7 +925,7 @@ class ListViewTest(TestCase):
   def test_for_invalid_input_shows_error_on_page(self):
       self.assertContains(response, escape(EMPTY_ITEM_ERROR)) #<7>
   def test_duplicate_item_validation_errors_end_up_on_lists_page(self):
-      self.assertContains(response, expected_error)
+      self.assertContains(response, expected_error) #<7>
       self.assertTemplateUsed(response, 'list.html')
       self.assertEqual(Item.objects.all().count(), 1)
 ----
@@ -933,10 +934,10 @@ class ListViewTest(TestCase):
 
 <1> Use the Django Test Client.
 
-<2> Check the template used.  Then, check each item in the template context.
+<2> Check the template used.
+// CSANAD: we aren't asserting anything else in this test
 
-<3> Check that any objects are the right ones, or querysets have the
-    correct items.
+<3> Check that received objects are the right ones.
 
 <4> Check that any forms are of the correct class.
 
@@ -953,6 +954,8 @@ class ListViewTest(TestCase):
 Why these points?  Skip ahead to <<appendix_Django_Class-Based_Views>>, and I'll show how
 they are sufficient to ensure that our views are still correct if we refactor
 them to start using class-based views.((("", startref="FDVduplicate15")))((("", startref="UIduplicate15")))
+// CSANAD: We might want to revisit these again after updating/reviewing the
+// Django Class Based Views.
 
 
 Next we'll try to make our data validation more friendly by using a bit