Skip to content

Commit 67855c6

Browse files
committed
add review comments from stuck PR #238
1 parent d259362 commit 67855c6

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

chapter_14_simple_form.asciidoc

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -178,9 +178,11 @@ NOTE: Doing this sort of widget customisation would get tedious
178178
if we had a much larger, more complex form.
179179
Check out
180180
https://django-crispy-forms.readthedocs.org/[django-crispy-forms]
181-
and http://bit.ly/1rR5eyD[django-floppyforms] for some help.
182181
((("django-crispy-forms")))
183-
((("django-floppyforms")))
182+
//CSANAD: crispy forms still seems to be maintained and up-to-date, floppyforms
183+
// not so much. Some comments on floppyforms' issues say that its
184+
// functionality is built into Django as of 2020. I'm not sure if it's true for
185+
// crispyforms as well.
184186

185187

186188
[role="pagebreak-before less_space"]
@@ -535,8 +537,9 @@ the logic change:
535537
[subs="specialcharacters,quotes"]
536538
----
537539
$ *git diff* # review changes in base.html, views.py and its tests
538-
$ *git commit -am "use new form in home_page, simplify tests. NB breaks stuff"*
540+
$ *git commit -am "use new form in home_page. NB breaks stuff"*
539541
----
542+
// CSANAD: we didn't simplify the tests in this step. What's NB?
540543

541544

542545
Let's fix the functional tests.
@@ -613,6 +616,8 @@ $ *grep -r id_new_item src/lists/*
613616
----
614617

615618
Good, there are no references to `id_new_item` left.
619+
// CSANAD: we could mention *.pyc files under __pycache__ would probably still
620+
// show up in the results.
616621
What about `name`/ `item_text`?
617622

618623
[subs="specialcharacters,macros"]
@@ -1029,8 +1034,6 @@ or spin up the site manually with `manage.py runserver` if you prefer
10291034
(see <<html5_popup_screenshot>>).
10301035

10311036

1032-
// todo: update screenshot
1033-
10341037
[[html5_popup_screenshot]]
10351038
.HTML5 validation says no
10361039
image::images/twp2_1401.png["The input with a popup saying 'please fill out this field'"]

images/twp2_1401.png

-45.7 KB
Loading

0 commit comments

Comments
 (0)