Skip to content

Commit 68ce94b

Browse files
authored
Merge pull request #223 from hjwp/20240411_chapter_11_jg_review
Chapter 11 review
2 parents aa6987b + 3914a0b commit 68ce94b

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

chapter_11_ansible.asciidoc

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,12 @@ It's just as easy to fall into the Refactoring-Cat trap on the server!
241241
242242
////
243243

244+
// JAN: It feels a bit like something is missing here. You're talking about servers and DNS records. Yet, there's no real call to action for a reader.
245+
// I ended up executing the initial Ansible command when I realized I should've already spun up the server and set DNS records.
246+
// I'd suggest being more specific about what should I do as a reader. No need to go step by step. Just to clearly state: "Spin up your publicly accessible server", "Now set DNS A records that point to your server"
247+
// JAN: It would also make sense to tell the reader to point both domains to the same server
244248

249+
// JAN: It would also be beneficial to state at least some range of server size (e.g., 2GB of memory). e.g., the smallest EC2 instances can have quite some troubles when running Django in Docker
245250

246251
=== Configuring Domains for Staging and Live
247252

@@ -325,6 +330,8 @@ The "hate" part is that the actual syntax is surprisingly fiddly to get right:
325330
the difference between lists and key/value maps is subtle and I can never quite remember it honestly.]
326331
for.
327332

333+
// JAN: It would be worth mentioning what to do to be able to execute this ansible command. I haven't noticed anything about adding a record to authorized_keys
334+
328335
// DAVID: I didn't know if this was an example or a file to create.
329336
// I think it's the latter, it would be good to make that clear.
330337

@@ -355,6 +362,10 @@ for.
355362
----
356363
====
357364

365+
// JAN: I'm stuck here. Docker is not installed on EC2 instance with Ubuntu. Googling it, it seems like this is some outdated Docker installation process
366+
The one described here is much closer to Docker's installation guide: https://www.digitalocean.com/community/tutorials/how-to-use-ansible-to-install-and-set-up-docker-on-ubuntu-22-04
367+
368+
358369
<1> An Ansible playbook is a series of "tasks"
359370
(so in that sense it's still quite sequential and procedural),
360371
but the individual tasks themselves are quite declarative.

0 commit comments

Comments
 (0)