wip on posts and db

Author: hjwp

chapter_post_and_database.asciidoc

@@ -226,7 +226,6 @@ def test_uses_home_template(self):
     response = self.client.get("/")
     self.assertTemplateUsed(response, "home.html")
 
-
 def test_can_save_a_POST_request(self):
     response = self.client.post("/", data={"item_text": "A new list item"})
     self.assertIn("A new list item", response.content.decode())
@@ -575,31 +574,36 @@ begin to see that our first cut solution really isn't going to, um, cut it:
 ----
 ====
 
-((("", startref="DTtemplate05")))Sure
-enough, the functional tests return an error:
+((("", startref="DTtemplate05")))
+Sure enough, the functional tests return an error:
 
 ----
 AssertionError: '1: Buy peacock feathers' not found in ['1: Use peacock
 feathers to make a fly']
 ----
 
+
 Three Strikes and Refactor
 ~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 
-((("code smell")))((("database testing", "three strikes and refactor rule", id="DTthree05")))((("three strikes and refactor rule", id="threestrikes05")))((("refactoring", id="refactor05")))Before
-we go further--we've got a bad
+((("code smell")))
+((("database testing", "three strikes and refactor rule", id="DTthree05")))
+((("three strikes and refactor rule", id="threestrikes05")))
+((("refactoring", id="refactor05")))
+Before we go further--we've got a bad
 __code smell__footnote:[If you've not come across the concept, a "code smell" is
 something about a piece of code that makes you want to rewrite it. Jeff Atwood
 has http://www.codinghorror.com/blog/2006/05/code-smells.html[a compilation on
 his blog Coding Horror]. The more experience you gain as a programmer, the more
 fine-tuned your nose becomes to code smells...]
-in this FT. We have three
-almost identical code blocks checking for new items in the list table. ((("Don’t Repeat Yourself (DRY)")))There's
-a principle called 'Don't Repeat Yourself' (DRY), which we like to apply by
-following the mantra 'three strikes and refactor'. You can copy and paste code
-once, and it may be premature to try to remove the duplication it causes, but
-once you get three occurrences, it's time to remove duplication.
+in this FT.
+We have three almost identical code blocks checking for new items in the list table.
+((("Don’t Repeat Yourself (DRY)")))There's a principle called 'Don't Repeat Yourself' (DRY),
+which we like to apply by following the mantra 'three strikes and refactor'.
+You can copy and paste code once,
+and it may be premature to try to remove the duplication it causes,
+but once you get three occurrences, it's time to remove duplication.
 
 
 
@@ -888,7 +892,7 @@ The test actually gets surprisingly far:
 ----
 $ pass:quotes[*python manage.py test lists*]
 [...]
-    self.assertEqual(first_saved_item.text, 'The first (ever) list item')
+    self.assertEqual(first_saved_item.text, "The first (ever) list item")
 AttributeError: 'Item' object has no attribute 'text'
 ----
 
@@ -1027,7 +1031,7 @@ response. We can do that by adding three new lines to the existing test called
 
 
 [role="sourcecode"]
-.lists/tests.py
+.lists/tests.py (ch05l019)
 ====
 [source,python]
 ----
@@ -1152,7 +1156,7 @@ class HomePageTest(TestCase):
     [...]
 
     def test_only_saves_items_when_necessary(self):
-        self.client.get('/')
+        self.client.get("/")
         self.assertEqual(Item.objects.count(), 0)
 ----
 ====
@@ -1162,10 +1166,13 @@ quite a small change to the logic of the view, there are quite a few little
 tweaks to the implementation in code:
 
 [role="sourcecode"]
-.lists/views.py (ch05l023)
+.lists/views.py
 ====
 [source,python]
 ----
+from lists.models import Item
+[...]
+
 def home_page(request):
     if request.method == "POST":
         new_item_text = request.POST["item_text"]  # <1>
@@ -1220,14 +1227,14 @@ the item in it, it should redirect back to the home page:
 [source,python]
 ----
     def test_can_save_a_POST_request(self):
-        response = self.client.post('/', data={'item_text': 'A new list item'})
+        response = self.client.post("/", data={"item_text": "A new list item"})
 
         self.assertEqual(Item.objects.count(), 1)
         new_item = Item.objects.first()
-        self.assertEqual(new_item.text, 'A new list item')
+        self.assertEqual(new_item.text, "A new list item")
 
         self.assertEqual(response.status_code, 302)
-        self.assertEqual(response['location'], '/')
+        self.assertEqual(response["location"], "/")
 ----
 ====
 
@@ -1291,17 +1298,16 @@ first go, but now feels like a good time to separate out our concerns:
 [source,python]
 ----
     def test_can_save_a_POST_request(self):
-        self.client.post('/', data={'item_text': 'A new list item'})
+        self.client.post("/", data={"item_text": "A new list item"})
 
         self.assertEqual(Item.objects.count(), 1)
         new_item = Item.objects.first()
-        self.assertEqual(new_item.text, 'A new list item')
-
+        self.assertEqual(new_item.text, "A new list item")
 
     def test_redirects_after_POST(self):
-        response = self.client.post('/', data={'item_text': 'A new list item'})
+        response = self.client.post("/", data={"item_text": "A new list item"})
         self.assertEqual(response.status_code, 302)
-        self.assertEqual(response['location'], '/')
+        self.assertEqual(response["location"], "/")
 ----
 ====
 
@@ -1346,13 +1352,13 @@ class HomePageTest(TestCase):
     [...]
 
     def test_displays_all_list_items(self):
-        Item.objects.create(text='itemey 1')
-        Item.objects.create(text='itemey 2')
+        Item.objects.create(text="itemey 1")
+        Item.objects.create(text="itemey 2")
 
-        response = self.client.get('/')
+        response = self.client.get("/")
 
-        self.assertIn('itemey 1', response.content.decode())
-        self.assertIn('itemey 2', response.content.decode())
+        self.assertIn("itemey 1", response.content.decode())
+        self.assertIn("itemey 2", response.content.decode())
 ----
 ====
 
@@ -1361,7 +1367,7 @@ NOTE: Are you wondering about the line spacing in the test? I'm grouping
       together two lines at the beginning which set up the test, one line in
       the middle which actually calls the code under test, and the
       assertions at the end. This isn't obligatory, but it does help see the
-      structure of the test. Setup, Exercise, Assert is the typical structure
+      structure of the test. Arrange-Act-Assert is the typical structure
       for a unit test.
 
 
@@ -1405,12 +1411,12 @@ pass the items to it from our home page view:
 [source,python]
 ----
 def home_page(request):
-    if request.method == 'POST':
-        Item.objects.create(text=request.POST['item_text'])
-        return redirect('/')
+    if request.method == "POST":
+        Item.objects.create(text=request.POST["item_text"])
+        return redirect("/")
 
     items = Item.objects.all()
-    return render(request, 'home.html', {'items': items})
+    return render(request, "home.html", {"items": items})
 ----
 ====
 
@@ -1465,9 +1471,9 @@ project directory:
 # https://docs.djangoproject.com/en/4.1/ref/settings/#databases
 
 DATABASES = {
-    'default': {
-        'ENGINE': 'django.db.backends.sqlite3',
-        'NAME': BASE_DIR / 'db.sqlite3',
+    "default": {
+        "ENGINE": "django.db.backends.sqlite3",
+        "NAME": BASE_DIR / "db.sqlite3",
     }
 }
 ----
@@ -1543,7 +1549,7 @@ Django template tag, `forloop.counter`, will help here:
 If you try it again, you should now see the FT get to the end:
 
 ----
-    self.fail('Finish the test!')
+    self.fail("Finish the test!")
 AssertionError: Finish the test!
 ----
 

source/chapter_post_and_database/superlists

@@ -25,7 +25,7 @@ def test_listings_and_commands_and_output(self):
         assert "request.POST.get" in self.listings[views_pos].contents
 
         nutemplate_pos = 77
-        assert "{'items': items}" in self.listings[nutemplate_pos].contents
+        assert '{"items": items}' in self.listings[nutemplate_pos].contents
 
         migrate_pos = 81
         assert 'migrate' in self.listings[migrate_pos]