Review chapter_09_docker.asciidoc

Author: jangia

chapter_09_docker.asciidoc

@@ -557,6 +557,8 @@ What do we need to do?  Something like this, right?
 We create a new file called _Dockerfile_ in the base folder of our repo,
 next to the `src/` directory we made earlier:
 
+// JAN: I'd suggest to use python3.11:slim or python3:12 slim. Keeping image tags too open leads to issues in a couple of months (not always, but waaay too often)
+// JAN: I'd use Docker comments with # for <1>, <2>, ... Otherwise, you need to edit the code when you paste it
 
 .Dockerfile (ch09l003)
 ====
@@ -806,7 +808,7 @@ with `docker ps`:
 
 [role="skipme small-code"]
 ----
-$ *docker ps
+$ *docker ps*
 CONTAINER ID   IMAGE        COMMAND                  CREATED         STATUS         PORTS     NAMES
 0818e1b8e9bf   superlists   "/bin/sh -c 'python …"   4 seconds ago   Up 4 seconds             hardcore_moore
 ----
@@ -1237,7 +1239,7 @@ NOTE: If you don't see this error,
     and you should be able to repro the error.  I promise it's instructive!
 
 
-==== Should we run "migrate" inside the Dockerfile? No.
+==== Should we run "migrate" inside the Dockerfile? No.  // JAN: Not sure I understand this line. You're saying that we shouldn't run migrate inside our Dockerfile, but then in the next line you do exactly that
 
 So, should we include `manage.py migrate` in our Dockerfile?
 
@@ -1259,7 +1261,7 @@ CMD python manage.py runserver
 <1> We run `migrate` using the `--noinput` argument to suppress any little "are you sure" prompts.
 
 
-If we try our FTs again, they all pass!
+If we try our FTs again, they all pass!  // JAN: That's not true. One needs to rebuild the Docker image and start a new container
 
 
 [role="small-code"]
@@ -1306,6 +1308,8 @@ CMD python manage.py runserver
 ----
 ====
 
+// JAN: I assume you meant to keep CMD python manage.py runserver 0.0.0.0:8888 as is and just remove migrations. Without that, port mapping won't work and server won't listen to external connections
+
 Let's start by re-creating the database with `migrate`
 (when we moved everything into `./src`, we left the database file behind):