Merge branch 'nu-js-chap'

Author: hjwp

.gitmodules

@@ -38,7 +38,7 @@
 	path = source/chapter_15_advanced_forms/superlists
 	url = [email protected]:hjwp/book-example.git
 [submodule "source/chapter_14/superlists"]
-	path = source/chapter_javascript/superlists
+	path = source/chapter_16_javascript/superlists
 	url = [email protected]:hjwp/book-example.git
 [submodule "source/chapter_15/superlists"]
 	path = source/chapter_deploying_validation/superlists

Makefile

@@ -128,9 +128,9 @@ test_chapter_14_simple_form: chapter_14_simple_form.html $(TMPDIR) .venv/bin
 .PHONY: test_chapter_15_advanced_forms
 test_chapter_15_advanced_forms: chapter_15_advanced_forms.html $(TMPDIR) .venv/bin
 	.venv/bin/pytest -s --tb=short ./tests/test_chapter_15_advanced_forms.py
-.PHONY: test_chapter_javascript
-test_chapter_javascript: chapter_javascript.html $(TMPDIR) .venv/bin
-	.venv/bin/pytest -s --tb=short ./tests/test_chapter_javascript.py
+.PHONY: test_chapter_16_javascript
+test_chapter_16_javascript: chapter_16_javascript.html $(TMPDIR) .venv/bin
+	.venv/bin/pytest -s --tb=short ./tests/test_chapter_16_javascript.py
 .PHONY: test_chapter_deploying_validation
 test_chapter_deploying_validation: chapter_deploying_validation.html $(TMPDIR) .venv/bin
 	.venv/bin/pytest -s --tb=short ./tests/test_chapter_deploying_validation.py

appendix_github_links.asciidoc

@@ -34,7 +34,7 @@ Full List of Links for Each Chapter
 <<chapter_13_database_layer_validation>>:: https://github.com/hjwp/book-example/tree/chapter_13_database_layer_validation
 <<chapter_14_simple_form>>:: https://github.com/hjwp/book-example/tree/chapter_14_simple_form
 <<chapter_15_advanced_forms>>:: https://github.com/hjwp/book-example/tree/chapter_15_advanced_forms
-<<chapter_javascript>>:: https://github.com/hjwp/book-example/tree/chapter_javascript
+<<chapter_16_javascript>>:: https://github.com/hjwp/book-example/tree/chapter_16_javascript
 <<chapter_deploying_validation>>:: https://github.com/hjwp/book-example/tree/chapter_deploying_validation
 <<chapter_spiking_custom_auth>>:: https://github.com/hjwp/book-example/tree/chapter_spiking_custom_auth
 <<chapter_mocking>>:: https://github.com/hjwp/book-example/tree/chapter_mocking

appendix_rest_api.asciidoc

@@ -866,7 +866,7 @@ QUnit.test("should call updateItems after successful post", function (assert) {
 <1> First important thing to notice:  We only set up our server response
     'after' we do the initialize.  We want this to be the response to the
     POST request that happens on form submit, not the response to the
-    initial GET request. (Remember our lesson from <<chapter_javascript>>?
+    initial GET request. (Remember our lesson from <<chapter_16_javascript>>?
     One of the most challenging things about JS testing is controlling the
     order of execution.)
 

atlas.json

@@ -27,7 +27,7 @@
     "chapter_13_database_layer_validation.asciidoc",
     "chapter_14_simple_form.asciidoc",
     "chapter_15_advanced_forms.asciidoc",
-    "chapter_javascript.asciidoc",
+    "chapter_16_javascript.asciidoc",
     "chapter_deploying_validation.asciidoc",
     "part3.asciidoc",
     "chapter_spiking_custom_auth.asciidoc",

book.asciidoc

@@ -37,7 +37,7 @@ include::chapter_12_organising_test_files.asciidoc[]
 include::chapter_13_database_layer_validation.asciidoc[]
 include::chapter_14_simple_form.asciidoc[]
 include::chapter_15_advanced_forms.asciidoc[]
-include::chapter_javascript.asciidoc[]
+include::chapter_16_javascript.asciidoc[]
 include::chapter_deploying_validation.asciidoc[]
 
 include::part3.forbook.asciidoc[]

chapter_javascript.asciidoc renamed to chapter_16_javascript.asciidoc

@@ -1,4 +1,4 @@
-[[chapter_javascript]]
+[[chapter_16_javascript]]
 Dipping Our Toes, Very Tentatively, [keep-together]#into JavaScript#
 --------------------------------------------------------------------
 
@@ -303,6 +303,8 @@ QUnit.test("smoke test", function (assert) {
 ====
 //ch14l006
 
+// TODO: is:visible  can be replace by checkVisibility: https://stackoverflow.com/a/72717388/366221
+
 <1> The `<form>` and its contents are there to represent what will be
     on the real list page.
 

rename-chapter.sh

@@ -5,17 +5,18 @@ set -o pipefail
 OLD_CHAPTER=$1
 NEW_NAME=$2
 
-# git mv "$OLD_CHAPTER.asciidoc" "$NEW_NAME.asciidoc"
-# git mv "tests/test_$OLD_CHAPTER.py" "tests/test_$NEW_NAME.py"
-#
-# git mv "source/$OLD_CHAPTER" "source/$NEW_NAME"
-#
-# cd "source/$NEW_NAME/superlists" 
-# git checkout "$OLD_CHAPTER"
-# git checkout -b "$NEW_NAME"
-# git push -u local
-# git push -u origin
-# cd ../../..
+git mv "$OLD_CHAPTER.asciidoc" "$NEW_NAME.asciidoc"
+mv "$OLD_CHAPTER.html" "$NEW_NAME.html" || touch "$NEW_NAME.html"
+git mv "tests/test_$OLD_CHAPTER.py" "tests/test_$NEW_NAME.py"
+
+git mv "source/$OLD_CHAPTER" "source/$NEW_NAME"
+
+cd "source/$NEW_NAME/superlists" 
+git checkout "$OLD_CHAPTER"
+git checkout -b "$NEW_NAME"
+git push -u local
+git push -u origin
+cd ../../..
 
 git grep -l "$OLD_CHAPTER" | xargs sed -i '' "s/$OLD_CHAPTER/$NEW_NAME/g"
 

source/chapter_javascript/superlists renamed to source/chapter_16_javascript/superlists

@@ -16,7 +16,7 @@
     "chapter_13_database_layer_validation",
     "chapter_14_simple_form",
     "chapter_15_advanced_forms",
-    "chapter_javascript",
+    "chapter_16_javascript",
     "chapter_deploying_validation",
     # part 3
     "chapter_spiking_custom_auth",