Skip to content

Commit ae23fb3

Browse files
committed
some handwritten todos
1 parent 7256cb8 commit ae23fb3

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

chapter_18_spiking_custom_auth.asciidoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ so please send feedback! [email protected]
1212
1313
*******************************************************************************
1414

15-
((("authentication", id="Adespike18")))
15+
((("authentication", id="AuthSpike18")))
1616
Our beautiful lists site has been live for a few days, and our users are
1717
starting to come back to us with feedback. "We love the site", they say, "but
1818
we keep losing our lists. Manually remembering URLs is hard. It'd be great if
@@ -883,7 +883,7 @@ Next let's rebuild our minimal user model, with tests this time, and see
883883
if it turns out neater than it did in the spike.
884884
((("", startref="SDde18")))
885885

886-
886+
// TODO: consider starting with a test for the login view instead.
887887

888888
=== A Minimal Custom User Model
889889

@@ -1353,6 +1353,6 @@ Writing your FT against spiked code::
13531353
reimplementing a very similar solution to your spiked one;
13541354
something to watch out for.
13551355
((("functional tests (FTs)", "spiked code and")))
1356-
((("", startref="Adespike18")))
1356+
((("", startref="AuthSpike18")))
13571357
*******************************************************************************
13581358

chapter_mocking.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ any emails it sends by using the `mail.outbox` attribute.
2222
But in this chapter, I want to demonstrate a very important testing technique called 'mocking',
2323
so for the purpose of these unit tests, we'll pretend that this nice Django shortcut doesn't exist.
2424

25-
Am I telling you not to use Django's `mail.outbox`?
25+
Am I telling you _not_ to use Django's `mail.outbox`?
2626
No; use it, it's a neat shortcut.
2727
But I want to teach mocks because they're a useful general-purpose tool
2828
for unit testing external dependencies.

todos.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,14 @@
22

33
# Later
44

5+
- spike chap: start with test of login view.
6+
- count all TR notes per chapter
7+
- massive updates in 11
8+
- idea, get rid of model-layer tests
9+
- "switch to flask" appendix
10+
11+
12+
513
* rewrites
614

715

0 commit comments

Comments
 (0)