Skip to content

Commit b5036e7

Browse files
committed
Rename js chapter to chapter_16_javascript
1 parent 9459cb0 commit b5036e7

11 files changed

+19
-19
lines changed

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
path = source/chapter_15_advanced_forms/superlists
3939
url = [email protected]:hjwp/book-example.git
4040
[submodule "source/chapter_14/superlists"]
41-
path = source/chapter_javascript/superlists
41+
path = source/chapter_16_javascript/superlists
4242
url = [email protected]:hjwp/book-example.git
4343
[submodule "source/chapter_15/superlists"]
4444
path = source/chapter_deploying_validation/superlists

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,9 @@ test_chapter_14_simple_form: chapter_14_simple_form.html $(TMPDIR) .venv/bin
128128
.PHONY: test_chapter_15_advanced_forms
129129
test_chapter_15_advanced_forms: chapter_15_advanced_forms.html $(TMPDIR) .venv/bin
130130
.venv/bin/pytest -s --tb=short ./tests/test_chapter_15_advanced_forms.py
131-
.PHONY: test_chapter_javascript
132-
test_chapter_javascript: chapter_javascript.html $(TMPDIR) .venv/bin
133-
.venv/bin/pytest -s --tb=short ./tests/test_chapter_javascript.py
131+
.PHONY: test_chapter_16_javascript
132+
test_chapter_16_javascript: chapter_16_javascript.html $(TMPDIR) .venv/bin
133+
.venv/bin/pytest -s --tb=short ./tests/test_chapter_16_javascript.py
134134
.PHONY: test_chapter_deploying_validation
135135
test_chapter_deploying_validation: chapter_deploying_validation.html $(TMPDIR) .venv/bin
136136
.venv/bin/pytest -s --tb=short ./tests/test_chapter_deploying_validation.py

appendix_github_links.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Full List of Links for Each Chapter
3434
<<chapter_13_database_layer_validation>>:: https://github.com/hjwp/book-example/tree/chapter_13_database_layer_validation
3535
<<chapter_14_simple_form>>:: https://github.com/hjwp/book-example/tree/chapter_14_simple_form
3636
<<chapter_15_advanced_forms>>:: https://github.com/hjwp/book-example/tree/chapter_15_advanced_forms
37-
<<chapter_javascript>>:: https://github.com/hjwp/book-example/tree/chapter_javascript
37+
<<chapter_16_javascript>>:: https://github.com/hjwp/book-example/tree/chapter_16_javascript
3838
<<chapter_deploying_validation>>:: https://github.com/hjwp/book-example/tree/chapter_deploying_validation
3939
<<chapter_spiking_custom_auth>>:: https://github.com/hjwp/book-example/tree/chapter_spiking_custom_auth
4040
<<chapter_mocking>>:: https://github.com/hjwp/book-example/tree/chapter_mocking

appendix_rest_api.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -866,7 +866,7 @@ QUnit.test("should call updateItems after successful post", function (assert) {
866866
<1> First important thing to notice: We only set up our server response
867867
'after' we do the initialize. We want this to be the response to the
868868
POST request that happens on form submit, not the response to the
869-
initial GET request. (Remember our lesson from <<chapter_javascript>>?
869+
initial GET request. (Remember our lesson from <<chapter_16_javascript>>?
870870
One of the most challenging things about JS testing is controlling the
871871
order of execution.)
872872

atlas.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"chapter_13_database_layer_validation.asciidoc",
2828
"chapter_14_simple_form.asciidoc",
2929
"chapter_15_advanced_forms.asciidoc",
30-
"chapter_javascript.asciidoc",
30+
"chapter_16_javascript.asciidoc",
3131
"chapter_deploying_validation.asciidoc",
3232
"part3.asciidoc",
3333
"chapter_spiking_custom_auth.asciidoc",

book.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ include::chapter_12_organising_test_files.asciidoc[]
3737
include::chapter_13_database_layer_validation.asciidoc[]
3838
include::chapter_14_simple_form.asciidoc[]
3939
include::chapter_15_advanced_forms.asciidoc[]
40-
include::chapter_javascript.asciidoc[]
40+
include::chapter_16_javascript.asciidoc[]
4141
include::chapter_deploying_validation.asciidoc[]
4242

4343
include::part3.forbook.asciidoc[]

chapter_javascript.asciidoc renamed to chapter_16_javascript.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
[[chapter_javascript]]
1+
[[chapter_16_javascript]]
22
Dipping Our Toes, Very Tentatively, [keep-together]#into JavaScript#
33
--------------------------------------------------------------------
44

tests/chapters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"chapter_13_database_layer_validation",
1717
"chapter_14_simple_form",
1818
"chapter_15_advanced_forms",
19-
"chapter_javascript",
19+
"chapter_16_javascript",
2020
"chapter_deploying_validation",
2121
# part 3
2222
"chapter_spiking_custom_auth",

tests/test_book_tester.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1009,30 +1009,30 @@ def test_contains_iteslf(self):
10091009
@pytest.mark.skipif(not shutil.which("phantomjs"), reason="PhantomJS not available")
10101010
class CheckQunitOuptutTest(ChapterTest):
10111011
def test_partial_listing_passes(self):
1012-
self.chapter_name = "chapter_javascript"
1012+
self.chapter_name = "chapter_16_javascript"
10131013
self.sourcetree.start_with_checkout(
1014-
"chapter_deploying_validation", "chapter_javascript"
1014+
"chapter_deploying_validation", "chapter_16_javascript"
10151015
)
10161016
expected = Output("2 assertions of 2 passed, 0 failed.")
10171017
self.check_qunit_output(expected) # should pass
10181018
assert expected.was_checked
10191019

10201020
def test_fails_if_lists_fail_and_no_accounts(self):
1021-
self.chapter_name = "chapter_javascript"
1021+
self.chapter_name = "chapter_16_javascript"
10221022
self.sourcetree.start_with_checkout(
1023-
"chapter_deploying_validation", "chapter_javascript"
1023+
"chapter_deploying_validation", "chapter_16_javascript"
10241024
)
10251025
with self.assertRaises(AssertionError):
10261026
self.check_qunit_output(Output("arg"))
10271027

10281028
def test_runs_phantomjs_runner_against_lists_tests(self):
1029-
self.chapter_name = "chapter_javascript"
1029+
self.chapter_name = "chapter_16_javascript"
10301030
self.sourcetree.start_with_checkout(
1031-
"chapter_deploying_validation", "chapter_javascript"
1031+
"chapter_deploying_validation", "chapter_16_javascript"
10321032
)
10331033
lists_tests = os.path.join(
10341034
os.path.abspath(os.path.dirname(__file__)),
1035-
"../source/chapter_javascript/superlists/lists/static/tests/tests.html",
1035+
"../source/chapter_16_javascript/superlists/lists/static/tests/tests.html",
10361036
)
10371037

10381038
manual_run = subprocess.check_output(
@@ -1045,7 +1045,7 @@ def test_runs_phantomjs_runner_against_lists_tests(self):
10451045
def DONTtest_runs_against_accounts_if_lists_pass(self):
10461046
self.chapter_name = "chapter_deploying_validation"
10471047
self.sourcetree.start_with_checkout(
1048-
"chapter_deploying_validation", "chapter_javascript"
1048+
"chapter_deploying_validation", "chapter_16_javascript"
10491049
)
10501050
lists_tests = os.path.abspath(
10511051
os.path.join(

0 commit comments

Comments
 (0)