Merge pull request #243 from ritaf-ORM/patch-8

Rita's edits to ch 13

Author: hjwp

chapter_13_database_layer_validation.asciidoc

@@ -1,6 +1,7 @@
 [[chapter_13_database_layer_validation]]
 == Validation at the Database Layer
 
+// RITA: Update the warning since you have reviewed the chapter text in detail?
 .🚧 Warning, Chapter update in progress
 *******************************************************************************
 This chapter is currently in the process of being rewritten for the 3e.
@@ -256,6 +257,7 @@ been passed an error variable, and if so, we do this:
 <1> We add the `.is-invalid` class to an form inputs with validation errors
 <2> We use a `div.invalid-feedback` to display any error messages from the server.
 
+// RITA: Perhaps put the Bootstrap docs note and the footnote text into a tip box?
 ((("Bootstrap", "documentation")))
 ((("form control classes (Bootstrap)")))
 Take a look at the https://getbootstrap.com/docs/5.3/forms/validation/#server-side[Bootstrap docs] for more
@@ -360,7 +362,7 @@ blank.']}
 
 So we try our first approach:  using a `try/except` to detect errors. Obeying
 the Testing Goat, we start with just the `try/except` and nothing else.  The
-tests should tell us what to code next...
+tests should tell us what to code next.
 
 [role="sourcecode"]
 .src/lists/views.py (ch11l025)
@@ -974,7 +976,7 @@ NOTE: One of the reasons that the "three strikes and refactor" rule exists is th
     if you wait until you have three use cases, each might be slightly different,
     and it gives you a better view for what the common functionality is.
     If you refactor too early,
-    you may find that the third use case doesn't quite fit with your refactored code...
+    you may find that the third use case doesn't quite fit with your refactored code.
     ((("database testing", "three strikes and refactor rule")))
     ((("Test-Driven Development (TDD)", "concepts", "three strikes and refactor")))
     ((("three strikes and refactor rule")))
@@ -1068,14 +1070,14 @@ OK
 $ pass:quotes[*python src/manage.py test functional_tests*]
 OK
 ----
-
+// RITA: Perhaps add a few words after "Excellent" to explain what you're doing?
 Excellent:
 
 [subs="specialcharacters,quotes"]
 ----
 $ *git commit -am "Refactor hard-coded URLs out of templates"*
 ----
-
+// RITA: Please add a sentence to give the figure context. "Let's remove the item from our scratchpad." 
 [role="scratchpad"]
 *****
 * 'Remove hardcoded URLs from views.py'
@@ -1208,7 +1210,7 @@ $ pass:quotes[*python src/manage.py test functional_tests*]
 OK
 ----
 
-Cross off our to-dos...
+Time to cross off our to-dos...
 
 [role="scratchpad"]
 *****
@@ -1218,7 +1220,7 @@ Cross off our to-dos...
 * 'Remove duplication of validation logic in views'
 *****
 
-And a commit...
+And commit...
 
 [subs="specialcharacters,quotes"]
 ----
@@ -1231,7 +1233,7 @@ and we've taken the opportunity to do a few refactors along the way.
 ((("", startref="MLVhard13")))((("", startref="url13")))
 
 
-That final scratchpad item will be the subject of the next chapter...
+That final scratchpad item will be the subject of the next chapter.
 
 .On Database-Layer Validation
 *******************************************************************************