Skip to content

Commit d60252d

Browse files
committed
todo from seb
1 parent 86b0bb1 commit d60252d

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

chapter_10_production_readiness.asciidoc

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,11 +292,18 @@ whitenoise==6.6.0
292292
====
293293

294294

295+
That's a good first cut, let's commit it:
296+
297+
// SEBASTIAN I am not very fond of freezing just "top-level" dependencies of the project,
298+
// . This is not guaranteeing the reproducible builds and I failed to build & deploy because of that more than once.
299+
// But I understand it's a trade-off so the reader does get bogged down.
300+
// TODO: add a note about this and a link to some more reading
301+
295302
----
296-
# that's a good first cut, let's commit it:
297303
$ *git add requirements.txt*
298304
$ *git commit -m "Add a requirements.txt with Django, gunicorn and whitenoise"*
299305
----
306+
300307
You may be wondering why we didn't add our other dependency,
301308
Selenium, to our requirements,
302309
or why we didn't just add _all_ the dependencies,

0 commit comments

Comments
 (0)