Skip to content

Commit ec0746d

Browse files
committed
chapter 11: Getting our image onto the server: remove comment
This commit removes a comment. 26ea97a added a comment about an error I encountered when I executed the `ansible-playbook ...` command in section 'Getting our image onto the server'. Xronophobe was able to reproduce the error only when the user - `pip install ansible` and - does not `pip install docker` That is what I did. In the current version of the book at [online](https://www.obeythetestinggoat.com/book/chapter_11_ansible.html#_installing_ansible) I saw only the requirement to install ansible. I failed to look at the current version of the code in the [repository](https://github.com/hjwp/Book-TDD-Web-Dev-Python/blob/main/chapter_11_ansible.asciidoc?plain=1#L320-L322) and see the additional requirement to install the docker python package. So, this commit removes that comment. Other users will not encounter the error I did because they will both: - pip install ansible, and - pip install docker
1 parent 26ea97a commit ec0746d

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

chapter_11_ansible.asciidoc

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -690,13 +690,6 @@ false, "AttachStdout": true, "Cmd": ["gunicorn", "--bind", ":8888",
690690
// check their user has permission.
691691
// DAVID: by the way it's getting annoying having to type my sudo password in all the time.
692692

693-
// ZIPPERER: I got error
694-
// TASK [Export container image locally]
695-
// ... ModuleNotFoundError: No module named 'requests'
696-
// "Failed to import the required Python library (requests) on <local hostname>'s Python ../.venv/bin/python3.
697-
//
698-
// No error after I installed library `requests` in venv (i.e. `python3 -m pip install requests`) and reran the `ansible-playbook` command.
699-
700693
For completeness, let's also add a step to explicitly build the image locally.
701694
This means we don't have a dependency on having run `docker build` locally.
702695

0 commit comments

Comments
 (0)