Merge branch 'StephanieAG-StephanieAG-patch-1-OTG'

Author: hjwp

chapter_10_production_readiness.asciidoc

@@ -212,7 +212,14 @@ Believe it or not, this pun didn't actually hit me until I was rewriting this ch
 For 10 years it was right under my nose. I think that makes it funnier actually.]
 files from Python.
 
-This is how we tell Django to enable it, in _settings.py_:
+First we install whitenoise into our local environment:
+
+[source,python]
+----
+pip install whitenoise
+----
+
+Then we tell Django to enable it, in _settings.py_:
 
 [role="sourcecode"]
 .src/superlists/settings.py (ch10l002)
@@ -260,9 +267,6 @@ Let's rerun our FTs to confirm:
 // If we do that, however, we'll need to make sure readers rebuild the image each time
 // we add a requirement - such as at this point.
 
-
-// JAN: That doesn't work until you install whitenoise to venv on local machine
-
 [role="small-code"]
 [subs="specialcharacters,macros"]
 ----
@@ -378,6 +382,7 @@ $ *git add requirements.txt*
 $ *git commit -m "Add a requirements.txt with Django, gunicorn and whitenoise"*
 ----
 
+
 You may be wondering why we didn't add our other dependency,
 Selenium, to our requirements,
 or why we didn't just add _all_ the dependencies,
@@ -447,7 +452,7 @@ TIP: Forgetting the `-r` and running `pip install requirements.txt`
 // since it's related to the app being production ready).
 // TODO yep let's definitely do this.
 
-Let's do a build & run & test to check everything still works:
+Let's build & run: 
 
 [subs="specialcharacters,quotes"]
 ----
@@ -457,6 +462,18 @@ $ *docker build -t superlists . && docker run \
   -it superlists*
 ----
 
+And then test to check everything still works:
+
+[role="small-code"]
+[subs="specialcharacters,macros"]
+----
+$ pass:quotes[*TEST_SERVER=localhost:8888 python src/manage.py test functional_tests \
+  --failfast*]
+[...]
+
+OK
+----
+
 === Using Environment Variables to Adjust Settings for Production
 
 ((("DEBUG settings")))
@@ -495,9 +512,10 @@ Environment variables also have the advantage of working for non-Django stuff to
 There are lots of ways you might do this.
 
 Here's what I propose; it may seem a little fiddly,
-but I'll provide a little justification for each choice.
+but I'll provide a little justification for each choice.   
 Let them be an inspiration (but not a template) for your own choices!
 
+Note that this if statement replaces the DEBUG and SECRET_KEY lines that are included by default in the settings.py file:
 
 [role="sourcecode"]
 .superlists/settings.py (ch10l006)
@@ -745,7 +763,15 @@ CMD gunicorn --bind :8888 superlists.wsgi:application
 
 // TODO: gitignore src/static
 
-Well, it was fiddly, but that should get us to passing tests!
+Well, it was fiddly, but that should get us to passing tests after we build & run the docker container!
+
+[subs="specialcharacters,quotes"]
+----
+$ *docker build -t superlists . && docker run \
+  -p 8888:8888 \
+  --mount type=bind,source=./src/db.sqlite3,target=/src/db.sqlite3 \
+  -it superlists*
+----
 
 
 [role="small-code"]
@@ -861,7 +887,7 @@ If you're like me you might find yourself wondering if we really _did_ see them
 and starting to doubt your own sanity.
 But the explanation is that Django's
 https://docs.djangoproject.com/en/4.2/ref/logging/#default-logging-configuration[default logging configuration]
-changes when DEBUG is turned off:
+changes when DEBUG is turned off.
 
 This means we need to interact with the standard library's `logging` module,
 unfortunately one of the most fiddly parts of the Python standard libraryfootnote:[
@@ -873,7 +899,7 @@ but sometimes you just wanna say "just print stuff to stdout pls",
 and you wish that configuring the simplest thing was a little easier.].
 
 Here's pretty much the simplest possible logging config
-which just prints everything to the console (i.e. standard out).
+which just prints everything to the console (i.e. standard out). I've added this code to the very end of the settings.py file. 
 
 
 [role="sourcecode"]