Merge pull request #49 from hkulekci/value-could-be-zero

OptimizersConfig parameter values could be zero

Author: hkulekci

src/Models/Request/CollectionConfig/OptimizersConfig.php

@@ -110,28 +110,28 @@ public function setMaxOptimizationThreads(?int $maxOptimizationThreads): Optimiz
     public function toArray(): array
     {
         $data = [];
-        if ($this->deletedThreshold) {
+        if ($this->deletedThreshold !== null) {
             $data['deleted_threshold'] = $this->deletedThreshold;
         }
-        if ($this->vacuumMinVectorNumber) {
+        if ($this->vacuumMinVectorNumber !== null) {
             $data['vacuum_min_vector_number'] = $this->vacuumMinVectorNumber;
         }
-        if ($this->defaultSegmentNumber) {
+        if ($this->defaultSegmentNumber !== null) {
             $data['default_segment_number'] = $this->defaultSegmentNumber;
         }
-        if ($this->maxSegmentSize) {
+        if ($this->maxSegmentSize !== null) {
             $data['max_segment_size'] = $this->maxSegmentSize;
         }
-        if ($this->memmapThreshold) {
+        if ($this->memmapThreshold !== null) {
             $data['memmap_threshold'] = $this->memmapThreshold;
         }
-        if ($this->indexingThreshold) {
+        if ($this->indexingThreshold !== null) {
             $data['indexing_threshold'] = $this->indexingThreshold;
         }
-        if ($this->flushIntervalSec) {
+        if ($this->flushIntervalSec !== null) {
             $data['flush_interval_sec'] = $this->flushIntervalSec;
         }
-        if ($this->maxOptimizationThreads) {
+        if ($this->maxOptimizationThreads !== null) {
             $data['max_optimization_threads'] = $this->maxOptimizationThreads;
         }
 

tests/Unit/Models/Request/CollectionConfig/OptimizerConfigTest.php

@@ -18,6 +18,30 @@ public function testBasic(): void
         $this->assertEquals([], $config->toArray());
     }
 
+    public function testWithValueZero(): void
+    {
+        $config = (new OptimizersConfig())
+            ->setDeletedThreshold(0)
+            ->setVacuumMinVectorNumber(0)
+            ->setDefaultSegmentNumber(0)
+            ->setMaxSegmentSize(0)
+            ->setMemmapThreshold(0)
+            ->setIndexingThreshold(0)
+            ->setFlushIntervalSec(0)
+            ->setMaxOptimizationThreads(0);
+
+        $this->assertEquals([
+            'deleted_threshold' => 0.0,
+            'vacuum_min_vector_number' => 0,
+            'default_segment_number' => 0,
+            'max_segment_size' => 0,
+            'memmap_threshold' => 0,
+            'indexing_threshold' => 0,
+            'flush_interval_sec' => 0,
+            'max_optimization_threads' => 0,
+        ], $config->toArray());
+    }
+
     public function testWithIndexingThreshold(): void
     {
         $config = (new OptimizersConfig())->setIndexingThreshold(10);