Skip to content

Commit b75b204

Browse files
puhukpuhuk
authored
Fix max_shift value in flux and related functions to 1.15 (issue huggingface#10675) (huggingface#10807)
This PR updates the max_shift value in flux to 1.15 for consistency across the codebase. In addition to modifying max_shift in flux, all related functions that copy and use this logic, such as calculate_shift in `src/diffusers/pipelines/stable_diffusion_3/pipeline_stable_diffusion_3_img2img.py`, have also been updated to ensure uniform behavior.
1 parent c14057c commit b75b204

20 files changed

+37
-37
lines changed

‎examples/community/pipeline_flux_differential_img2img.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def calculate_shift(
8787
base_seq_len: int = 256,
8888
max_seq_len: int = 4096,
8989
base_shift: float = 0.5,
90-
max_shift: float = 1.16,
90+
max_shift: float = 1.15,
9191
):
9292
m = (max_shift - base_shift) / (max_seq_len - base_seq_len)
9393
b = base_shift - m * base_seq_len
@@ -878,7 +878,7 @@ def __call__(
878878
self.scheduler.config.get("base_image_seq_len", 256),
879879
self.scheduler.config.get("max_image_seq_len", 4096),
880880
self.scheduler.config.get("base_shift", 0.5),
881-
self.scheduler.config.get("max_shift", 1.16),
881+
self.scheduler.config.get("max_shift", 1.15),
882882
)
883883
timesteps, num_inference_steps = retrieve_timesteps(
884884
self.scheduler,

‎examples/community/pipeline_flux_rf_inversion.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def calculate_shift(
9494
base_seq_len: int = 256,
9595
max_seq_len: int = 4096,
9696
base_shift: float = 0.5,
97-
max_shift: float = 1.16,
97+
max_shift: float = 1.15,
9898
):
9999
m = (max_shift - base_shift) / (max_seq_len - base_seq_len)
100100
b = base_shift - m * base_seq_len
@@ -823,7 +823,7 @@ def __call__(
823823
self.scheduler.config.get("base_image_seq_len", 256),
824824
self.scheduler.config.get("max_image_seq_len", 4096),
825825
self.scheduler.config.get("base_shift", 0.5),
826-
self.scheduler.config.get("max_shift", 1.16),
826+
self.scheduler.config.get("max_shift", 1.15),
827827
)
828828
timesteps, num_inference_steps = retrieve_timesteps(
829829
self.scheduler,
@@ -993,7 +993,7 @@ def invert(
993993
self.scheduler.config.get("base_image_seq_len", 256),
994994
self.scheduler.config.get("max_image_seq_len", 4096),
995995
self.scheduler.config.get("base_shift", 0.5),
996-
self.scheduler.config.get("max_shift", 1.16),
996+
self.scheduler.config.get("max_shift", 1.15),
997997
)
998998
timesteps, num_inversion_steps = retrieve_timesteps(
999999
self.scheduler,

‎examples/community/pipeline_flux_semantic_guidance.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def calculate_shift(
9191
base_seq_len: int = 256,
9292
max_seq_len: int = 4096,
9393
base_shift: float = 0.5,
94-
max_shift: float = 1.16,
94+
max_shift: float = 1.15,
9595
):
9696
m = (max_shift - base_shift) / (max_seq_len - base_seq_len)
9797
b = base_shift - m * base_seq_len
@@ -1041,7 +1041,7 @@ def __call__(
10411041
self.scheduler.config.get("base_image_seq_len", 256),
10421042
self.scheduler.config.get("max_image_seq_len", 4096),
10431043
self.scheduler.config.get("base_shift", 0.5),
1044-
self.scheduler.config.get("max_shift", 1.16),
1044+
self.scheduler.config.get("max_shift", 1.15),
10451045
)
10461046
timesteps, num_inference_steps = retrieve_timesteps(
10471047
self.scheduler,

‎examples/community/pipeline_flux_with_cfg.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def calculate_shift(
7070
base_seq_len: int = 256,
7171
max_seq_len: int = 4096,
7272
base_shift: float = 0.5,
73-
max_shift: float = 1.16,
73+
max_shift: float = 1.15,
7474
):
7575
m = (max_shift - base_shift) / (max_seq_len - base_seq_len)
7676
b = base_shift - m * base_seq_len
@@ -759,7 +759,7 @@ def __call__(
759759
self.scheduler.config.get("base_image_seq_len", 256),
760760
self.scheduler.config.get("max_image_seq_len", 4096),
761761
self.scheduler.config.get("base_shift", 0.5),
762-
self.scheduler.config.get("max_shift", 1.16),
762+
self.scheduler.config.get("max_shift", 1.15),
763763
)
764764
timesteps, num_inference_steps = retrieve_timesteps(
765765
self.scheduler,

‎src/diffusers/pipelines/flux/pipeline_flux.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def calculate_shift(
7575
base_seq_len: int = 256,
7676
max_seq_len: int = 4096,
7777
base_shift: float = 0.5,
78-
max_shift: float = 1.16,
78+
max_shift: float = 1.15,
7979
):
8080
m = (max_shift - base_shift) / (max_seq_len - base_seq_len)
8181
b = base_shift - m * base_seq_len
@@ -849,7 +849,7 @@ def __call__(
849849
self.scheduler.config.get("base_image_seq_len", 256),
850850
self.scheduler.config.get("max_image_seq_len", 4096),
851851
self.scheduler.config.get("base_shift", 0.5),
852-
self.scheduler.config.get("max_shift", 1.16),
852+
self.scheduler.config.get("max_shift", 1.15),
853853
)
854854
timesteps, num_inference_steps = retrieve_timesteps(
855855
self.scheduler,

‎src/diffusers/pipelines/flux/pipeline_flux_control.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def calculate_shift(
8888
base_seq_len: int = 256,
8989
max_seq_len: int = 4096,
9090
base_shift: float = 0.5,
91-
max_shift: float = 1.16,
91+
max_shift: float = 1.15,
9292
):
9393
m = (max_shift - base_shift) / (max_seq_len - base_seq_len)
9494
b = base_shift - m * base_seq_len
@@ -802,7 +802,7 @@ def __call__(
802802
self.scheduler.config.get("base_image_seq_len", 256),
803803
self.scheduler.config.get("max_image_seq_len", 4096),
804804
self.scheduler.config.get("base_shift", 0.5),
805-
self.scheduler.config.get("max_shift", 1.16),
805+
self.scheduler.config.get("max_shift", 1.15),
806806
)
807807
timesteps, num_inference_steps = retrieve_timesteps(
808808
self.scheduler,

‎src/diffusers/pipelines/flux/pipeline_flux_control_img2img.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def calculate_shift(
9393
base_seq_len: int = 256,
9494
max_seq_len: int = 4096,
9595
base_shift: float = 0.5,
96-
max_shift: float = 1.16,
96+
max_shift: float = 1.15,
9797
):
9898
m = (max_shift - base_shift) / (max_seq_len - base_seq_len)
9999
b = base_shift - m * base_seq_len
@@ -810,7 +810,7 @@ def __call__(
810810
self.scheduler.config.get("base_image_seq_len", 256),
811811
self.scheduler.config.get("max_image_seq_len", 4096),
812812
self.scheduler.config.get("base_shift", 0.5),
813-
self.scheduler.config.get("max_shift", 1.16),
813+
self.scheduler.config.get("max_shift", 1.15),
814814
)
815815
timesteps, num_inference_steps = retrieve_timesteps(
816816
self.scheduler,

‎src/diffusers/pipelines/flux/pipeline_flux_control_inpaint.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def calculate_shift(
119119
base_seq_len: int = 256,
120120
max_seq_len: int = 4096,
121121
base_shift: float = 0.5,
122-
max_shift: float = 1.16,
122+
max_shift: float = 1.15,
123123
):
124124
m = (max_shift - base_shift) / (max_seq_len - base_seq_len)
125125
b = base_shift - m * base_seq_len
@@ -987,7 +987,7 @@ def __call__(
987987
self.scheduler.config.get("base_image_seq_len", 256),
988988
self.scheduler.config.get("max_image_seq_len", 4096),
989989
self.scheduler.config.get("base_shift", 0.5),
990-
self.scheduler.config.get("max_shift", 1.16),
990+
self.scheduler.config.get("max_shift", 1.15),
991991
)
992992
timesteps, num_inference_steps = retrieve_timesteps(
993993
self.scheduler,

‎src/diffusers/pipelines/flux/pipeline_flux_controlnet.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def calculate_shift(
8989
base_seq_len: int = 256,
9090
max_seq_len: int = 4096,
9191
base_shift: float = 0.5,
92-
max_shift: float = 1.16,
92+
max_shift: float = 1.15,
9393
):
9494
m = (max_shift - base_shift) / (max_seq_len - base_seq_len)
9595
b = base_shift - m * base_seq_len
@@ -877,7 +877,7 @@ def __call__(
877877
self.scheduler.config.get("base_image_seq_len", 256),
878878
self.scheduler.config.get("max_image_seq_len", 4096),
879879
self.scheduler.config.get("base_shift", 0.5),
880-
self.scheduler.config.get("max_shift", 1.16),
880+
self.scheduler.config.get("max_shift", 1.15),
881881
)
882882
timesteps, num_inference_steps = retrieve_timesteps(
883883
self.scheduler,

‎src/diffusers/pipelines/flux/pipeline_flux_controlnet_image_to_image.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def calculate_shift(
8787
base_seq_len: int = 256,
8888
max_seq_len: int = 4096,
8989
base_shift: float = 0.5,
90-
max_shift: float = 1.16,
90+
max_shift: float = 1.15,
9191
):
9292
m = (max_shift - base_shift) / (max_seq_len - base_seq_len)
9393
b = base_shift - m * base_seq_len
@@ -865,7 +865,7 @@ def __call__(
865865
self.scheduler.config.get("base_image_seq_len", 256),
866866
self.scheduler.config.get("max_image_seq_len", 4096),
867867
self.scheduler.config.get("base_shift", 0.5),
868-
self.scheduler.config.get("max_shift", 1.16),
868+
self.scheduler.config.get("max_shift", 1.15),
869869
)
870870
timesteps, num_inference_steps = retrieve_timesteps(
871871
self.scheduler,

0 commit comments

Comments
 (0)