From 30351f920726ed62092f7731b3a28f9d559d308a Mon Sep 17 00:00:00 2001 From: karen-hedges <133129444+karen-hedges@users.noreply.github.com> Date: Sat, 26 Jul 2025 08:40:54 +0100 Subject: [PATCH 1/6] DMP-5198 GenerateCaseDocumentForRetentionDateAutomatedTask - Rethrow Interrupted Exception Added rethrowing of interrupted exception so the automated task can stop processing when the max lock time is acheieved --- .../impl/GenerateCaseDocumentSingleCaseProcessorImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/uk/gov/hmcts/darts/casedocument/service/impl/GenerateCaseDocumentSingleCaseProcessorImpl.java b/src/main/java/uk/gov/hmcts/darts/casedocument/service/impl/GenerateCaseDocumentSingleCaseProcessorImpl.java index 8e6af10754e..0b25895bc16 100644 --- a/src/main/java/uk/gov/hmcts/darts/casedocument/service/impl/GenerateCaseDocumentSingleCaseProcessorImpl.java +++ b/src/main/java/uk/gov/hmcts/darts/casedocument/service/impl/GenerateCaseDocumentSingleCaseProcessorImpl.java @@ -90,7 +90,7 @@ private void updateCourtCaseRetention(Integer caseId) { courtCaseEntity.setRetentionUpdated(true); courtCaseEntity.setRetentionRetries(0); caseRepository.save(courtCaseEntity); - log.debug("Updated retention for case id {} due to case document generation", caseId); + log.info("Updated retention for case id {} due to case document generation", caseId); } private CaseDocumentEntity createAndSaveCaseDocumentEntity(Integer caseId, String caseDocument, String externalLocation, UserAccountEntity user) { From 1a819444a663292ce2876e04ac2dd1525be02e82 Mon Sep 17 00:00:00 2001 From: karen-hedges <133129444+karen-hedges@users.noreply.github.com> Date: Mon, 8 Sep 2025 18:48:35 +0100 Subject: [PATCH 2/6] DMP-5198 GenerateCaseDocumentForRetentionDateAutomatedTask - Rethrow Interrupted Exception Fixing merge conflict --- ... => AdminGetAutomatedTaskServiceIntTest.java} | 3 ++- ...va => AdminGetAutomatedTasksByIdIntTest.java} | 2 +- ...t.java => AdminGetAutomatedTasksIntTest.java} | 2 +- ....java => AdminPatchAutomatedTaskIntTest.java} | 2 +- ...st.java => AdminRunAutomatedTaskIntTest.java} | 2 +- ... AdminUpdateAutomatedTaskServiceIntTest.java} | 3 ++- ...est.java => AutomatedTaskServiceIntTest.java} | 4 +++- ...java => ExternalDataStoreDeleterIntTest.java} | 3 ++- .../GenerateCaseDocumentProcessorIntTest.java | 16 ++++++++-------- ... => InboundAudioDeleterProcessorIntTest.java} | 4 +++- ...=> OutboundAudioDeleterProcessorIntTest.java} | 3 ++- 11 files changed, 26 insertions(+), 18 deletions(-) rename src/integrationTest/java/uk/gov/hmcts/darts/task/service/{AdminGetAutomatedTaskServiceTest.java => AdminGetAutomatedTaskServiceIntTest.java} (97%) rename src/integrationTest/java/uk/gov/hmcts/darts/task/service/{AdminGetAutomatedTasksByIdTest.java => AdminGetAutomatedTasksByIdIntTest.java} (97%) rename src/integrationTest/java/uk/gov/hmcts/darts/task/service/{AdminGetAutomatedTasksTest.java => AdminGetAutomatedTasksIntTest.java} (96%) rename src/integrationTest/java/uk/gov/hmcts/darts/task/service/{AdminPatchAutomatedTaskTest.java => AdminPatchAutomatedTaskIntTest.java} (98%) rename src/integrationTest/java/uk/gov/hmcts/darts/task/service/{AdminRunAutomatedTaskTest.java => AdminRunAutomatedTaskIntTest.java} (98%) rename src/integrationTest/java/uk/gov/hmcts/darts/task/service/{AdminUpdateAutomatedTaskServiceTest.java => AdminUpdateAutomatedTaskServiceIntTest.java} (97%) rename src/integrationTest/java/uk/gov/hmcts/darts/task/service/{AutomatedTaskServiceTest.java => AutomatedTaskServiceIntTest.java} (99%) rename src/integrationTest/java/uk/gov/hmcts/darts/task/service/{ExternalDataStoreDeleterTest.java => ExternalDataStoreDeleterIntTest.java} (99%) rename src/integrationTest/java/uk/gov/hmcts/darts/task/service/{InboundAudioDeleterProcessorTest.java => InboundAudioDeleterProcessorIntTest.java} (97%) rename src/integrationTest/java/uk/gov/hmcts/darts/task/service/{OutboundAudioDeleterProcessorTest.java => OutboundAudioDeleterProcessorIntTest.java} (99%) diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTaskServiceTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTaskServiceIntTest.java similarity index 97% rename from src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTaskServiceTest.java rename to src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTaskServiceIntTest.java index e973d33de01..dc8d46951cd 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTaskServiceTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTaskServiceIntTest.java @@ -10,7 +10,8 @@ import static org.assertj.core.api.Assertions.assertThat; -class AdminGetAutomatedTaskServiceTest extends IntegrationBase { +@SuppressWarnings("PMD.ExcessiveImports") +class AdminGetAutomatedTaskServiceIntTest extends IntegrationBase { @Autowired private AdminAutomatedTaskService adminAutomatedTaskService; diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTasksByIdTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTasksByIdIntTest.java similarity index 97% rename from src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTasksByIdTest.java rename to src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTasksByIdIntTest.java index 6fc94e29ca4..6b1bb0a8d55 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTasksByIdTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTasksByIdIntTest.java @@ -19,7 +19,7 @@ import static uk.gov.hmcts.darts.common.enums.SecurityRoleEnum.SUPER_ADMIN; @AutoConfigureMockMvc -class AdminGetAutomatedTasksByIdTest extends IntegrationBase { +class AdminGetAutomatedTasksByIdIntTest extends IntegrationBase { private static final URI ENDPOINT = URI.create("/admin/automated-tasks/"); diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTasksTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTasksIntTest.java similarity index 96% rename from src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTasksTest.java rename to src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTasksIntTest.java index 28432b55a60..e2f8d451337 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTasksTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTasksIntTest.java @@ -16,7 +16,7 @@ import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status; @AutoConfigureMockMvc -class AdminGetAutomatedTasksTest extends IntegrationBase { +class AdminGetAutomatedTasksIntTest extends IntegrationBase { private static final URI ENDPOINT = URI.create("/admin/automated-tasks"); diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminPatchAutomatedTaskTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminPatchAutomatedTaskIntTest.java similarity index 98% rename from src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminPatchAutomatedTaskTest.java rename to src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminPatchAutomatedTaskIntTest.java index 31468443dd0..86e5f47b085 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminPatchAutomatedTaskTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminPatchAutomatedTaskIntTest.java @@ -23,7 +23,7 @@ import static uk.gov.hmcts.darts.common.enums.SecurityRoleEnum.SUPER_ADMIN; @AutoConfigureMockMvc -class AdminPatchAutomatedTaskTest extends IntegrationBase { +class AdminPatchAutomatedTaskIntTest extends IntegrationBase { private static final URI ENDPOINT = URI.create("/admin/automated-tasks/"); diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminRunAutomatedTaskTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminRunAutomatedTaskIntTest.java similarity index 98% rename from src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminRunAutomatedTaskTest.java rename to src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminRunAutomatedTaskIntTest.java index 851779245e6..221fede1107 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminRunAutomatedTaskTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminRunAutomatedTaskIntTest.java @@ -23,7 +23,7 @@ import static uk.gov.hmcts.darts.common.enums.SecurityRoleEnum.SUPER_ADMIN; @AutoConfigureMockMvc -class AdminRunAutomatedTaskTest extends IntegrationBase { +class AdminRunAutomatedTaskIntTest extends IntegrationBase { private static final URI ENDPOINT = URI.create("/admin/automated-tasks/1/run"); private static final URI ENDPOINT_WITH_NON_EXISTING_TASK_ID = URI.create("/admin/automated-tasks/-1/run"); diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminUpdateAutomatedTaskServiceTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminUpdateAutomatedTaskServiceIntTest.java similarity index 97% rename from src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminUpdateAutomatedTaskServiceTest.java rename to src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminUpdateAutomatedTaskServiceIntTest.java index aa045fede49..8d9ba98ad9e 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminUpdateAutomatedTaskServiceTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminUpdateAutomatedTaskServiceIntTest.java @@ -17,7 +17,8 @@ import static org.assertj.core.api.Assertions.assertThat; -class AdminUpdateAutomatedTaskServiceTest extends IntegrationBase { +@SuppressWarnings("PMD.ExcessiveImports") +class AdminUpdateAutomatedTaskServiceIntTest extends IntegrationBase { @Autowired private AdminAutomatedTaskService adminAutomatedTaskService; diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AutomatedTaskServiceTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AutomatedTaskServiceIntTest.java similarity index 99% rename from src/integrationTest/java/uk/gov/hmcts/darts/task/service/AutomatedTaskServiceTest.java rename to src/integrationTest/java/uk/gov/hmcts/darts/task/service/AutomatedTaskServiceIntTest.java index d436919a112..367771d0410 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AutomatedTaskServiceTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AutomatedTaskServiceIntTest.java @@ -97,7 +97,8 @@ import static uk.gov.hmcts.darts.test.common.AwaitabilityUtil.waitForMax10SecondsWithOneSecondPoll; @Slf4j -class AutomatedTaskServiceTest extends IntegrationBase { +@SuppressWarnings({"PMD.ExcessiveImports", "PMD.CouplingBetweenObjects"}) +class AutomatedTaskServiceIntTest extends IntegrationBase { @Autowired private AutomatedTaskService automatedTaskService; @@ -288,6 +289,7 @@ void givenNonExistingAutomatedTaskNameUpdateAutomatedTaskCronExpressionThrowsDar } @Test + @SuppressWarnings("PMD.LawOfDemeter") void givenExistingAutomatedTaskNameAndInvalidCronExpressionThrowsDartsApiException() { AutomatedTask automatedTask = new ProcessDailyListAutomatedTask( automatedTaskRepository, mock(ProcessDailyListAutomatedTaskConfig.class), null, logApi, lockService diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/ExternalDataStoreDeleterTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/ExternalDataStoreDeleterIntTest.java similarity index 99% rename from src/integrationTest/java/uk/gov/hmcts/darts/task/service/ExternalDataStoreDeleterTest.java rename to src/integrationTest/java/uk/gov/hmcts/darts/task/service/ExternalDataStoreDeleterIntTest.java index d91058272a3..c747901f244 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/ExternalDataStoreDeleterTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/ExternalDataStoreDeleterIntTest.java @@ -52,7 +52,8 @@ import static uk.gov.hmcts.darts.common.enums.ObjectRecordStatusEnum.STORED; import static uk.gov.hmcts.darts.test.common.data.PersistableFactory.getMediaRequestTestData; -class ExternalDataStoreDeleterTest extends IntegrationBase { +@SuppressWarnings({"PMD.ExcessiveImports"}) +class ExternalDataStoreDeleterIntTest extends IntegrationBase { @Autowired protected TransientObjectDirectoryStub transientObjectDirectoryStub; @Autowired diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/GenerateCaseDocumentProcessorIntTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/GenerateCaseDocumentProcessorIntTest.java index 411ea2780b0..49ccc22ddfd 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/GenerateCaseDocumentProcessorIntTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/GenerateCaseDocumentProcessorIntTest.java @@ -29,22 +29,22 @@ class GenerateCaseDocumentProcessorIntTest extends IntegrationBase { private static final OffsetDateTime DT_2025 = OffsetDateTime.of(2025, 1, 1, 1, 0, 0, 0, UTC); @MockitoSpyBean - CaseRepository caseRepository; + private CaseRepository caseRepository; @MockitoSpyBean - CaseDocumentRepository caseDocumentRepository; + private CaseDocumentRepository caseDocumentRepository; @MockitoSpyBean - ExternalObjectDirectoryRepository eodRepository; + private ExternalObjectDirectoryRepository eodRepository; @Autowired - UserAccountRepository userAccountRepository; + private UserAccountRepository userAccountRepository; @Autowired - AnnotationRepository annotationRepository; + private AnnotationRepository annotationRepository; @Autowired - GenerateCaseDocumentSingleCaseProcessor processor; + private GenerateCaseDocumentSingleCaseProcessor processor; @Autowired - HearingRepository hearingRepository; + private HearingRepository hearingRepository; @Test - void testGenerateCaseDocument() { + void generateCaseDocument_ShouldGenerateCaseDocument() { // given givenBearerTokenExists("darts.global.user@hmcts.net"); diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/InboundAudioDeleterProcessorTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/InboundAudioDeleterProcessorIntTest.java similarity index 97% rename from src/integrationTest/java/uk/gov/hmcts/darts/task/service/InboundAudioDeleterProcessorTest.java rename to src/integrationTest/java/uk/gov/hmcts/darts/task/service/InboundAudioDeleterProcessorIntTest.java index 55efe9d8918..b8bf7d58af2 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/InboundAudioDeleterProcessorTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/InboundAudioDeleterProcessorIntTest.java @@ -23,9 +23,11 @@ import static uk.gov.hmcts.darts.common.enums.ObjectRecordStatusEnum.STORED; import static uk.gov.hmcts.darts.test.common.data.PersistableFactory.getMediaTestData; -class InboundAudioDeleterProcessorTest extends IntegrationBase { +@SuppressWarnings("PMD.ExcessiveImports") +class InboundAudioDeleterProcessorIntTest extends IntegrationBase { private static final String USER_EMAIL_ADDRESS = "system_InboundAudioDeleter@hmcts.net"; + private UserAccountEntity userAccount; public static final LocalDateTime HEARING_DATE = LocalDateTime.of(2023, 6, 10, 10, 0, 0); @Autowired diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/OutboundAudioDeleterProcessorTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/OutboundAudioDeleterProcessorIntTest.java similarity index 99% rename from src/integrationTest/java/uk/gov/hmcts/darts/task/service/OutboundAudioDeleterProcessorTest.java rename to src/integrationTest/java/uk/gov/hmcts/darts/task/service/OutboundAudioDeleterProcessorIntTest.java index 20dd31da420..c861eb85df6 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/OutboundAudioDeleterProcessorTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/OutboundAudioDeleterProcessorIntTest.java @@ -47,7 +47,8 @@ import static uk.gov.hmcts.darts.common.enums.ObjectRecordStatusEnum.STORED; import static uk.gov.hmcts.darts.test.common.data.PersistableFactory.getMediaRequestTestData; -class OutboundAudioDeleterProcessorTest extends IntegrationBase { +@SuppressWarnings("PMD.ExcessiveImports") +class OutboundAudioDeleterProcessorIntTest extends IntegrationBase { private static final String USER_EMAIL_ADDRESS = "system_OutboundAudioDeleter@hmcts.net"; private UserAccountEntity userAccount; From d80595c065be665028a07382986110580a305a24 Mon Sep 17 00:00:00 2001 From: karen-hedges <133129444+karen-hedges@users.noreply.github.com> Date: Sun, 17 Aug 2025 21:47:11 +0100 Subject: [PATCH 3/6] DMP-5198 GenerateCaseDocumentForRetentionDateAutomatedTask - Rethrow Interrupted Exception Wrote some tests --- .../service/GenerateCaseDocumentSingleCaseProcessor.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/uk/gov/hmcts/darts/casedocument/service/GenerateCaseDocumentSingleCaseProcessor.java b/src/main/java/uk/gov/hmcts/darts/casedocument/service/GenerateCaseDocumentSingleCaseProcessor.java index 44e8248f280..182c9d9e61c 100644 --- a/src/main/java/uk/gov/hmcts/darts/casedocument/service/GenerateCaseDocumentSingleCaseProcessor.java +++ b/src/main/java/uk/gov/hmcts/darts/casedocument/service/GenerateCaseDocumentSingleCaseProcessor.java @@ -4,4 +4,5 @@ public interface GenerateCaseDocumentSingleCaseProcessor { void processGenerateCaseDocument(Integer caseId); + } From 318892df068af58106a16d795a5ba153196ca96e Mon Sep 17 00:00:00 2001 From: karen-hedges <133129444+karen-hedges@users.noreply.github.com> Date: Mon, 18 Aug 2025 14:04:40 +0100 Subject: [PATCH 4/6] DMP-5198 GenerateCaseDocumentForRetentionDateAutomatedTask - Rethrow Interrupted Exception Added some logging to find out why tests are failing --- .../gov/hmcts/darts/common/config/security/SecurityConfig.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/java/uk/gov/hmcts/darts/common/config/security/SecurityConfig.java b/src/main/java/uk/gov/hmcts/darts/common/config/security/SecurityConfig.java index 1c0d43ad45c..77f47d97c84 100644 --- a/src/main/java/uk/gov/hmcts/darts/common/config/security/SecurityConfig.java +++ b/src/main/java/uk/gov/hmcts/darts/common/config/security/SecurityConfig.java @@ -206,6 +206,8 @@ private void writeError(HttpServletResponse response, Exception exception) { Jwt getJwtFromRequest(HttpServletRequest request) { try { String authHeader = request.getHeader("Authorization"); + //TODO: Remove this log statement in production code, as it may expose sensitive information + log.info("Authorization header: {}", authHeader); String token = authHeader.replace(TOKEN_BEARER_PREFIX, "").trim(); String issuer = JWTParser.parse(token).getJWTClaimsSet().getIssuer(); From 63ddaa18ec919f718084d971c748b439c0a270d0 Mon Sep 17 00:00:00 2001 From: karen-hedges <133129444+karen-hedges@users.noreply.github.com> Date: Mon, 18 Aug 2025 15:00:58 +0100 Subject: [PATCH 5/6] DMP-5198 GenerateCaseDocumentForRetentionDateAutomatedTask - Rethrow Interrupted Exception REmoved temporary logging --- .../gov/hmcts/darts/common/config/security/SecurityConfig.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/java/uk/gov/hmcts/darts/common/config/security/SecurityConfig.java b/src/main/java/uk/gov/hmcts/darts/common/config/security/SecurityConfig.java index 77f47d97c84..9b12996ba18 100644 --- a/src/main/java/uk/gov/hmcts/darts/common/config/security/SecurityConfig.java +++ b/src/main/java/uk/gov/hmcts/darts/common/config/security/SecurityConfig.java @@ -207,7 +207,6 @@ Jwt getJwtFromRequest(HttpServletRequest request) { try { String authHeader = request.getHeader("Authorization"); //TODO: Remove this log statement in production code, as it may expose sensitive information - log.info("Authorization header: {}", authHeader); String token = authHeader.replace(TOKEN_BEARER_PREFIX, "").trim(); String issuer = JWTParser.parse(token).getJWTClaimsSet().getIssuer(); From c339cf63cddd9377903478c4c3893c91fbbd6ff3 Mon Sep 17 00:00:00 2001 From: karen-hedges <133129444+karen-hedges@users.noreply.github.com> Date: Mon, 8 Sep 2025 18:56:42 +0100 Subject: [PATCH 6/6] DMP-5198 GenerateCaseDocumentForRetentionDateAutomatedTask - Rethrow Interrupted Exception Fixing merge conflict --- .../darts/task/service/AdminGetAutomatedTaskServiceIntTest.java | 1 - .../task/service/AdminUpdateAutomatedTaskServiceIntTest.java | 1 - .../hmcts/darts/task/service/AutomatedTaskServiceIntTest.java | 2 -- .../darts/task/service/ExternalDataStoreDeleterIntTest.java | 1 - .../darts/task/service/InboundAudioDeleterProcessorIntTest.java | 2 -- .../task/service/OutboundAudioDeleterProcessorIntTest.java | 1 - 6 files changed, 8 deletions(-) diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTaskServiceIntTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTaskServiceIntTest.java index dc8d46951cd..8c1b46a31ad 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTaskServiceIntTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminGetAutomatedTaskServiceIntTest.java @@ -10,7 +10,6 @@ import static org.assertj.core.api.Assertions.assertThat; -@SuppressWarnings("PMD.ExcessiveImports") class AdminGetAutomatedTaskServiceIntTest extends IntegrationBase { @Autowired diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminUpdateAutomatedTaskServiceIntTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminUpdateAutomatedTaskServiceIntTest.java index 8d9ba98ad9e..a867c39071b 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminUpdateAutomatedTaskServiceIntTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AdminUpdateAutomatedTaskServiceIntTest.java @@ -17,7 +17,6 @@ import static org.assertj.core.api.Assertions.assertThat; -@SuppressWarnings("PMD.ExcessiveImports") class AdminUpdateAutomatedTaskServiceIntTest extends IntegrationBase { @Autowired diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AutomatedTaskServiceIntTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AutomatedTaskServiceIntTest.java index 367771d0410..b83588e5a74 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AutomatedTaskServiceIntTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/AutomatedTaskServiceIntTest.java @@ -97,7 +97,6 @@ import static uk.gov.hmcts.darts.test.common.AwaitabilityUtil.waitForMax10SecondsWithOneSecondPoll; @Slf4j -@SuppressWarnings({"PMD.ExcessiveImports", "PMD.CouplingBetweenObjects"}) class AutomatedTaskServiceIntTest extends IntegrationBase { @Autowired @@ -289,7 +288,6 @@ void givenNonExistingAutomatedTaskNameUpdateAutomatedTaskCronExpressionThrowsDar } @Test - @SuppressWarnings("PMD.LawOfDemeter") void givenExistingAutomatedTaskNameAndInvalidCronExpressionThrowsDartsApiException() { AutomatedTask automatedTask = new ProcessDailyListAutomatedTask( automatedTaskRepository, mock(ProcessDailyListAutomatedTaskConfig.class), null, logApi, lockService diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/ExternalDataStoreDeleterIntTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/ExternalDataStoreDeleterIntTest.java index c747901f244..ce486733d9c 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/ExternalDataStoreDeleterIntTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/ExternalDataStoreDeleterIntTest.java @@ -52,7 +52,6 @@ import static uk.gov.hmcts.darts.common.enums.ObjectRecordStatusEnum.STORED; import static uk.gov.hmcts.darts.test.common.data.PersistableFactory.getMediaRequestTestData; -@SuppressWarnings({"PMD.ExcessiveImports"}) class ExternalDataStoreDeleterIntTest extends IntegrationBase { @Autowired protected TransientObjectDirectoryStub transientObjectDirectoryStub; diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/InboundAudioDeleterProcessorIntTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/InboundAudioDeleterProcessorIntTest.java index b8bf7d58af2..17e540c28bf 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/InboundAudioDeleterProcessorIntTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/InboundAudioDeleterProcessorIntTest.java @@ -23,11 +23,9 @@ import static uk.gov.hmcts.darts.common.enums.ObjectRecordStatusEnum.STORED; import static uk.gov.hmcts.darts.test.common.data.PersistableFactory.getMediaTestData; -@SuppressWarnings("PMD.ExcessiveImports") class InboundAudioDeleterProcessorIntTest extends IntegrationBase { private static final String USER_EMAIL_ADDRESS = "system_InboundAudioDeleter@hmcts.net"; - private UserAccountEntity userAccount; public static final LocalDateTime HEARING_DATE = LocalDateTime.of(2023, 6, 10, 10, 0, 0); @Autowired diff --git a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/OutboundAudioDeleterProcessorIntTest.java b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/OutboundAudioDeleterProcessorIntTest.java index c861eb85df6..0a2044551ff 100644 --- a/src/integrationTest/java/uk/gov/hmcts/darts/task/service/OutboundAudioDeleterProcessorIntTest.java +++ b/src/integrationTest/java/uk/gov/hmcts/darts/task/service/OutboundAudioDeleterProcessorIntTest.java @@ -47,7 +47,6 @@ import static uk.gov.hmcts.darts.common.enums.ObjectRecordStatusEnum.STORED; import static uk.gov.hmcts.darts.test.common.data.PersistableFactory.getMediaRequestTestData; -@SuppressWarnings("PMD.ExcessiveImports") class OutboundAudioDeleterProcessorIntTest extends IntegrationBase { private static final String USER_EMAIL_ADDRESS = "system_OutboundAudioDeleter@hmcts.net"; private UserAccountEntity userAccount;