DTSPB-4896 change getCase to getCaseByCaseId

Author: MarcusHMCTS

src/main/java/uk/gov/hmcts/probate/core/service/BusinessServiceImpl.java

@@ -8,7 +8,6 @@
 import uk.gov.hmcts.probate.core.service.mapper.ExecutorApplyingToInvitationMapper;
 import uk.gov.hmcts.probate.service.BusinessService;
 import uk.gov.hmcts.reform.probate.model.PhonePin;
-import uk.gov.hmcts.reform.probate.model.ProbateType;
 import uk.gov.hmcts.reform.probate.model.cases.CaseType;
 import uk.gov.hmcts.reform.probate.model.cases.CollectionMember;
 import uk.gov.hmcts.reform.probate.model.cases.ProbateCaseDetails;
@@ -333,8 +332,7 @@ public String getPinNumber(PhonePin phonePin, String sessionId, Boolean isBiling
     private ProbateCaseDetails getProbateCaseDetails(String caseId) {
         String serviceAuthorisation = securityUtils.getServiceAuthorisation();
         String authorisation = securityUtils.getAuthorisation();
-        return submitServiceApi.getCase(authorisation, serviceAuthorisation,
-                caseId, ProbateType.PA.getCaseType().name());
+        return submitServiceApi.getCaseById(authorisation, serviceAuthorisation, caseId);
     }
 
     private void updateCaseData(ProbateCaseDetails probateCaseDetails, String formdataId) {

src/test/java/uk/gov/hmcts/probate/core/service/BusinessServiceImplTest.java

@@ -13,7 +13,6 @@
 import uk.gov.hmcts.probate.client.submit.SubmitServiceApi;
 import uk.gov.hmcts.probate.core.service.mapper.ExecutorApplyingToInvitationMapper;
 import uk.gov.hmcts.reform.probate.model.PhonePin;
-import uk.gov.hmcts.reform.probate.model.ProbateType;
 import uk.gov.hmcts.reform.probate.model.cases.CaseInfo;
 import uk.gov.hmcts.reform.probate.model.cases.CaseType;
 import uk.gov.hmcts.reform.probate.model.cases.CollectionMember;
@@ -88,8 +87,8 @@ public void setUp() throws Exception {
         when(securityUtils.getAuthorisation()).thenReturn(AUTHORIZATION);
         when(securityUtils.getServiceAuthorisation()).thenReturn(SERVICE_AUTHORIZATION);
 
-        when(submitServiceApi.getCase(AUTHORIZATION, SERVICE_AUTHORIZATION,
-            formdataId, ProbateType.PA.getCaseType().name())).thenReturn(mockProbateCaseDetails);
+        when(submitServiceApi.getCaseById(AUTHORIZATION, SERVICE_AUTHORIZATION,
+            formdataId)).thenReturn(mockProbateCaseDetails);
         when(mockProbateCaseDetails.getCaseData()).thenReturn(mockGrantOfRepresentationData);
         when(mockProbateCaseDetails.getCaseInfo()).thenReturn(mockCaseInfo);
         when(mockCaseInfo.getCaseId()).thenReturn("123456789101112");
@@ -594,8 +593,9 @@ public void shouldGetAllInviteData() {
     }
 
     private void verifyGetCaseCalls() {
-        verify(submitServiceApi).getCase(AUTHORIZATION, SERVICE_AUTHORIZATION,
-            formdataId, ProbateType.PA.getCaseType().name());
+
+        verify(submitServiceApi).getCaseById(AUTHORIZATION, SERVICE_AUTHORIZATION,
+                formdataId);
         verify(mockProbateCaseDetails).getCaseData();
     }