Skip to content

Commit 6ddf15d

Browse files
committed
DTSRD-4329. fixing integrationtestcase
1 parent a8a9456 commit 6ddf15d

File tree

2 files changed

+25
-13
lines changed

2 files changed

+25
-13
lines changed

src/integrationTest/java/uk/gov/hmcts/reform/cwrdapi/StaffRefDataIntegrationTest.java

Lines changed: 22 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,7 @@ public static void tearDown() {
4848
void should_retrieveAllServiceSkills_return_status_code_200()
4949
throws JsonProcessingException {
5050
String path = "/skill";
51-
5251
String role = "staff-admin";
53-
54-
5552
final var staffWorkerSkillResponse = (StaffWorkerSkillResponse) caseworkerReferenceDataClient
5653
.retrieveAllServiceSkills(StaffWorkerSkillResponse.class, path, role);
5754

@@ -61,20 +58,32 @@ void should_retrieveAllServiceSkills_return_status_code_200()
6158

6259
assertThat(serviceSkills.size()).isEqualTo(4);
6360

64-
ServiceSkill serviceSkill = serviceSkills.get(0);
65-
66-
assertThat(serviceSkill.getId()).isEqualTo("AAA7");
67-
68-
assertThat(serviceSkill.getSkills().size()).isEqualTo(4);
61+
for (ServiceSkill ss: serviceSkills) {
62+
List<SkillDTO> listOfSkillsForSSId = fetchListOfSkills(ss.getId());
63+
assertThat(ss.getSkills().size()).isEqualTo(listOfSkillsForSSId.size());
64+
for (int i = 0; i < ss.getSkills().size(); i++) {
65+
SkillDTO skillDTO = ss.getSkills().get(i);
66+
assertThat(skillDTO.getSkillId()).isEqualTo(listOfSkillsForSSId.get(i).getSkillId());
67+
assertThat(skillDTO.getSkillCode()).isEqualTo(listOfSkillsForSSId.get(i).getSkillCode());
68+
assertThat(skillDTO.getDescription()).isEqualTo(listOfSkillsForSSId.get(i).getDescription());
69+
assertThat(skillDTO.getUserType()).isEqualTo(listOfSkillsForSSId.get(i).getUserType());
70+
}
71+
}
6972

70-
SkillDTO skillDTO = serviceSkill.getSkills().get(0);
73+
}
7174

72-
assertThat(skillDTO.getSkillId()).isEqualTo(9L);
73-
assertThat(skillDTO.getSkillCode()).isEqualTo("SKILL:AAA7:TEST1");
74-
assertThat(skillDTO.getDescription()).isEqualTo("testskill1");
75-
assertThat(skillDTO.getUserType()).isEqualTo("CTSC");
75+
List<SkillDTO> fetchListOfSkills(String code) throws JsonProcessingException {
76+
String path = "/skill?service_codes=" + code;
77+
String role = "staff-admin";
78+
final var staffWorkerSkillResponse = (StaffWorkerSkillResponse) caseworkerReferenceDataClient
79+
.retrieveAllServiceSkills(StaffWorkerSkillResponse.class, path, role);
80+
assertThat(staffWorkerSkillResponse).isNotNull();
81+
List<ServiceSkill> serviceSkills = staffWorkerSkillResponse.getServiceSkills();
82+
assertThat(serviceSkills.size()).isEqualTo(1);
83+
return serviceSkills.get(0).getSkills();
7684
}
7785

86+
7887
@Test
7988
void should_retrieveAllServiceSkills_return_status_code_200_when_empty_servicecode()
8089
throws JsonProcessingException {

src/integrationTest/java/uk/gov/hmcts/reform/cwrdapi/util/CaseWorkerReferenceDataClient.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,9 @@ private Object mapServiceSkillsIdResponse(ResponseEntity<Object> responseEntity,
159159

160160
}
161161

162+
163+
164+
162165
@SuppressWarnings({"rawtypes", "unchecked"})
163166
private ResponseEntity<Object> getRequest(String uriPath, Class clasz, String role) {
164167

0 commit comments

Comments
 (0)