Add to and retrieve films from the cache

Author: hmerritt

src/Cache.php

@@ -11,19 +11,22 @@
 class Cache
 {
 
-    /**
-     * Initiate cache database
-     *
-     * @var \Filebase\Database
-     */
-    private $cache = new \Filebase\Database([
-        'dir'            => __DIR__ . DIRECTORY_SEPARATOR . 'cache/films/',
-        'backupLocation' => __DIR__ . DIRECTORY_SEPARATOR . 'cache/films/backups/',
-        'format'         => \Filebase\Format\Json::class,
-        'cache'          => true,
-        'cache_expires'  => 31540000,
-        'pretty'         => false
-    ]);
+    function __construct()
+    {
+        /**
+         * Initiate cache database
+         *
+         * @var \Filebase\Database
+         */
+        $this->cache = new \Filebase\Database([
+            'dir'            => __DIR__ . DIRECTORY_SEPARATOR . 'cache/films/',
+            'backupLocation' => __DIR__ . DIRECTORY_SEPARATOR . 'cache/films/backups/',
+            'format'         => \Filebase\Format\Json::class,
+            'cache'          => true,
+            'cache_expires'  => 31540000,
+            'pretty'         => false
+        ]);
+    }
 
     /**
      * Add (or modify) an item in the cache
@@ -47,7 +50,7 @@ public function add(string $key, $value)
      */
     public function count(): int
     {
-        return $this->$cache->count();
+        return $this->cache->count();
     }
 
     /**
@@ -63,25 +66,25 @@ public function delete(string $key): bool
     }
 
     /**
-     * Check if an item exists in the cache
+     * Get an item from the cache
      *
      * @param string $key
-     * @return bool
+     * @return object
      */
-    public function exists(string $key): bool
+    public function get(string $key): object
     {
-        return $this->$cache->has($key);
+        return $this->cache->get($key);
     }
 
     /**
-     * Get an item from the cache
+     * Check if an item exists in the cache
      *
      * @param string $key
-     * @return array
+     * @return bool
      */
-    public function get(string $key): array
+    public function has(string $key): bool
     {
-        return $this->$cache->get($key);
+        return $this->cache->has($key);
     }
 
 }

src/imdb.php

@@ -52,6 +52,10 @@ public function film(string $filmId, array $options = []): array
         // -> handles what the api returns
         $response = new Response;
 
+        //  Initiate cache object
+        // -> handles storing/retrieving cached results
+        $cache = new Cache;
+
         //  Initiate dom object
         //  -> handles page scraping
         $dom = new Dom;
@@ -77,6 +81,11 @@ public function film(string $filmId, array $options = []): array
             }
         }
 
+        //  Check cache for film
+        if ($cache->has($filmId)) {
+            return $cache->get($filmId)->film;
+        }
+
         //  Load imdb film page and parse the dom
         $page = $dom->fetch("https://www.imdb.com/title/".$filmId, $options);
 
@@ -102,6 +111,9 @@ public function film(string $filmId, array $options = []): array
             $response->add("technical_specs",  []);
         }
 
+        //  Add result to the cache
+        $cache->add($filmId, $response->return());
+
         //  Return the response $store
         return $response->return();
     }