Skip to content

Separate rules for 'check-overrides' and 'explicit-overrides' #11

@TjlHope

Description

@TjlHope

Firstly, thank you for the plugin, I've been really missing this functionality in TS!

It would be great if the checking of existing @OverRide markers was split out into a separate rule from checking whether a method should have an @OverRide marker added to it.
Essentially the first is enforcing the thing that should really be done by the compiler. Whilst the second is enforcing consistent code style/good coding practice, the job of the linter.

My use case for having separate rules, rather than just config options, is that:

  1. If something is explicitly marked as @OverRide, which doesn't override a parent, then you want a severity:error, and the build to fail.
  2. If there isn't an @OverRide on a parameter that does override a parent, then you want a lower severity, so that you know about it, without the build failing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    discussionDiscussion about a feature or topic

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions