Skip to content

Commit 107c84f

Browse files
authored
Merge pull request #96 from hmlendea/refactor
Refactored the code
2 parents 824a91e + 448fed5 commit 107c84f

29 files changed

+203
-255
lines changed

TransliterationAPI.UnitTests/Service/Transliterators/ArabicTransliteratorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ namespace TransliterationAPI.UnitTests.Service.Transliterators
77
{
88
public class ArabicTransliteratorTests
99
{
10-
private ITransliterator transliterator;
10+
private ArabicTransliterator transliterator;
1111

1212
[SetUp]
1313
public void SetUp()
1414
{
15-
this.transliterator = new ArabicTransliterator();
15+
this.transliterator = new();
1616
}
1717

1818
[Test]

TransliterationAPI.UnitTests/Service/Transliterators/BerberTransliteratorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ namespace TransliterationAPI.UnitTests.Service.Transliterators
77
{
88
public class BerberTransliteratorTests
99
{
10-
private ITransliterator transliterator;
10+
private BerberTransliterator transliterator;
1111

1212
[SetUp]
1313
public void SetUp()
1414
{
15-
this.transliterator = new BerberTransliterator();
15+
transliterator = new();
1616
}
1717

1818
[Test]

TransliterationAPI.UnitTests/Service/Transliterators/CopticTransliteratorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ namespace TransliterationAPI.UnitTests.Service.Transliterators
77
{
88
public class CopticTransliteratorTests
99
{
10-
private ITransliterator transliterator;
10+
private CopticTransliterator transliterator;
1111

1212
[SetUp]
1313
public void SetUp()
1414
{
15-
this.transliterator = new CopticTransliterator();
15+
transliterator = new();
1616
}
1717

1818
[Test]

TransliterationAPI.UnitTests/Service/Transliterators/CyrillicTransliteratorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ namespace TransliterationAPI.UnitTests.Service.Transliterators
88
{
99
public class CyrillicTransliteratorTests
1010
{
11-
private ITransliterator transliterator;
11+
private CyrillicTransliterator transliterator;
1212

1313
[SetUp]
1414
public void SetUp()
1515
{
16-
this.transliterator = new CyrillicTransliterator();
16+
transliterator = new();
1717
}
1818

1919
[Test]

TransliterationAPI.UnitTests/Service/Transliterators/GreekTransliteratorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ namespace TransliterationAPI.UnitTests.Service.Transliterators
77
{
88
public class GreekTransliteratorTests
99
{
10-
private ITransliterator transliterator;
10+
private GreekTransliterator transliterator;
1111

1212
[SetUp]
1313
public void SetUp()
1414
{
15-
this.transliterator = new GreekTransliterator();
15+
transliterator = new();
1616
}
1717

1818
[Test]

TransliterationAPI.UnitTests/Service/Transliterators/HebrewTransliteratorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ namespace TransliterationAPI.UnitTests.Service.Transliterators
77
{
88
public class HebrewTransliteratorTests
99
{
10-
private ITransliterator transliterator;
10+
private HebrewTransliterator transliterator;
1111

1212
[SetUp]
1313
public void SetUp()
1414
{
15-
this.transliterator = new HebrewTransliterator();
15+
transliterator = new();
1616
}
1717

1818
[Test]

TransliterationAPI.UnitTests/Service/Transliterators/JapaneseTransliteratorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ namespace TransliterationAPI.UnitTests.Service.Transliterators
77
{
88
public class JapaneseTransliteratorTests
99
{
10-
private ITransliterator transliterator;
10+
private JapaneseTransliterator transliterator;
1111

1212
[SetUp]
1313
public void SetUp()
1414
{
15-
this.transliterator = new JapaneseTransliterator();
15+
transliterator = new();
1616
}
1717

1818
[Test]

TransliterationAPI.UnitTests/Service/Transliterators/KoreanTransliteratorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ namespace TransliterationAPI.UnitTests.Service.Transliterators
77
{
88
public class KoreanTransliteratorTests
99
{
10-
private ITransliterator transliterator;
10+
private KoreanTransliterator transliterator;
1111

1212
[SetUp]
1313
public void SetUp()
1414
{
15-
this.transliterator = new KoreanTransliterator();
15+
transliterator = new();
1616
}
1717

1818
[Test]

TransliterationAPI.UnitTests/Service/Transliterators/MarathiTransliteratorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ namespace TransliterationAPI.UnitTests.Service.Transliterators
77
{
88
public class MarathiTransliteratorTests
99
{
10-
private ITransliterator transliterator;
10+
private MarathiTransliterator transliterator;
1111

1212
[SetUp]
1313
public void SetUp()
1414
{
15-
this.transliterator = new MarathiTransliterator();
15+
transliterator = new();
1616
}
1717

1818
[Test]

TransliterationAPI/Controllers/TransliterationController.cs

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,8 @@ namespace TransliterationAPI.Controllers
99
{
1010
[ApiController]
1111
[Route("[controller]")]
12-
public class TransliterationController : ControllerBase
12+
public class TransliterationController(ITransliterationService transliterationService) : ControllerBase
1313
{
14-
ITransliterationService transliterationService;
15-
16-
public TransliterationController(ITransliterationService transliterationService)
17-
{
18-
this.transliterationService = transliterationService;
19-
}
20-
2114
[HttpGet]
2215
public ActionResult Get(
2316
[FromQuery] string text,
@@ -32,7 +25,7 @@ public ActionResult Get(
3225
{
3326
string decodedText = HttpUtility.UrlDecode(text);
3427
string transliteratedText = transliterationService.Transliterate(text, language).Result; // TODO: Broken async
35-
28+
3629
return Ok(transliteratedText);
3730
}
3831
catch (ArgumentException ex)

0 commit comments

Comments
 (0)