Skip to content

Commit 62c21f0

Browse files
authored
Fix syncing issues with shared files (#200)
* FIX-ISSUES Commit missing shard files * FIX-ISSUES Fix missing test data * FIX-ISSUES Fix merge issue
1 parent 2715840 commit 62c21f0

File tree

5 files changed

+14
-4
lines changed

5 files changed

+14
-4
lines changed

app/uk/gov/hmrc/agentregistration/shared/ApplicationState.scala

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package uk.gov.hmrc.agentregistration.shared
1818

1919
import play.api.libs.json.Format
2020
import uk.gov.hmrc.agentregistration.shared.util.JsonFormatsFactory
21+
import uk.gov.hmrc.agentregistration.shared.util.SafeEquals.===
2122

2223
enum ApplicationState:
2324

@@ -26,4 +27,8 @@ enum ApplicationState:
2627
case Submitted
2728

2829
object ApplicationState:
30+
2931
given Format[ApplicationState] = JsonFormatsFactory.makeEnumFormat[ApplicationState]
32+
33+
extension (as: ApplicationState)
34+
def sentForRisking: Boolean = as === ApplicationState.Submitted

app/uk/gov/hmrc/agentregistration/shared/lists/IndividualName.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import uk.gov.hmrc.agentregistration.shared.util.JsonFormatsFactory
2222
final case class IndividualName(
2323
value: String
2424
):
25-
2625
def isValidName: Boolean = value.matches("^[a-zA-Z\\-' ]+$")
2726

2827
object IndividualName:

app/uk/gov/hmrc/agentregistrationfrontend/testsupport/testdata/agentapplication/TdAgentApplicationLimitedCompany.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@ trait TdAgentApplicationLimitedCompany { dependencies: (TdBase & TdSectionAmls &
4545
companyStatusCheckResult = None,
4646
hmrcStandardForAgentsAgreed = StateOfAgreement.NotSet,
4747
numberOfRequiredKeyIndividuals = None,
48-
hasOtherRelevantIndividuals = None
48+
hasOtherRelevantIndividuals = None,
49+
vrns = None,
50+
payeRefs = None
4951
)
5052

5153
val afterGrsDataReceived: AgentApplicationLimitedCompany = afterStarted.copy(

app/uk/gov/hmrc/agentregistrationfrontend/testsupport/testdata/agentapplication/TdAgentApplicationLimitedPartnership.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,9 @@ trait TdAgentApplicationLimitedPartnership {
4646
companyStatusCheckResult = None,
4747
hmrcStandardForAgentsAgreed = StateOfAgreement.NotSet,
4848
numberOfRequiredKeyIndividuals = None,
49-
hasOtherRelevantIndividuals = None
49+
hasOtherRelevantIndividuals = None,
50+
vrns = None,
51+
payeRefs = None
5052
)
5153

5254
val afterGrsDataReceived: AgentApplicationLimitedPartnership = afterStarted.copy(

app/uk/gov/hmrc/agentregistrationfrontend/testsupport/testdata/agentapplication/TdAgentApplicationScottishLimitedPartnership.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,9 @@ trait TdAgentApplicationScottishLimitedPartnership {
4646
companyStatusCheckResult = None,
4747
hmrcStandardForAgentsAgreed = StateOfAgreement.NotSet,
4848
numberOfRequiredKeyIndividuals = None,
49-
hasOtherRelevantIndividuals = None
49+
hasOtherRelevantIndividuals = None,
50+
vrns = None,
51+
payeRefs = None
5052
)
5153

5254
val afterGrsDataReceived: AgentApplicationScottishLimitedPartnership = afterStarted.copy(

0 commit comments

Comments
 (0)