Skip to content

Commit 21e1736

Browse files
stephen-oppong-beduhstephen-oppong-beduh
authored
Merge pull request #208 from hmrc/MTDSA-32576
MTDSA-32576 - Updated pensionSchemeTaxReference examples in OAS
2 parents 5142d5e + 367be1d commit 21e1736

File tree

13 files changed

+72
-47
lines changed

13 files changed

+72
-47
lines changed

‎app/shared/services/EnrolmentsAuthService.scala‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ class EnrolmentsAuthService @Inject() (val connector: AuthConnector, val appConf
5050
def authorised(mtdId: String, endpointAllowsSupportingAgents: Boolean = false)(implicit
5151
hc: HeaderCarrier,
5252
ec: ExecutionContext): Future[AuthOutcome] =
53-
5453
authFunction
5554
.authorised(initialPredicate(mtdId))
5655
.retrieve(affinityGroup and authorisedEnrolments) {

‎resources/public/api/conf/2.0/examples/createAmendPension/def1/create_amend_request.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"pensionSavingsTaxCharges": {
33
"pensionSchemeTaxReference": [
44
"00123456RA",
5-
"00123456RA"
5+
"00123456TB"
66
],
77
"lumpSumBenefitTakenInExcessOfLifetimeAllowance": {
88
"amount": 100,
@@ -30,7 +30,7 @@
3030
"pensionSchemeUnauthorisedPayments": {
3131
"pensionSchemeTaxReference": [
3232
"00123456RA",
33-
"00123456RA"
33+
"00123456TB"
3434
],
3535
"surcharge": {
3636
"amount": 100,
@@ -44,7 +44,7 @@
4444
"pensionContributions": {
4545
"pensionSchemeTaxReference": [
4646
"00123456RA",
47-
"00123456RA"
47+
"00123456TB"
4848
],
4949
"inExcessOfTheAnnualAllowance": 100,
5050
"annualAllowanceTaxPaid": 100,

‎resources/public/api/conf/2.0/examples/createAmendPension/def2/create_amend_request.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"pensionSchemeUnauthorisedPayments": {
1717
"pensionSchemeTaxReference": [
1818
"00123456RA",
19-
"00123456RA"
19+
"00123456TB"
2020
],
2121
"surcharge": {
2222
"amount": 100,
@@ -30,7 +30,7 @@
3030
"pensionContributions": {
3131
"pensionSchemeTaxReference": [
3232
"00123456RA",
33-
"00123456RA"
33+
"00123456TB"
3434
],
3535
"inExcessOfTheAnnualAllowance": 100,
3636
"annualAllowanceTaxPaid": 100,

‎resources/public/api/conf/2.0/examples/retrievePensionCharges/def1/response.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"pensionSavingsTaxCharges": {
44
"pensionSchemeTaxReference": [
55
"00123456RA",
6-
"00123456RA"
6+
"00123456TB"
77
],
88
"lumpSumBenefitTakenInExcessOfLifetimeAllowance": {
99
"amount": 100,
@@ -31,7 +31,7 @@
3131
"pensionSchemeUnauthorisedPayments": {
3232
"pensionSchemeTaxReference": [
3333
"00123456RA",
34-
"00123456RA"
34+
"00123456TB"
3535
],
3636
"surcharge": {
3737
"amount": 100.99,
@@ -45,7 +45,7 @@
4545
"pensionContributions": {
4646
"pensionSchemeTaxReference": [
4747
"00123456RA",
48-
"00123456RA"
48+
"00123456TB"
4949
],
5050
"inExcessOfTheAnnualAllowance": 100,
5151
"annualAllowanceTaxPaid": 100,

‎resources/public/api/conf/2.0/examples/retrievePensionCharges/def2/response.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"pensionSchemeUnauthorisedPayments": {
1818
"pensionSchemeTaxReference": [
1919
"00123456RA",
20-
"00123456RA"
20+
"00123456TB"
2121
],
2222
"surcharge": {
2323
"amount": 100.99,
@@ -31,7 +31,7 @@
3131
"pensionContributions": {
3232
"pensionSchemeTaxReference": [
3333
"00123456RA",
34-
"00123456RA"
34+
"00123456TB"
3535
],
3636
"inExcessOfTheAnnualAllowance": 100,
3737
"annualAllowanceTaxPaid": 100,

‎resources/public/api/conf/2.0/schemas/retrievePensionCharges/def1/response.json‎

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@
1616
"properties": {
1717
"pensionSchemeTaxReference": {
1818
"type": "array",
19+
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
1920
"items": {
20-
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
21+
"pattern": "^\\d{8}[R]{1}[a-zA-Z]{1}$",
2122
"type": "string",
2223
"example": "00123456RA"
2324
}
@@ -95,16 +96,18 @@
9596
},
9697
"qualifyingRecognisedOverseasPensionScheme": {
9798
"type": "array",
99+
"description": "A list of one or more qualifying overseas pension scheme reference numbers for overseas pensions contributions.",
98100
"items": {
99-
"description": "A list of one or more qualifying overseas pension scheme reference numbers for overseas pensions contributions.",
101+
"pattern": "^[Q]{1}[0-9]{6}$",
100102
"type": "string",
101103
"example": "Q123456"
102104
}
103105
},
104106
"pensionSchemeTaxReference": {
105107
"type": "array",
108+
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
106109
"items": {
107-
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
110+
"pattern": "^\\d{8}[R]{1}[a-zA-Z]{1}$",
108111
"type": "string",
109112
"example": "00123456RA"
110113
}
@@ -140,8 +143,9 @@
140143
"properties": {
141144
"pensionSchemeTaxReference": {
142145
"type": "array",
146+
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
143147
"items": {
144-
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
148+
"pattern": "^\\d{8}[R]{1}[a-zA-Z]{1}$",
145149
"type": "string",
146150
"example": "00123456RA"
147151
}
@@ -194,8 +198,9 @@
194198
"properties": {
195199
"pensionSchemeTaxReference": {
196200
"type": "array",
201+
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
197202
"items": {
198-
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
203+
"pattern": "^\\d{8}[R]{1}[a-zA-Z]{1}$",
199204
"type": "string",
200205
"example": "00123456RA"
201206
}
@@ -260,16 +265,18 @@
260265
},
261266
"qualifyingRecognisedOverseasPensionScheme": {
262267
"type": "array",
268+
"description": "A list of one or more qualifying overseas pension scheme reference numbers for overseas pensions contributions.",
263269
"items": {
264-
"description": "A list of one or more qualifying overseas pension scheme reference numbers for overseas pensions contributions.",
270+
"pattern": "^[Q]{1}[0-9]{6}$",
265271
"type": "string",
266272
"example": "Q123456"
267273
}
268274
},
269275
"pensionSchemeTaxReference": {
270276
"type": "array",
277+
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
271278
"items": {
272-
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
279+
"pattern": "^\\d{8}[R]{1}[a-zA-Z]{1}$",
273280
"type": "string",
274281
"example": "00123456RA"
275282
}

‎resources/public/api/conf/2.0/schemas/retrievePensionCharges/def2/response.json‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,18 @@
3838
},
3939
"qualifyingRecognisedOverseasPensionScheme": {
4040
"type": "array",
41+
"description": "A list of one or more qualifying overseas pension scheme reference numbers for overseas pensions contributions.",
4142
"items": {
42-
"description": "A list of one or more qualifying overseas pension scheme reference numbers for overseas pensions contributions.",
43+
"pattern": "^[Q]{1}[0-9]{6}$",
4344
"type": "string",
4445
"example": "Q123456"
4546
}
4647
},
4748
"pensionSchemeTaxReference": {
4849
"type": "array",
50+
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
4951
"items": {
50-
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
52+
"pattern": "^\\d{8}[R]{1}[a-zA-Z]{1}$",
5153
"type": "string",
5254
"example": "00123456RA"
5355
}
@@ -83,8 +85,9 @@
8385
"properties": {
8486
"pensionSchemeTaxReference": {
8587
"type": "array",
88+
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
8689
"items": {
87-
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
90+
"pattern": "^\\d{8}[R]{1}[a-zA-Z]{1}$",
8891
"type": "string",
8992
"example": "00123456RA"
9093
}
@@ -137,8 +140,9 @@
137140
"properties": {
138141
"pensionSchemeTaxReference": {
139142
"type": "array",
143+
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
140144
"items": {
141-
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
145+
"pattern": "^\\d{8}[R]{1}[a-zA-Z]{1}$",
142146
"type": "string",
143147
"example": "00123456RA"
144148
}
@@ -203,16 +207,18 @@
203207
},
204208
"qualifyingRecognisedOverseasPensionScheme": {
205209
"type": "array",
210+
"pattern": "^[Q]{1}[0-9]{6}$",
211+
"description": "A list of one or more qualifying overseas pension scheme reference numbers for overseas pensions contributions.",
206212
"items": {
207-
"description": "A list of one or more qualifying overseas pension scheme reference numbers for overseas pensions contributions.",
208213
"type": "string",
209214
"example": "Q123456"
210215
}
211216
},
212217
"pensionSchemeTaxReference": {
213218
"type": "array",
219+
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
214220
"items": {
215-
"description": "A list of one or more unique references provided by HM Revenue and Customs (HMRC) when the scheme has been registered for tax relief and exemptions. It is 10 characters made up of 8 numbers followed by 2 letters.",
221+
"pattern": "^\\d{8}[R]{1}[a-zA-Z]{1}$",
216222
"type": "string",
217223
"example": "00123456RA"
218224
}

‎resources/public/api/conf/3.0/examples/pensionCharges/createAmend/def1/create_amend_request.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"pensionSavingsTaxCharges": {
33
"pensionSchemeTaxReference": [
44
"00123456RA",
5-
"00123456RA"
5+
"00123456TB"
66
],
77
"lumpSumBenefitTakenInExcessOfLifetimeAllowance": {
88
"amount": 100,
@@ -30,7 +30,7 @@
3030
"pensionSchemeUnauthorisedPayments": {
3131
"pensionSchemeTaxReference": [
3232
"00123456RA",
33-
"00123456RA"
33+
"00123456TB"
3434
],
3535
"surcharge": {
3636
"amount": 100,
@@ -44,7 +44,7 @@
4444
"pensionContributions": {
4545
"pensionSchemeTaxReference": [
4646
"00123456RA",
47-
"00123456RA"
47+
"00123456TB"
4848
],
4949
"inExcessOfTheAnnualAllowance": 100,
5050
"annualAllowanceTaxPaid": 100,

‎resources/public/api/conf/3.0/examples/pensionCharges/createAmend/def2/create_amend_request.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"pensionSchemeUnauthorisedPayments": {
1717
"pensionSchemeTaxReference": [
1818
"00123456RA",
19-
"00123456RA"
19+
"00123456TB"
2020
],
2121
"surcharge": {
2222
"amount": 100,
@@ -30,7 +30,7 @@
3030
"pensionContributions": {
3131
"pensionSchemeTaxReference": [
3232
"00123456RA",
33-
"00123456RA"
33+
"00123456TB"
3434
],
3535
"inExcessOfTheAnnualAllowance": 100,
3636
"annualAllowanceTaxPaid": 100,

‎resources/public/api/conf/3.0/examples/pensionCharges/retrieve/def1/response.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"pensionSavingsTaxCharges": {
44
"pensionSchemeTaxReference": [
55
"00123456RA",
6-
"00123456RA"
6+
"00123456TB"
77
],
88
"lumpSumBenefitTakenInExcessOfLifetimeAllowance": {
99
"amount": 100,
@@ -31,7 +31,7 @@
3131
"pensionSchemeUnauthorisedPayments": {
3232
"pensionSchemeTaxReference": [
3333
"00123456RA",
34-
"00123456RA"
34+
"00123456TB"
3535
],
3636
"surcharge": {
3737
"amount": 100.99,
@@ -45,7 +45,7 @@
4545
"pensionContributions": {
4646
"pensionSchemeTaxReference": [
4747
"00123456RA",
48-
"00123456RA"
48+
"00123456TB"
4949
],
5050
"inExcessOfTheAnnualAllowance": 100,
5151
"annualAllowanceTaxPaid": 100,

0 commit comments

Comments
 (0)