Skip to content

Commit 9e5dbc9

Browse files
PIL-2854 Add amendMultipleAccountingPeriods feature flag (#644)
## Summary Adds feature flag `amendMultipleAccountingPeriods` for the Change Accounting period feature (V2 endpoints for Display Subscription and Amend Subscription). ## Changes - **conf/application.conf**: Add `amendMultipleAccountingPeriods = false` under `features` - **app/config/FrontendAppConfig.scala**: Expose `amendMultipleAccountingPeriods` for injection in controllers/connector - **test/config/FrontendAppConfigSpec.scala**: Test that flag defaults to false ## Acceptance criteria - [x] Flag exists in config, defaults to false - [x] Flag can be toggled per environment (same mechanism as other feature flags) - [x] Flag is injectable into controllers that handle accounting period display and amendment flows (via existing FrontendAppConfig injection) ## Out of scope (follow-up) - V2 endpoint switching logic; this ticket is feature-flag setup only. Co-authored-by: Mannkaur2 <211959528+Mannkaur2@users.noreply.github.com>
1 parent bae88d2 commit 9e5dbc9

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

app/config/FrontendAppConfig.scala

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,10 +102,11 @@ class FrontendAppConfig @Inject() (configuration: Configuration, servicesConfig:
102102
val researchUrl: String = configuration.get[String]("urls.researchUrl")
103103
val howToPayPillar2TaxesUrl: String = configuration.get[String]("urls.howToPayPillar2Taxes")
104104

105-
val opsBaseUrl: String = servicesConfig.baseUrl("ops")
106-
val opsStartUrl: String = configuration.get[String]("microservice.services.ops.startUrl")
107-
val enablePayByBankAccount: Boolean = configuration.get[Boolean]("features.enablePayByBankAccount")
108-
val useAccountActivityApi: Boolean = configuration.get[Boolean]("features.useAccountActivityApi")
105+
val opsBaseUrl: String = servicesConfig.baseUrl("ops")
106+
val opsStartUrl: String = configuration.get[String]("microservice.services.ops.startUrl")
107+
val enablePayByBankAccount: Boolean = configuration.get[Boolean]("features.enablePayByBankAccount")
108+
val useAccountActivityApi: Boolean = configuration.get[Boolean]("features.useAccountActivityApi")
109+
val amendMultipleAccountingPeriods: Boolean = configuration.get[Boolean]("features.amendMultipleAccountingPeriods")
109110

110111
def transactionHistoryEndDate: LocalDate = {
111112
val date = configuration.get[String]("features.transactionHistoryEndDate")

conf/application.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ features {
173173
btaAccessEnabled = true
174174
enablePayByBankAccount = true
175175
useAccountActivityApi = false
176+
amendMultipleAccountingPeriods = false
176177

177178
incorporatedEntityBvEnabled = false
178179
partnershipBvEnabled = false

test/config/FrontendAppConfigSpec.scala

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,12 @@ class FrontendAppConfigSpec extends SpecBase with TableDrivenPropertyChecks {
124124
}
125125
}
126126

127+
".amendMultipleAccountingPeriods" must {
128+
"return false by default" in {
129+
config.amendMultipleAccountingPeriods mustBe false
130+
}
131+
}
132+
127133
".maxDaysAgoToConsiderPaymentAsRecent" must {
128134
"read value from config" in {
129135
config.maxDaysAgoToConsiderPaymentAsRecent mustBe 60

0 commit comments

Comments
 (0)