PIL-2249: Small clean up following the submission frontend merge (#642)

The digital team will merge submissions frontend and Phase 1
repositories. This will help to support a smooth handover to live
services.

Conduct the audit
Remove as much duplication as possible

Author: kevincoatsworth

app/controllers/package.scala

@@ -22,8 +22,8 @@ import java.time.LocalDate
 package object controllers {
   private val now = LocalDate.now
 
-  /** @param accountingDetails
-    *   is a sequence of AccountingPeriodDetails
+  /** @param request
+    *   is of type ObligationsAndSubmissionsSuccessDataRequest[?] and contains a sequence of AccountingPeriodDetails
     * @return
     *   a filtered sequence of AccountingPeriodDetails, sorted in reverse chronological order, ensuring that we remove any periods where the start
     *   date is after today

app/models/btn/ApiSuccess.scala

@@ -120,7 +120,6 @@ class BTNBeforeStartControllerSpec extends SpecBase {
 
     "redirect to BTN error page when no obligation data is found" in {
       val testApplication: Application = applicationBuilder(subscriptionLocalData = Some(ua), userAnswers = Some(emptyUserAnswers))
-        .configure("features.phase2ScreensEnabled" -> true)
         .overrides(
           bind[SubscriptionConnector].toInstance(mockSubscriptionConnector),
           bind[ObligationsAndSubmissionsService].toInstance(mockObligationsAndSubmissionsService)