Merge pull request #56 from hoc081098/update-deps

update deps

Author: hoc081098

.github/workflows/build.yml

@@ -21,9 +21,6 @@ jobs:
     - name: Make gradlew executable
       run: chmod +x ./gradlew
 
-    - name: Spotless check
-      run: ./gradlew spotlessCheck
-    
     - name: Build debug APK
       run: ./gradlew assembleDebug --warning-mode all --stacktrace
 

.github/workflows/remove-old-artifacts.yml

@@ -0,0 +1,22 @@
+name: Remove old artifacts
+
+on:
+#  push:
+#    branches: [ master ]
+
+  schedule:
+    # Runs at 01:00 UTC on the 1, 8, 15, 22 and 29th of every month.
+    - cron: '0 1 */7 * *'
+
+jobs:
+  remove-old-artifacts:
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+
+    steps:
+      - name: Remove old artifacts
+        uses: c-hive/gha-remove-artifacts@v1
+        with:
+          age: '1 month'
+          skip-tags: true
+          skip-recent: 5

.github/workflows/spotless.yml

@@ -0,0 +1,25 @@
+name: Spotless check
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Set up JDK
+        uses: actions/setup-java@v2
+        with:
+          distribution: 'zulu'
+          java-version: '11'
+
+      - name: Make gradlew executable
+        run: chmod +x ./gradlew
+
+      - name: Spotless check
+        run: ./gradlew spotlessCheck

.idea/jarRepositories.xml

@@ -29,7 +29,7 @@ This project brings to the table set of best practices, tools, and solutions:
 [Download latest debug APK here](https://nightly.link/hoc081098/ComicReaderApp_MVI_Coroutine_RxKotlin_Jetpack/workflows/build/master/app-debug.zip)
 
 # Develop
-- You must use **Android Studio Bumblebee (2021.1.1) Canary 1** (**note: Java 11 is now the minimum version required**)
+- You must use **Android Studio Arctic Fox (2020.3.1)** (**note: Java 11 is now the minimum version required**)
 - Clone: `git clone https://github.com/hoc081098/ComicReaderApp_MVI_Coroutine_RxKotlin.git`
 - _Optional: **Delete `.idea` folder** if cannot open project_
 - Open project by `Android Studio` and run as usual
@@ -69,21 +69,3 @@ Clone this repository: https://github.com/hoc081098/comic_app_server_nodejs
     MIT License
 
     Copyright (c) 2019-2021 Petrus Nguyễn Thái Học
-
-    Permission is hereby granted, free of charge, to any person obtaining a copy
-    of this software and associated documentation files (the "Software"), to deal
-    in the Software without restriction, including without limitation the rights
-    to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-    copies of the Software, and to permit persons to whom the Software is
-    furnished to do so, subject to the following conditions:
-
-    The above copyright notice and this permission notice shall be included in all
-    copies or substantial portions of the Software.
-
-    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-    SOFTWARE.

README.md

@@ -20,6 +20,7 @@
 
         <activity
             android:name=".activity.SplashActivity"
+            android:exported="true"
             android:theme="@style/SplashTheme">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />
@@ -60,14 +61,13 @@
                 android:name="com.hoc.comicapp.initializer.AnalyticsInitializer"
                 android:value="androidx.startup" />
 
+            <!-- If you are using androidx.startup to initialize other components -->
+            <meta-data
+                android:name="androidx.work.WorkManagerInitializer"
+                android:value="androidx.startup"
+                tools:node="remove" />
         </provider>
 
-        <provider
-            android:name="androidx.work.impl.WorkManagerInitializer"
-            android:authorities="${applicationId}.workmanager-init"
-            android:exported="false"
-            tools:node="remove" />
-
         <receiver
             android:name=".worker.ComicAppBroadcastReceiver"
             android:exported="false" />

app/release/app-release.apk

@@ -174,7 +174,7 @@ class MainActivity : ScopeActivity(R.layout.activity_main) {
                     .height(size)
                     .endConfig()
                     .buildRect(
-                      firstLetter.toUpperCase().toString(),
+                      firstLetter.uppercase(),
                       ColorGenerator.MATERIAL.getColor(user.email)
                     )
                 }