fix lints

Author: hoc081098

app/src/main/java/com/hoc/comicapp/activity/main/MainActivity.kt

@@ -174,7 +174,7 @@ class MainActivity : ScopeActivity(R.layout.activity_main) {
                     .height(size)
                     .endConfig()
                     .buildRect(
-                      firstLetter.toUpperCase().toString(),
+                      firstLetter.uppercase(),
                       ColorGenerator.MATERIAL.getColor(user.email)
                     )
                 }

app/src/main/java/com/hoc/comicapp/activity/main/MainVM.kt

@@ -13,6 +13,7 @@ import com.jakewharton.rxrelay3.PublishRelay
 import io.reactivex.rxjava3.core.Observable
 import io.reactivex.rxjava3.core.Observable.mergeArray
 import io.reactivex.rxjava3.core.ObservableTransformer
+import io.reactivex.rxjava3.disposables.Disposable
 import io.reactivex.rxjava3.kotlin.addTo
 import io.reactivex.rxjava3.kotlin.ofType
 import io.reactivex.rxjava3.kotlin.subscribeBy
@@ -23,7 +24,7 @@ class MainVM(
 ) : BaseViewModel<ViewIntent, ViewState, SingleEvent>(ViewState.initial()) {
   private val intentS = PublishRelay.create<ViewIntent>()
 
-  override fun processIntents(intents: Observable<ViewIntent>) = intents.subscribe(intentS)!!
+  override fun processIntents(intents: Observable<ViewIntent>): Disposable = intents.subscribe(intentS)
 
   private val initialProcessor =
     ObservableTransformer<ViewIntent.Initial, PartialChange> { intent ->

app/src/main/java/com/hoc/comicapp/data/analytics/AnalyticsServiceImpl.kt

@@ -27,7 +27,7 @@ class AnalyticsServiceImpl : AnalyticsService {
 
 class SnakeCaseFirebaseAnalyticsEventMapper {
   fun nameFor(event: String): String =
-    CAMEL_REGEX.replace(event) { "_" + it.value }.toLowerCase()
+    CAMEL_REGEX.replace(event) { "_" + it.value }.lowercase()
 
   fun paramsFor(params: Map<String, Any>?): Bundle? {
     return bundleOf(

app/src/main/java/com/hoc/comicapp/data/firebase/favorite_comics/FavoriteComicsDataSourceImpl.kt

@@ -14,6 +14,7 @@ import com.hoc.comicapp.domain.models.AuthError
 import com.hoc.comicapp.domain.thread.CoroutinesDispatchersProvider
 import com.hoc.comicapp.domain.thread.RxSchedulerProvider
 import com.hoc.comicapp.utils.snapshots
+import com.hoc.comicapp.utils.unit
 import io.reactivex.rxjava3.core.Observable
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.ObsoleteCoroutinesApi
@@ -138,9 +139,7 @@ class FavoriteComicsDataSourceImpl(
     }
   }
 
-  override fun update(comics: List<_FavoriteComic>) {
-    actor.offer(comics)
-  }
+  override fun update(comics: List<_FavoriteComic>) = actor.trySend(comics).unit
 
   private val favoriteCollectionForCurrentUserOrNull: CollectionReference?
     get() = firebaseAuth.currentUser?.uid?.let {

app/src/main/java/com/hoc/comicapp/data/repository/ComicRepositoryImpl.kt

@@ -259,7 +259,7 @@ class ComicRepositoryImpl(
     favoriteComicsDataSource.update(listOf(entity))
 
     // update downloaded
-    actor.offer(Mappers.responseToLocalEntity(comicDetail))
+    actor.trySend(Mappers.responseToLocalEntity(comicDetail))
   }
 
   private companion object {

app/src/main/java/com/hoc/comicapp/data/repository/DownloadComicsRepositoryImpl.kt

@@ -54,6 +54,7 @@ import kotlinx.coroutines.withContext
 import timber.log.Timber
 import java.io.File
 import java.util.Date
+import kotlin.time.DurationUnit
 import kotlin.time.ExperimentalTime
 import kotlin.time.TimeSource
 
@@ -279,7 +280,7 @@ class DownloadComicsRepositoryImpl(
           chapterName = chapterDetail.chapterName,
           comicLink = chapterDetail.comicLink,
           comicName = chapterDetail.comicName,
-          elapsedInMilliseconds = elapsed.inMilliseconds,
+          elapsedInMilliseconds = elapsed.toDouble(DurationUnit.MILLISECONDS),
           elapsedInString = elapsed.toString()
         )
       )

app/src/main/java/com/hoc/comicapp/ui/category/CategoryViewModel.kt

@@ -9,6 +9,7 @@ import com.hoc.comicapp.utils.notOfType
 import com.jakewharton.rxrelay3.PublishRelay
 import io.reactivex.rxjava3.core.Observable
 import io.reactivex.rxjava3.core.ObservableTransformer
+import io.reactivex.rxjava3.disposables.Disposable
 import io.reactivex.rxjava3.kotlin.addTo
 import io.reactivex.rxjava3.kotlin.cast
 import io.reactivex.rxjava3.kotlin.ofType
@@ -87,6 +88,7 @@ class CategoryViewModel(
             when (it) {
               is CategoryPartialChange.RefreshPartialChange.Error -> sendMessageEvent(message = "Refresh error occurred: ${it.error.getMessage()}")
               is CategoryPartialChange.RefreshPartialChange.Data -> sendMessageEvent(message = "Refresh success")
+              CategoryPartialChange.RefreshPartialChange.Loading -> return@doOnNext
             }
           }
           .cast<CategoryPartialChange>()
@@ -109,8 +111,8 @@ class CategoryViewModel(
       }
     }
 
-  override fun processIntents(intents: Observable<CategoryViewIntent>) =
-    intents.subscribe(intentS)!!
+  override fun processIntents(intents: Observable<CategoryViewIntent>): Disposable =
+    intents.subscribe(intentS)
 
   init {
     intentS

app/src/main/java/com/hoc/comicapp/ui/category_detail/CategoryDetailAdapter.kt

@@ -7,10 +7,8 @@ import android.view.View
 import android.view.ViewGroup
 import androidx.annotation.LayoutRes
 import androidx.core.view.isVisible
-import androidx.lifecycle.Lifecycle
-import androidx.lifecycle.LifecycleObserver
+import androidx.lifecycle.DefaultLifecycleObserver
 import androidx.lifecycle.LifecycleOwner
-import androidx.lifecycle.OnLifecycleEvent
 import androidx.recyclerview.widget.DiffUtil
 import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.LinearSmoothScroller
@@ -33,6 +31,7 @@ import com.hoc.comicapp.ui.category_detail.CategoryDetailContract.ViewState.Head
 import com.hoc.comicapp.ui.category_detail.CategoryDetailContract.ViewState.Item
 import com.hoc.comicapp.utils.asObservable
 import com.hoc.comicapp.utils.inflater
+import com.hoc.comicapp.utils.unit
 import com.jakewharton.rxbinding4.recyclerview.scrollStateChanges
 import com.jakewharton.rxbinding4.view.clicks
 import com.jakewharton.rxbinding4.view.detaches
@@ -186,11 +185,10 @@ class CategoryDetailAdapter(
       lifecycleOwner
         .lifecycle
         .addObserver(
-          object : LifecycleObserver {
+          object : DefaultLifecycleObserver {
             var disposable: Disposable? = null
 
-            @OnLifecycleEvent(Lifecycle.Event.ON_CREATE)
-            private fun onCreate() {
+            override fun onCreate(owner: LifecycleOwner) {
               disposable = startStopAutoScrollS
                 .mergeWith(
                   binding.popularRecyclerHorizontal
@@ -229,14 +227,11 @@ class CategoryDetailAdapter(
                 )
             }
 
-            @OnLifecycleEvent(Lifecycle.Event.ON_RESUME)
-            private fun onResume() = startStopAutoScrollS.accept(true)
+            override fun onResume(owner: LifecycleOwner) = startStopAutoScrollS.accept(true)
 
-            @OnLifecycleEvent(Lifecycle.Event.ON_PAUSE)
-            private fun onPause() = startStopAutoScrollS.accept(false)
+            override fun onPause(owner: LifecycleOwner) = startStopAutoScrollS.accept(false)
 
-            @OnLifecycleEvent(Lifecycle.Event.ON_DESTROY)
-            private fun onDestroy() = disposable?.dispose()
+            override fun onDestroy(owner: LifecycleOwner) = disposable?.dispose().unit
           }
         )
     }

utils/src/main/java/com/hoc/comicapp/utils/Snackbar.kt

@@ -5,7 +5,8 @@ import androidx.annotation.StringRes
 import com.google.android.material.snackbar.BaseTransientBottomBar
 import com.google.android.material.snackbar.Snackbar
 
-inline class SnackbarLength private constructor(val length: Int) {
+@JvmInline
+value class SnackbarLength private constructor(val length: Int) {
   companion object Factory {
     val SHORT = SnackbarLength(Snackbar.LENGTH_SHORT)
     val LONG = SnackbarLength(Snackbar.LENGTH_LONG)