Skip to content

Commit 0d9c30c

Browse files
hoc081098hoc081098
committed
apply implicit-dynamic: false
1 parent 56131a2 commit 0d9c30c

File tree

5 files changed

+38
-36
lines changed

5 files changed

+38
-36
lines changed

‎analysis_options.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ include: package:pedantic/analysis_options.1.9.0.yaml
33
analyzer:
44
strong-mode:
55
implicit-casts: false
6+
implicit-dynamic: false
67
linter:
78
rules:
89
- prefer_final_locals

‎example/todo.dart‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ Stream<Action> removeTodoEffect(
8888
GetState<ViewState> state,
8989
) {
9090
final executeRemove = (Todo todo) async* {
91-
await Future.delayed(const Duration(milliseconds: 200));
91+
await Future<void>.delayed(const Duration(milliseconds: 200));
9292
yield Action(todo, ActionType.removed);
9393
};
9494
return action$
@@ -99,7 +99,7 @@ Stream<Action> removeTodoEffect(
9999

100100
final SideEffect<Action, ViewState> toggleTodoEffect = (action$, state) {
101101
final executeToggle = (Todo todo) async* {
102-
await Future.delayed(const Duration(milliseconds: 500));
102+
await Future<void>.delayed(const Duration(milliseconds: 500));
103103
yield Action(todo, ActionType.toggled);
104104
};
105105
return action$
@@ -108,7 +108,7 @@ final SideEffect<Action, ViewState> toggleTodoEffect = (action$, state) {
108108
.flatMap(executeToggle);
109109
};
110110

111-
final delay = () => Future.delayed(const Duration(seconds: 1));
111+
final delay = () => Future<void>.delayed(const Duration(seconds: 1));
112112

113113
void main() async {
114114
final store = RxReduxStore(

‎lib/src/redux_store_stream_transformer.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ class ReduxStoreStreamTransformer<A, S> extends StreamTransformerBase<A, S> {
182182
final futures = [...?cancelFutures, if (future != null) future];
183183

184184
if (futures.isNotEmpty) {
185-
await Future.wait(futures);
185+
await Future.wait<void>(futures);
186186
}
187187
_logger?.call('Cancelled');
188188
}

‎test/store_test.dart‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ void main() {
6666
final future = expectLater(
6767
store.stateStream,
6868
emitsInOrder(
69-
[
69+
<String>[
7070
'0',
7171
'0+1',
7272
'0+1+2',
@@ -122,7 +122,7 @@ void main() {
122122
expect(
123123
store.stateStream,
124124
emitsInOrder(
125-
[
125+
<int>[
126126
0,
127127
1,
128128
3,
@@ -135,17 +135,17 @@ void main() {
135135
);
136136
expect(store.state, 0);
137137

138-
await Future.delayed(const Duration(milliseconds: 100));
138+
await Future<void>.delayed(const Duration(milliseconds: 100));
139139
store.dispatch(Action.action1);
140140
store.dispatch(Action.action2);
141141
store.dispatch(Action.action3);
142-
await Future.delayed(const Duration(seconds: 1));
142+
await Future<void>.delayed(const Duration(seconds: 1));
143143

144144
expect(store.state, 6);
145145
expect(
146146
store.stateStream,
147147
emitsInOrder(
148-
[
148+
<int>[
149149
6,
150150
7,
151151
9,
@@ -154,16 +154,16 @@ void main() {
154154
),
155155
);
156156

157-
await Future.delayed(const Duration(milliseconds: 100));
157+
await Future<void>.delayed(const Duration(milliseconds: 100));
158158
store.dispatch(Action.action1);
159159
store.dispatch(Action.action2);
160160
store.dispatch(Action.action3);
161-
await Future.delayed(const Duration(seconds: 1));
161+
await Future<void>.delayed(const Duration(seconds: 1));
162162

163163
store.dispatch(Action.actionNoOp);
164164
store.dispatch(Action.actionNoOp);
165165
store.dispatch(Action.actionNoOp);
166-
await Future.delayed(const Duration(milliseconds: 100));
166+
await Future<void>.delayed(const Duration(milliseconds: 100));
167167
});
168168

169169
test('Get action stream', () async {
@@ -175,7 +175,7 @@ void main() {
175175

176176
expect(
177177
store.actionStream,
178-
emitsInOrder([1, 2, 3]),
178+
emitsInOrder(<int>[1, 2, 3]),
179179
);
180180

181181
await delay(100);
@@ -222,7 +222,7 @@ void main() {
222222
expect(
223223
store.actionStream,
224224
emitsInOrder(
225-
[
225+
<Action>[
226226
Action.action1,
227227
Action.action2,
228228
Action.action3,
@@ -242,16 +242,16 @@ void main() {
242242
),
243243
);
244244

245-
await Future.delayed(const Duration(milliseconds: 100));
245+
await Future<void>.delayed(const Duration(milliseconds: 100));
246246
store.dispatch(Action.action1);
247247
store.dispatch(Action.action2);
248248
store.dispatch(Action.action3);
249-
await Future.delayed(const Duration(seconds: 1));
249+
await Future<void>.delayed(const Duration(seconds: 1));
250250

251251
expect(
252252
store.actionStream,
253253
emitsInOrder(
254-
[
254+
<Action>[
255255
Action.action1,
256256
Action.action2,
257257
Action.action3,
@@ -265,16 +265,16 @@ void main() {
265265
),
266266
);
267267

268-
await Future.delayed(const Duration(milliseconds: 100));
268+
await Future<void>.delayed(const Duration(milliseconds: 100));
269269
store.dispatch(Action.action1);
270270
store.dispatch(Action.action2);
271271
store.dispatch(Action.action3);
272-
await Future.delayed(const Duration(seconds: 1));
272+
await Future<void>.delayed(const Duration(seconds: 1));
273273

274274
store.dispatch(Action.actionNoOp);
275275
store.dispatch(Action.actionNoOp);
276276
store.dispatch(Action.actionNoOp);
277-
await Future.delayed(const Duration(milliseconds: 100));
277+
await Future<void>.delayed(const Duration(milliseconds: 100));
278278
});
279279

280280
test('Dispose', () async {

‎test/stream_transformer_test.dart‎

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ void main() {
2525

2626
await expectLater(
2727
inputActions.transform(
28-
ReduxStoreStreamTransformer(
28+
ReduxStoreStreamTransformer<String, String>(
2929
initialStateSupplier: () => 'InitialState',
3030
sideEffects: [sideEffect1, sideEffect2],
3131
reducer: (currentState, action) => action,
3232
),
3333
),
34-
emitsInOrder([
34+
emitsInOrder(<dynamic>[
3535
'InitialState',
3636
'InputAction1',
3737
'InputAction1SideEffect1',
@@ -55,7 +55,7 @@ void main() {
5555
),
5656
),
5757
emitsInOrder(
58-
[
58+
<dynamic>[
5959
'InitialState',
6060
emitsDone,
6161
],
@@ -76,7 +76,7 @@ void main() {
7676
),
7777
),
7878
emitsInOrder(
79-
[
79+
<dynamic>[
8080
'InitialState',
8181
emitsError(
8282
const TypeMatcher<String>()
@@ -110,7 +110,7 @@ void main() {
110110
reducer: (currentState, action) => currentState + action,
111111
),
112112
),
113-
emitsInOrder([
113+
emitsInOrder(<String>[
114114
'Initial',
115115
'Initial' 'Action1',
116116
'Initial' 'Action1' 'Action2',
@@ -136,7 +136,7 @@ void main() {
136136
),
137137
),
138138
emitsInOrder(
139-
[
139+
<dynamic>[
140140
'Initial',
141141
emitsError(
142142
const TypeMatcher<ReducerException>()
@@ -185,7 +185,7 @@ void main() {
185185
expect(
186186
stateStream,
187187
emitsInOrder(
188-
[
188+
<String>[
189189
'0',
190190
'0-1',
191191
'0-1-2',
@@ -203,7 +203,7 @@ void main() {
203203
'Disposing reduxStore disposes all side effects and upstream',
204204
() async {
205205
var disposedSideffectsCount = 0;
206-
var outputedError;
206+
dynamic outputedError;
207207
var outputCompleted = false;
208208

209209
final dummyAction = 'SomeAction';
@@ -234,24 +234,24 @@ void main() {
234234
)
235235
.listen(
236236
outputedStates.add,
237-
onError: (e, s) => outputedError = e,
237+
onError: (dynamic e, StackTrace s) => outputedError = e,
238238
onDone: () => outputCompleted = true,
239239
);
240240

241241
// I know it's bad, but it does the job
242-
await Future.delayed(const Duration(milliseconds: 100));
242+
await Future<void>.delayed(const Duration(milliseconds: 100));
243243

244244
// Trigger some action
245245
upstream.add(dummyAction);
246246

247247
// I know it's bad, but it does the job
248-
await Future.delayed(const Duration(milliseconds: 100));
248+
await Future<void>.delayed(const Duration(milliseconds: 100));
249249

250250
// Dispose the whole cain
251251
await subscription.cancel();
252252

253253
// I know it's bad, but it does the job
254-
await Future.delayed(const Duration(milliseconds: 500));
254+
await Future<void>.delayed(const Duration(milliseconds: 500));
255255

256256
// Verify everything is fine
257257
expect(disposedSideffectsCount, 2);
@@ -299,7 +299,7 @@ void main() {
299299
);
300300
await expectLater(
301301
state,
302-
emitsInOrder([
302+
emitsInOrder(<String>[
303303
'State',
304304
'State0',
305305
'State01',
@@ -313,7 +313,8 @@ void main() {
313313
sideEffects: [],
314314
reducer: (state, action) => '$state+$action',
315315
);
316-
expect(stream, emitsInOrder([emitsError(isException), emitsDone]));
316+
expect(
317+
stream, emitsInOrder(<dynamic>[emitsError(isException), emitsDone]));
317318
});
318319

319320
test('Pause and resume', () {
@@ -411,7 +412,7 @@ void main() {
411412
});
412413

413414
test('Cancel subscription', () async {
414-
final controller = StreamController(sync: true);
415+
final controller = StreamController<int>(sync: true);
415416

416417
// ignore: unawaited_futures
417418
controller.stream
@@ -427,7 +428,7 @@ void main() {
427428
controller.add(1);
428429
controller.add(2);
429430

430-
await Future.delayed(const Duration(seconds: 1));
431+
await Future<void>.delayed(const Duration(seconds: 1));
431432
});
432433
});
433434
}

0 commit comments

Comments
 (0)