2.1.0

Author: hoc081098

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 2.1.0 - Aug 28, 2020
+
+-   State stream returned from `RxReduxStore` will not replay the latest state
+    (Use `RxReduxStore.state` getter instead).
+
 ## 2.0.0 - Aug 27, 2020
 
 -   Added `Logger` which allows logging current state, action and new state.

lib/src/store.dart

@@ -31,7 +31,7 @@ class RxReduxStore<A, S> {
   final void Function(A) _dispatch;
 
   final GetState<S> _getState;
-  final Stream<S> Function() _stateStream;
+  final Stream<S> _stateStream;
   final Stream<A> _actionStream;
 
   final Future<void> Function() _dispose;
@@ -62,18 +62,22 @@ class RxReduxStore<A, S> {
     bool Function(S previous, S next) equals,
     RxReduxLogger logger,
   }) {
-    final actionSubject = StreamController<A>.broadcast(sync: true);
+    final actionSubject = StreamController<A>(sync: true);
     final actionOutputController = StreamController<A>.broadcast(sync: true);
 
-    final stateStream = actionSubject.stream.reduxStore<S>(
-      initialStateSupplier: () => initialState,
-      sideEffects: [
-        ...sideEffects,
-        _onEachActionSideEffect(actionOutputController),
-      ],
-      reducer: reducer,
-      logger: logger,
-    );
+    final stateStream = actionSubject.stream
+        .reduxStore<S>(
+          initialStateSupplier: () => initialState,
+          sideEffects: [
+            ...sideEffects,
+            _onEachActionSideEffect(actionOutputController),
+          ],
+          reducer: reducer,
+          logger: logger,
+        )
+        .distinct(equals)
+        .skip(1)
+        .asBroadcastStream(onCancel: (subscription) => subscription.cancel());
 
     var currentState = initialState;
     final subscription = stateStream.listen(
@@ -84,11 +88,7 @@ class RxReduxStore<A, S> {
     return RxReduxStore._(
       actionSubject.add,
       () => currentState,
-      () => () async* {
-        yield currentState;
-        yield* stateStream;
-      }()
-          .distinct(equals),
+      stateStream,
       actionOutputController.stream,
       () => Future.wait([
         actionSubject.close(),
@@ -115,7 +115,7 @@ class RxReduxStore<A, S> {
   ///         return LoginWidget(state); // build widget based on state.
   ///       },
   ///     );
-  Stream<S> get stateStream => _stateStream();
+  Stream<S> get stateStream => _stateStream;
 
   /// Get current state synchronously.
   /// This is useful for filling `initialData` when using `StreamBuilder` in Flutter.

test/store_test.dart

@@ -46,14 +46,15 @@ void main() {
       expect(store.state, 0);
     });
 
-    test('Get state stream that emits initial state', () {
+    test('Get state stream that never emits', () {
       final store = RxReduxStore<int, int>(
         initialState: 0,
         sideEffects: [],
         reducer: (s, a) => s + a,
       );
 
-      expect(store.stateStream, emits(0));
+      store.stateStream.listen((event) => expect(true, isFalse));
+      Future<void>.delayed(const Duration(seconds: 1));
     });
 
     test('Get state stream', () async {
@@ -67,7 +68,6 @@ void main() {
         store.stateStream,
         emitsInOrder(
           <String>[
-            '0',
             '0+1',
             '0+1+2',
             '0+1+2+3',
@@ -82,7 +82,8 @@ void main() {
       store.dispatch(3);
 
       await future;
-      expect(store.stateStream, emits('0+1+2+3'));
+      store.stateStream.listen((_) => expect(true, isFalse));
+      await Future<void>.delayed(const Duration(seconds: 1));
     });
 
     test('Get state stream with SideEffects', () async {
@@ -123,7 +124,6 @@ void main() {
         store.stateStream,
         emitsInOrder(
           <int>[
-            0,
             1,
             3,
             6,
@@ -146,7 +146,6 @@ void main() {
         store.stateStream,
         emitsInOrder(
           <int>[
-            6,
             7,
             9,
             12,
@@ -286,16 +285,10 @@ void main() {
 
       await rxReduxStore.dispose();
 
-      rxReduxStore.stateStream.listen(
-        expectAsync1(
-          (v) => expect(v, '0'),
-          count: 1,
-        ),
-        onDone: expectAsync0(
-          () {},
-          count: 1,
-        ),
-      );
+      expect(rxReduxStore.state, '0');
+      expect(() => rxReduxStore.dispatch(0), throwsStateError);
+      expect(rxReduxStore.actionStream, emitsDone);
+      expect(rxReduxStore.stateStream, emitsDone);
     });
 
     test('Error handler called when reducer throws', () async {