Skip to content

Commit b0ded49

Browse files
committed
fix(multicache): handle get key undefined
1 parent c938eba commit b0ded49

File tree

7 files changed

+16
-11
lines changed

7 files changed

+16
-11
lines changed

storages/lru-redis/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,5 @@
5454
"@types/lru-cache": "^5.1.0",
5555
"ioredis-mock": "^4.21.8"
5656
},
57-
"gitHead": "12356d80b38a7b841fa377840f13c37fbe3c9cd3"
57+
"gitHead": "c938eba762060f940a34bc192bec03bc76ea4017"
5858
}

storages/lru/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,5 @@
5151
"devDependencies": {
5252
"@types/lru-cache": "^5.1.0"
5353
},
54-
"gitHead": "179ca6def52cbf51e09fc22c09f7313d6356105b"
54+
"gitHead": "c938eba762060f940a34bc192bec03bc76ea4017"
5555
}

storages/node-cache/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,5 @@
5151
"@hokify/node-ts-cache": "^5.4.0",
5252
"@types/node-cache": "^4.2.5"
5353
},
54-
"gitHead": "179ca6def52cbf51e09fc22c09f7313d6356105b"
54+
"gitHead": "c938eba762060f940a34bc192bec03bc76ea4017"
5555
}

storages/redis/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,5 +63,5 @@
6363
"proxyquire": "2.1.3",
6464
"sinon": "9.2.0"
6565
},
66-
"gitHead": "179ca6def52cbf51e09fc22c09f7313d6356105b"
66+
"gitHead": "c938eba762060f940a34bc192bec03bc76ea4017"
6767
}

storages/redisio/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,5 @@
5454
"@types/ioredis": "^4.17.6",
5555
"ioredis-mock": "^4.21.8"
5656
},
57-
"gitHead": "7d2e5b85914c7a6e54edad434b0fcbae37c484b4"
57+
"gitHead": "c938eba762060f940a34bc192bec03bc76ea4017"
5858
}

ts-cache/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,5 +53,5 @@
5353
"url": "https://github.com/hokify/node-ts-cache/issues"
5454
},
5555
"homepage": "https://github.com/hokify/node-ts-cache/tree/master/ts-cache#readme",
56-
"gitHead": "179ca6def52cbf51e09fc22c09f7313d6356105b"
56+
"gitHead": "c938eba762060f940a34bc192bec03bc76ea4017"
5757
}

ts-cache/src/decorator/multicache.decorator.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const defaultKeyStrategy = {
77
parameter: any,
88
args: any,
99
_phase: 'read' | 'write'
10-
): string {
10+
): string | undefined {
1111
return `${className}:${methodName}:${JSON.stringify(
1212
parameter
1313
)}:${JSON.stringify(args)}`;
@@ -136,17 +136,22 @@ export function MultiCache(
136136
if (!process.env.DISABLE_CACHE_DECORATOR) {
137137
// save back to all caching strategies
138138
const saveToCache = originalMethodResult.map((content, i) => {
139-
return {
140-
key: keyStrategy.getKey(
139+
const key = keyStrategy.getKey(
141140
className,
142141
methodName,
143142
missingKeys[i],
144143
args,
145144
'write'
146-
),
145+
);
146+
if (key === undefined) {
147+
return undefined;
148+
}
149+
150+
return {
151+
key,
147152
content,
148153
};
149-
});
154+
}).filter(f => f !== undefined) as {key: string; content: any}[]
150155

151156
// console.log('saveToCache', saveToCache);
152157

0 commit comments

Comments
 (0)