Active keepAlive and noDelay after connection (#15)

Author: yassernasc

binding.c

@@ -924,10 +924,12 @@ bare_tcp_address(js_env_t *env, js_callback_info_t *info) {
     err = js_create_int32(env, ntohs(addr_in6->sin6_port), &result_port);
     assert(err == 0);
   } else {
-    err = js_get_null(env, &result);
+    err = UV_EAI_ADDRFAMILY;
+
+    err = js_throw_error(env, uv_err_name(err), uv_strerror(err));
     assert(err == 0);
 
-    return result;
+    return NULL;
   }
 
   err = js_set_named_property(env, result, "address", result_address);

index.js

@@ -19,6 +19,10 @@ exports.Socket = class TCPSocket extends Duplex {
 
     this._allowHalfOpen = allowHalfOpen
 
+    this._keepAlive = 0
+    this._keepAliveInitialDelay = 0
+    this._noDelay = 0
+
     this._localAddress = null
     this._remoteAddress = null
 
@@ -171,8 +175,11 @@ exports.Socket = class TCPSocket extends Duplex {
     try {
       binding.connect(this._handle, port, host, family)
 
-      if (keepAlive) this.setKeepAlive(keepAlive, keepAliveInitialDelay)
-      if (noDelay) this.setNoDelay()
+      if (keepAlive) {
+        this._keepAlive = keepAlive
+        this._keepAliveInitialDelay = keepAliveInitialDelay
+      }
+      if (noDelay) this._noDelay = noDelay
       if (timeout) this.setTimeout(timeout)
 
       if (onconnect) this.once('connect', onconnect)
@@ -333,6 +340,9 @@ exports.Socket = class TCPSocket extends Duplex {
       return
     }
 
+    if (this._keepAlive) this.setKeepAlive(this._keepAlive, this._keepAliveInitialDelay)
+    if (this._noDelay) this.setNoDelay()
+
     this._localAddress = binding.address(this._handle, true)
     this._remoteAddress = binding.address(this._handle, false)
 

test.js

@@ -102,7 +102,7 @@ test('address getters', async (t) => {
 
   const { port: serverPort } = server.address()
 
-  const socket = createConnection(serverPort)
+  const socket = createConnection({ port: serverPort, noDelay: true, keepAlive: 1000 })
     .on('connect', () => {
       t.is(socket.localAddress, '127.0.0.1')
       t.is(socket.localFamily, 'IPv4')