prevent bad link in opstream from crashing sidecar

Author: Didericis

subsystems/sidecar/lib/opstream.js

@@ -1,6 +1,7 @@
 'use strict'
 const streamx = require('streamx')
 const plink = require('pear-link')
+const { ERR_INVALID_LINK } = require('pear-errors')
 const Session = require('./session')
 module.exports = class Opstream extends streamx.Readable {
   final = {}
@@ -24,7 +25,15 @@ module.exports = class Opstream extends streamx.Readable {
           if (autosession) return this.session.close()
         }
 
-        if (params.link) params.link = plink.normalize(params.link)
+        if (params.link !== undefined) {
+          try {
+            params.link = plink.normalize(params.link)
+          } catch (e) {
+            e.code = ERR_INVALID_LINK.name
+            error(e)
+            return close()
+          }
+        }
         op(params).catch(error).finally(close)
       }
     })

test/15-opstream.test.js

@@ -0,0 +1,61 @@
+const test = require('brittle')
+const b4a = require('b4a')
+
+const Helper = require('./helper')
+const { ERR_INVALID_LINK } = require('pear-errors')
+
+const opMethods = [
+  'data',
+  'drop',
+  'dump',
+  'gc',
+  'info',
+  'release',
+  'run',
+  'seed',
+  'shift',
+  'stage',
+  'touch'
+]
+
+const testOp = async ({ t, link, helper, method, checkError } = opts) => {
+  const stream = helper[method]({ link })
+  try {
+    await Helper.pick(stream, { tag: 'final' })
+    t.fail('expected op to fail (op passed)')
+  } catch (e) {
+    if (checkError(e)) {
+      t.pass()
+    } else {
+      t.fail(`op failed with unexepcted error: ${e}`)
+    }
+  }
+}
+
+test('running ops with invalid link param type does not crash the sidecar', async (t) => {
+  const links = [
+    {},
+    { id: 'invalid-link' },
+    0,
+    1,
+    null,
+    true,
+    false,
+    b4a.allocUnsafe(8)
+  ]
+  t.plan(opMethods.length * links.length * 2)
+
+  const helper = new Helper()
+  t.teardown(() => helper.close(), { order: Infinity })
+  await helper.ready()
+  const checkError = (e) => e.code === ERR_INVALID_LINK.name
+
+  for (const method of opMethods) {
+    for (const link of links) {
+      t.comment(`calling "${method}" with link set to ${JSON.stringify(link)}`)
+      await testOp({ t, link, helper, method, checkError })
+      t.comment(`calling "${method}" again (testing sidecar not crashed)`)
+      await testOp({ t, link, helper, method, checkError })
+    }
+  }
+})

test/index.js

@@ -21,6 +21,7 @@ async function runTests() {
   await import('./12-assets.test.js')
   await import('./13-stage.test.js')
   await import('./14-preflight.test.js')
+  await import('./15-opstream.test.js')
 
   test.resume()
 }