prevent bad link in opstream from crashing sidecar

Author: Didericis

subsystems/sidecar/lib/opstream.js

@@ -24,7 +24,15 @@ module.exports = class Opstream extends streamx.Readable {
           if (autosession) return this.session.close()
         }
 
-        if (params.link) params.link = plink.normalize(params.link)
+        if (params.link) {
+          try {
+            params.link = plink.normalize(params.link)
+          } catch (e) {
+            e.code = 'INVALID_LINK'
+            error(e)
+            return close()
+          }
+        }
         op(params).catch(error).finally(close)
       }
     })

test/15-opstream.test.js

@@ -0,0 +1,45 @@
+const test = require('brittle')
+const Helper = require('./helper')
+
+test('running ops with invalid link param does not crash the sidecar', async (t) => {
+  const opMethods = [
+    'data',
+    'drop',
+    'dump',
+    'gc',
+    'info',
+    'release',
+    'run',
+    'seed',
+    'shift',
+    'stage',
+    'touch'
+  ]
+  t.plan(opMethods.length * 2)
+
+  const helper = new Helper()
+  t.teardown(() => helper.close(), { order: Infinity })
+  await helper.ready()
+
+  for (const method of opMethods) {
+    const testOp = async () => {
+      const params = { link: { id: 'not-a-link' } }
+      const stream = helper[method](params)
+      try {
+        await Helper.pick(stream, { tag: 'final' })
+        t.fail('expected op to fail (op passed)')
+      } catch (e) {
+        if (e.code === 'INVALID_LINK') {
+          t.pass()
+        } else {
+          t.fail('expected op to fail with INVALID_LINK error')
+        }
+      }
+    }
+
+    t.comment(`calling "${method}" with invalid link param throws an error`)
+    await testOp()
+    t.comment(`"${method}" can be called again (sidecar not crashed)`)
+    await testOp()
+  }
+})

test/index.js

@@ -21,6 +21,7 @@ async function runTests() {
   await import('./12-assets.test.js')
   await import('./13-stage.test.js')
   await import('./14-preflight.test.js')
+  await import('./15-opstream.test.js')
 
   test.resume()
 }