Avoid trying to make arrays with length -1, correct inadvertent omission of some tests

Author: holly-cummins

.github/workflows/check-external-links.yml

@@ -56,5 +56,5 @@ jobs:
         uses: jbangdev/[email protected]
         if: always() # we *especially* want to run this if the link checker failed
         with:
-          script: util/dead-link-issue.java
+          script: site-validation/dead-link-issue.java
           scriptargs: token=${{ secrets.GITHUB_TOKEN }} issueRepo=${{ github.repository }}  runId=${{ github.run_id }} siteUrl=https://quarkus.io/extensions

package.json

@@ -103,9 +103,9 @@
     "start": "cp ./node_modules/gatsby-page-utils/dist/apply-trailing-slash-option.js ./node_modules/gatsby-page-utils && gatsby develop",
     "serve": "gatsby serve",
     "clean": "gatsby clean",
-    "test": "ACTIVE_ENV=test SUPPRESS_ENV_OUTPUT=true jest --testPathIgnorePatterns test-integration/ --testPathIgnorePatterns util/",
-    "test:watch": "ACTIVE_ENV=test SUPPRESS_ENV_OUTPUT=true jest --watch --testPathIgnorePatterns test-integration/ --testPathIgnorePatterns util/",
+    "test": "ACTIVE_ENV=test SUPPRESS_ENV_OUTPUT=true jest --testPathIgnorePatterns test-integration/ --testPathIgnorePatterns site-validation/",
+    "test:watch": "ACTIVE_ENV=test SUPPRESS_ENV_OUTPUT=true jest --watch --testPathIgnorePatterns test-integration/ --testPathIgnorePatterns site-validation/",
     "test:int": "echo '--- Do not forget to run \u001b[1mgatsby build\u001b[0m before running integration tests! ---' && jest --config=jest.integration.config.js test-integration/",
-    "test:links": "echo '--- Do not forget to run \u001b[1mgatsby build\u001b[0m before running integration tests! ---' && jest --config=jest.integration.config.js util/external-links.test.js"
+    "test:links": "echo '--- Do not forget to run \u001b[1mgatsby build\u001b[0m before running integration tests! ---' && jest --config=jest.integration.config.js site-validation/external-links.test.js"
   }
 }

util/dead-link-issue.java renamed to site-validation/dead-link-issue.java

@@ -20,7 +20,7 @@ const getPalette = (n, baseCode) => {
     // Do a cyclical range of colours, from coloured down to white, then through shades of grey, then black from black to coloured
     // In pie charts, thin widges tend to look white because of the border, no matter what colour we set
     const colouredElements = Math.max(Math.round(n / 3) + 1, 6)
-    const greyElements = n - 2 * colouredElements
+    const greyElements = Math.max(0, n - 2 * colouredElements)
     const colouredIncrement = 100 / (2 * colouredElements)
     const greyIncrement = 100 / greyElements
 

util/external-links.test.js renamed to site-validation/external-links.test.js

@@ -12,6 +12,13 @@ describe("the styles helper", () => {
       expect(palette[0]).toBe(QUARKUS_BLUE)
     })
 
+    it("can handle palettes with odd lengths", () => {
+      const len = 11
+      const palette = getPalette(len, QUARKUS_BLUE)
+      expect(palette).toHaveLength(len + 1) // As the length is odd and below 12, we get an even-length palette
+      expect(palette[0]).toBe(QUARKUS_BLUE)
+    })
+
     it("returns palettes of the correct length", () => {
       expect(getPalette(6)).toHaveLength(6)
       expect(getPalette(14)).toHaveLength(14)