Make compatible with more compilers

Author: Vaughn

CMakeLists.txt

@@ -25,7 +25,7 @@ if (${CMAKE_PROJECT_NAME} STREQUAL coda-oss)
     if (MSVC)
        add_compile_options(/WX) # warnings as errors
        add_compile_options(/MP) # multi-processor compile
-    elseif (UNIX)
+    elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
        add_compile_options(-Werror) # warnings as errors
        add_compile_options(-Wno-error=c++20-compat)
     endif()

modules/c++/CMakeLists.txt

@@ -9,31 +9,25 @@ if (MSVC)
     # > extremely noisy and low-value warnings. In general, the STL does not attempt to be `/Wall` clean.
     string(REGEX REPLACE "/W[0-4]" "/W4" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") # add_compile_options(/W4)
 
-elseif (UNIX)
+elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
     # https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
     #add_compile_options(-Werror) # Make all warnings into errors
-    add_compile_options(-Wall -Wextra -Wpedantic -pedantic-errors -Wunused)
-
-    add_compile_options(-Wzero-as-null-pointer-constant)
-    #add_compile_options(-Wsuggest-final-types -Wsuggest-final-methods)
-    add_compile_options(-Wsuggest-override)
-    add_compile_options(-Woverloaded-virtual)
-    #add_compile_options(-Warray-bounds)
-    add_compile_options(-Wduplicated-branches -Wduplicated-cond)
-    add_compile_options(-Wtrampolines)
-    add_compile_options(-Wshadow)
-    #set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wold-style-cast")
-    #add_compile_options(-Wfloat-equal)
-    #add_compile_options(-Wconversion)
-    #set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Weffc++")
-
-    add_compile_options(-Wno-double-promotion) # implicit conversion of `float` to `double` is fine
-
-    add_compile_options(-Wno-array-bounds) # TODO: fix the code!
-    add_compile_options(-Wno-maybe-uninitialized) # TODO: fix the code!
-
-    # Need a newer compiler than GCC 9
-    #add_compile_options(-Wnrvo)
+    add_compile_options(-Wall -Wextra -Wpedantic -pedantic-errors -Wunused
+        -Wzero-as-null-pointer-constant
+        -Wsuggest-final-types -Wsuggest-final-methods
+        -Wsuggest-override
+        -Woverloaded-virtual
+        -Warray-bounds
+        -Wduplicated-branches -Wduplicated-cond
+        -Wtrampolines
+        -Wshadow
+        -Wold-style-cast
+        -Wfloat-equal
+        -Wconversion
+        -Weffc++
+        # Need a newer compiler than GCC 9
+        #-Wnrvo
+    )
 endif()
 
 # add an interface library for unittests

modules/c++/sys/CMakeLists.txt

@@ -1,5 +1,7 @@
 set(MODULE_NAME sys)
 
+include(CheckSourceCompiles)
+check_source_compiles(CXX [[ int main() { __builtin_cpu_init(); return 0; } ]] HAVE_BUILTIN_CPU_INIT)
 coda_generate_module_config_header(${MODULE_NAME})
 
 coda_add_module(

modules/c++/sys/include/sys/Dbg.h

@@ -4,6 +4,7 @@
  * 
  * (C) Copyright 2004 - 2014, MDA Information Systems LLC
  * (C) Copyright 2021, Maxar Technologies, Inc.
+ * (C) Copyright 2025-26 ARKA Group, L.P. All rights reserved
  *
  * sys-c++ is free software; you can redistribute it and/or modify
  * it under the terms of the GNU Lesser General Public License as published by
@@ -71,8 +72,6 @@
                 //#error "NDEBUG should be #define'd with __OPTIMIZE__"
             #endif
             #define CODA_OSS_DEBUG 0 // i.e., release
-        #else
-            #error "Can't #define CODA_OSS_DEBUG for __GNUC__."
         #endif
     #endif // __GNUC__
 

modules/c++/sys/include/sys/sys_config.h.cmake.in

@@ -1,6 +1,7 @@
 #ifndef _@tgt_munged_name@_CONFIG_H_
 #define _@tgt_munged_name@_CONFIG_H_
 
+#cmakedefine01 HAVE_BUILTIN_CPU_INIT 
 #cmakedefine HAVE_PTHREAD_H @HAVE_PTHREAD_H@
 #cmakedefine HAVE_EXECINFO_H @HAVE_EXECINFO_H@
 #cmakedefine HAVE_CLOCK_GETTIME @HAVE_CLOCK_GETTIME@

modules/c++/sys/source/OSUnix.cpp

@@ -426,7 +426,8 @@ void sys::OSUnix::getAvailableCPUs(std::vector<int>& physicalCPUs,
 
 sys::SIMDInstructionSet sys::OSUnix::getSIMDInstructionSet() const
 {
-#if defined(__x86_64__) || defined(__i386__)
+// NOTE: This function relies on compiler instrinsics at runtime
+#if (defined(__x86_64__) || defined(__i386__)) && HAVE_BUILTIN_CPU_INIT
     // https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/X86-Built-in-Functions.html
     __builtin_cpu_init();
 
@@ -444,7 +445,7 @@ sys::SIMDInstructionSet sys::OSUnix::getSIMDInstructionSet() const
     }
 #endif
 
-    throw std::runtime_error("SSE2 support is required.");
+    throw std::runtime_error("SIMD support is required.");
 }
 
 void sys::OSUnix::createSymlink(const std::string& origPathname,

modules/c++/xml.lite/CMakeLists.txt

@@ -1,10 +1,6 @@
 set(MODULE_NAME xml.lite)
 
 if(ENABLE_XML)
-    if (UNIX)
-       set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-zero-as-null-pointer-constant")
-       set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-suggest-override")
-    endif()
 
     if(CONAN_PACKAGE_NAME)
         # import targets from xerces-c conan package