Containers sections needs update to consume API version 3.4

[elmigbot]

3.4 puts container information under the "containers" plugin. (3.3 was "docker")

Also, "containers" omits some info, putting specific container data at top level. (i.e. http://localhost:61208/api/3/docker/containers becomes http://localhost:61208/api/3/containers

[freeDom-]

This is a breaking change. It would be great if you could create a PR adding the maximum supported version to the HA documentation.

I don't think that it should be changed atm, because Debian 11 (which HA supports) currently uses Glances 3.2.1 as default. Dont know which v HA OS ships with, but probably the same?

[elmigbot]

I believe most people would be using the glances Add-on from the "Home Assistant Community Add-ons". The Add-on updated to 3.4 in version 0.19 back in May.

https://github.com/hassio-addons/addon-glances/releases/tag/v0.19.0

[freeDom-]

I believe most people would be using the glances Add-on from the "Home Assistant Community Add-ons". The Add-on updated to 3.4 in version 0.19 back in May.

https://github.com/hassio-addons/addon-glances/releases/tag/v0.19.0

I don't think that most people are using the addon, but indeed that is a problem! The addon should not use a version, which is currently not supported, because of API changes.

On the long term I agree that we need to make that change anyways.

In order to not break older versions it is probably best, if it would be configurable by creating an option such as "Use legacy v3 API". Then when data is pulled this is done according to the flag.

[elmigbot]

Maybe just look for http://localhost:61208/api/3/containers, but if not available, then look for http://localhost:61208/api/3/docker/containers?

[freeDom-]

Maybe just look for http://localhost:61208/api/3/containers, but if not available, then look for http://localhost:61208/api/3/docker/containers?

Generally OK and definitely the easy way for implementing, but it would result in two api calls instead of one, slowing everything down unnecessarily and creating more load. Why ask for something when knowing it does not exist?

[elmigbot]

True...

But, if it calls the new and expected API first, then its only one call for the majority of the time. And as time goes by, it becomes less and less likely to make the second call.

The trade-off is a breaking-change VS unnecessary load for a specific and dissappearing scenario. Maybe if the flag defaults to the latest version, it tips the scale toward the flag approach. (Only if the latest is prevalent).

[vajonam]

Can confirm this PR works with latest glances to get the containers information! please pull this in!

[LeeThompson]

I'm running home assistant in a docker container, I don't think I can use the "add on" if I wanted to so... yeah please fix this.

[elmigbot]

True...

But, if it calls the new and expected API first, then its only one call for the majority of the time. And as time goes by, it becomes less and less likely to make the second call.

The trade-off is a breaking-change VS unnecessary load for a specific and dissappearing scenario. Maybe if the flag defaults to the latest version, it tips the scale toward the flag approach. (Only if the latest is prevalent).

...or the integration uses an ALL endpoint rendering this discussion pointless :)

Good job @engrbm87 Thanks @vajonam !

[vajonam]

in the near term,

execute this inside the HA docker container, will need to do this after each update.

cd /usr/local/lib/python3.11/site-packages/glances_api
rm __init__.py
wget https://raw.githubusercontent.com/home-assistant-ecosystem/python-glances-api/0fa529b3c9a10afcdec50b191c559acbeebb6d9f/glances_api/__init__.py

[bratanon]

So #21 is now merged which fixes this issue. Time to close this one?