-
Notifications
You must be signed in to change notification settings - Fork 20
Description
Some users (myself included) are seeing the following error in the HA Log at startup:
Can not load data from *hole: xxxxxxxxxxxxx:80
Within the 'hole' package, the definition of 'async def get_data(self)' includes a hard-code timeout value of 5 seconds, which cannot be overridden from the pi_hole component in HA.
My preference would be to allow the HA pi_hole component to set/override this timeout value, especially since at startup, it may need to be adjusted due to increased resource demands or user hardware limitations.
It should be clarified that this issue doesn't appear to impact hole component usage, but rather just until the following data update (typically 5 min later), so very little impact is caused by this issue for most people.
Personally, I did run into an situation that caused this timeout to not allow a new pi_hole integration to be added to a running HA instance, when trying to add via the older yaml config entry method. Eventually, I had to install via the user interface's config entry method. But, no other reports of this situation have been reported, AFAIK.
I'm willing to work on the PR, if code owner gives thumbs up.