Skip to content

Commit 25206dd

Browse files
committed
Remove devices from list data disk API
1 parent 2ac07f6 commit 25206dd

File tree

4 files changed

+9
-12
lines changed

4 files changed

+9
-12
lines changed

aiohasupervisor/models/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
BootSlot,
2828
BootSlotName,
2929
DataDisk,
30-
DataDiskList,
3130
GreenInfo,
3231
GreenOptions,
3332
MigrateDataOptions,
@@ -108,7 +107,6 @@
108107
"OSUpdate",
109108
"MigrateDataOptions",
110109
"DataDisk",
111-
"DataDiskList",
112110
"SetBootSlotOptions",
113111
"GreenInfo",
114112
"GreenOptions",

aiohasupervisor/models/os.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,8 @@ class DataDisk(ResponseData):
7878

7979
@dataclass(frozen=True, slots=True)
8080
class DataDiskList(ResponseData):
81-
"""ListDataDisks model."""
81+
"""DataDiskList model."""
8282

83-
devices: list[str]
8483
disks: list[DataDisk]
8584

8685

aiohasupervisor/os.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
from .client import _SupervisorComponentClient
44
from .models.os import (
5+
DataDisk,
56
DataDiskList,
67
GreenInfo,
78
GreenOptions,
@@ -36,10 +37,10 @@ async def migrate_data(self, options: MigrateDataOptions) -> None:
3637
"""Migrate data to new data disk and reboot."""
3738
await self._client.post("os/datadisk/move", json=options.to_dict())
3839

39-
async def list_data_disks(self) -> DataDiskList:
40+
async def list_data_disks(self) -> list[DataDisk]:
4041
"""Get all data disks."""
4142
result = await self._client.get("os/datadisk/list")
42-
return DataDiskList.from_dict(result.data)
43+
return DataDiskList.from_dict(result.data).disks
4344

4445
async def wipe_data(self) -> None:
4546
"""Trigger data disk wipe on host and reboot."""

tests/test_os.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,11 @@ async def test_os_list_data_disks(
8181
body=load_fixture("os_datadisk_list.json"),
8282
)
8383
datadisks = await supervisor_client.os.list_data_disks()
84-
assert datadisks.devices == ["SSK-SSK-Storage-DF123"]
85-
assert datadisks.disks[0].vendor == "SSK"
86-
assert datadisks.disks[0].model == "SSK Storage"
87-
assert datadisks.disks[0].serial == "DF123"
88-
assert datadisks.disks[0].name == "SSK SSK Storage (DF123)"
89-
assert datadisks.disks[0].dev_path == PurePath("/dev/sda")
84+
assert datadisks[0].vendor == "SSK"
85+
assert datadisks[0].model == "SSK Storage"
86+
assert datadisks[0].serial == "DF123"
87+
assert datadisks[0].name == "SSK SSK Storage (DF123)"
88+
assert datadisks[0].dev_path == PurePath("/dev/sda")
9089

9190

9291
async def test_os_wipe_data(

0 commit comments

Comments
 (0)