ValueError not TypeError in post_init

Author: mdegat01

aiohasupervisor/models/backups.py

@@ -120,7 +120,7 @@ class PartialBackupRestoreOptions(ABC):  # noqa: B024
     def __post_init__(self) -> None:
         """Validate at least one thing to backup/restore is included."""
         if not any((self.addons, self.folders, self.homeassistant)):
-            raise TypeError(
+            raise ValueError(
                 "At least one of addons, folders, or homeassistant must have a value"
             )
 

aiohasupervisor/models/base.py

@@ -58,7 +58,7 @@ class Options(ABC, DataClassDictMixin):
     def __post_init__(self) -> None:
         """Validate at least one field is present."""
         if not self.to_dict():
-            raise TypeError("At least one field must have a value")
+            raise ValueError("At least one field must have a value")
 
     class Config(RequestConfig):
         """Mashumaro config."""

tests/test_backups.py

@@ -109,7 +109,10 @@ async def test_partial_backup_options() -> None:
     assert PartialBackupOptions(name="good", addons={"a"})
     assert PartialBackupOptions(name="good", folders={Folder.SSL})
     assert PartialBackupOptions(name="good", homeassistant=True)
-    with pytest.raises(TypeError):
+    with pytest.raises(
+        ValueError,
+        match="At least one of addons, folders, or homeassistant must have a value",
+    ):
         PartialBackupOptions(name="bad")
 
 
@@ -118,7 +121,10 @@ async def test_partial_restore_options() -> None:
     assert PartialRestoreOptions(addons={"a"})
     assert PartialRestoreOptions(folders={Folder.SSL})
     assert PartialRestoreOptions(homeassistant=True)
-    with pytest.raises(TypeError):
+    with pytest.raises(
+        ValueError,
+        match="At least one of addons, folders, or homeassistant must have a value",
+    ):
         PartialRestoreOptions(background=True)