Skip to content

Commit 6c7138b

Browse files
authored
letsencrypt: add check for dns.provider, cleanup build cache files (#4438)
Fail if DNS challenge is selected and the provider is not configured. Also clean up the cache files created by pip and Go build to significantly reduce image bloat. Fixes #4436
1 parent 14db6b2 commit 6c7138b

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

letsencrypt/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
## 6.0.4
4+
5+
- Require `dns.provider` if DNS challenge is set
6+
- Clean up cache files from the build to reduce image size
7+
38
## 6.0.3
49

510
- Fix issuing certificates when `acme_root_ca_cert` is set

letsencrypt/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ RUN \
5454
python3-dev \
5555
python3-pip \
5656
rustc \
57-
&& rm -rf /var/lib/apt/lists/*
57+
&& rm -rf /var/lib/apt/lists/* \
58+
&& rm -rf /root/.cache
5859

5960
# Copy data
6061
COPY rootfs /

letsencrypt/config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
version: 6.0.3
2+
version: 6.0.4
33
breaking_versions: [5.3.0, 6.0.0]
44
slug: letsencrypt
55
name: Let's Encrypt

letsencrypt/rootfs/etc/services.d/lets-encrypt/run

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ LEGACY_PROVIDERS="dns-eurodns dns-gehirn dns-noris"
3434
DEPRECATED_PROVIDERS="dns-azure dns-he"
3535

3636
if [ "${CHALLENGE}" == "dns" ]; then
37+
bashio::config.require 'dns.provider'
3738
bashio::log.info "Selected DNS Provider: ${DNS_PROVIDER}"
3839

3940
PROPAGATION_SECONDS=60

0 commit comments

Comments
 (0)