Skip to content

Commit 6b497e6

Browse files
authored
Replace all call to navigateToUri with the catching one (#6294)
* Replace all call to navigateToUri with the catching one * Fix lint issue
1 parent efcc9fa commit 6b497e6

File tree

27 files changed

+86
-66
lines changed

27 files changed

+86
-66
lines changed

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/OnboardingNavigation.kt

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,13 @@ import io.homeassistant.companion.android.onboarding.serverdiscovery.navigation.
3434
import io.homeassistant.companion.android.onboarding.serverdiscovery.navigation.serverDiscoveryScreen
3535
import io.homeassistant.companion.android.onboarding.sethomenetwork.navigation.navigateToSetHomeNetworkRoute
3636
import io.homeassistant.companion.android.onboarding.sethomenetwork.navigation.setHomeNetworkScreen
37+
import io.homeassistant.companion.android.onboarding.wearmtls.navigation.URL_MTLS_DOCUMENTATION
3738
import io.homeassistant.companion.android.onboarding.wearmtls.navigation.navigateToWearMTLS
3839
import io.homeassistant.companion.android.onboarding.wearmtls.navigation.wearMTLSScreen
3940
import io.homeassistant.companion.android.onboarding.welcome.navigation.WelcomeRoute
4041
import io.homeassistant.companion.android.onboarding.welcome.navigation.welcomeScreen
4142
import io.homeassistant.companion.android.util.canGoBack
4243
import io.homeassistant.companion.android.util.compose.navigateToUri
43-
import io.homeassistant.companion.android.util.compose.navigateToUriCatching
4444
import kotlinx.serialization.Serializable
4545

4646
@VisibleForTesting
@@ -132,7 +132,7 @@ internal fun NavGraphBuilder.onboarding(
132132
}
133133
},
134134
onLearnMoreClick = {
135-
navController.navigateToUri(URL_GETTING_STARTED_DOCUMENTATION)
135+
navController.navigateToUri(URL_GETTING_STARTED_DOCUMENTATION, onShowSnackbar)
136136
},
137137
)
138138
commonScreens(navController = navController, onShowSnackbar = onShowSnackbar)
@@ -156,7 +156,7 @@ internal fun NavGraphBuilder.onboarding(
156156
},
157157
onShowSnackbar = onShowSnackbar,
158158
onHelpClick = {
159-
navController.navigateToUri(URL_GETTING_STARTED_DOCUMENTATION)
159+
navController.navigateToUri(URL_GETTING_STARTED_DOCUMENTATION, onShowSnackbar)
160160
},
161161
)
162162
localFirstScreen(
@@ -183,7 +183,7 @@ internal fun NavGraphBuilder.onboarding(
183183
)
184184
locationSharingScreen(
185185
onHelpClick = {
186-
navController.navigateToUri(URL_GETTING_STARTED_DOCUMENTATION)
186+
navController.navigateToUri(URL_GETTING_STARTED_DOCUMENTATION, onShowSnackbar)
187187
},
188188
onGotoNextScreen = { serverId, hasPlainTextAccess ->
189189
navController.navigateToLocationForSecureConnectionConditionally(
@@ -199,7 +199,7 @@ internal fun NavGraphBuilder.onboarding(
199199
)
200200
locationForSecureConnectionScreen(
201201
onHelpClick = {
202-
navController.navigateToUri(URL_SECURITY_LEVEL_DOCUMENTATION)
202+
navController.navigateToUri(URL_SECURITY_LEVEL_DOCUMENTATION, onShowSnackbar)
203203
},
204204
onGotoNextScreen = { allowInsecureConnection, serverId ->
205205
if (allowInsecureConnection) {
@@ -219,7 +219,7 @@ internal fun NavGraphBuilder.onboarding(
219219

220220
setHomeNetworkScreen(
221221
onHelpClick = {
222-
navController.navigateToUri(URL_SECURITY_LEVEL_DOCUMENTATION)
222+
navController.navigateToUri(URL_SECURITY_LEVEL_DOCUMENTATION, onShowSnackbar)
223223
},
224224
onGotoNextScreen = {
225225
onOnboardingDone()
@@ -257,7 +257,7 @@ private fun NavGraphBuilder.commonScreens(
257257
},
258258
onManualSetupClick = navController::navigateToManualServer,
259259
onHelpClick = {
260-
navController.navigateToUri(URL_GETTING_STARTED_DOCUMENTATION)
260+
navController.navigateToUri(URL_GETTING_STARTED_DOCUMENTATION, onShowSnackbar)
261261
},
262262
)
263263
manualServerScreen(
@@ -266,7 +266,7 @@ private fun NavGraphBuilder.commonScreens(
266266
navController.navigateToConnection(it.toString())
267267
},
268268
onHelpClick = {
269-
navController.navigateToUri(URL_GETTING_STARTED_DOCUMENTATION)
269+
navController.navigateToUri(URL_GETTING_STARTED_DOCUMENTATION, onShowSnackbar)
270270
},
271271
)
272272
connectionScreen(
@@ -295,7 +295,7 @@ private fun NavGraphBuilder.commonScreens(
295295
},
296296
onBackClick = navController::popBackStack,
297297
onOpenExternalLink = {
298-
navController.navigateToUriCatching(it.toString(), onShowSnackbar = onShowSnackbar)
298+
navController.navigateToUri(it.toString(), onShowSnackbar = onShowSnackbar)
299299
},
300300
)
301301
}
@@ -423,15 +423,13 @@ internal fun NavGraphBuilder.wearOnboarding(
423423
}
424424
},
425425
onHelpClick = {
426-
navController.navigateToUri(URL_GETTING_STARTED_DOCUMENTATION)
426+
navController.navigateToUri(URL_GETTING_STARTED_DOCUMENTATION, onShowSnackbar)
427427
},
428428
)
429429
wearMTLSScreen(
430430
onBackClick = navController::popBackStack,
431431
onHelpClick = {
432-
navController.navigateToUri(
433-
"https://companion.home-assistant.io/docs/getting_started/#tls-client-authentication",
434-
)
432+
navController.navigateToUri(URL_MTLS_DOCUMENTATION, onShowSnackbar)
435433
},
436434
onNext = onOnboardingDone,
437435
)

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/locationforsecureconnection/LocationForSecureConnectionScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ private enum class SelectionKey {
6464
fun LocationForSecureConnectionScreen(
6565
viewModel: LocationForSecureConnectionViewModel,
6666
onGoToNextScreen: (allowInsecureConnection: Boolean) -> Unit,
67-
onHelpClick: () -> Unit,
67+
onHelpClick: suspend () -> Unit,
6868
onShowSnackbar: suspend (message: String, action: String?) -> Boolean,
6969
modifier: Modifier = Modifier,
7070
onBackClick: (() -> Unit)? = null,
@@ -92,7 +92,7 @@ fun LocationForSecureConnectionScreen(
9292
internal fun LocationForSecureConnectionScreen(
9393
initialAllowInsecureConnection: Boolean?,
9494
onAllowInsecureConnection: (allowInsecureConnection: Boolean) -> Unit,
95-
onHelpClick: () -> Unit,
95+
onHelpClick: suspend () -> Unit,
9696
onShowSnackbar: suspend (message: String, action: String?) -> Boolean,
9797
modifier: Modifier = Modifier,
9898
onBackClick: (() -> Unit)? = null,

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/locationforsecureconnection/navigation/LocationForSecureConnectionNavigation.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ internal fun NavController.navigateToLocationForSecureConnection(serverId: Int,
2020
}
2121

2222
internal fun NavGraphBuilder.locationForSecureConnectionScreen(
23-
onHelpClick: () -> Unit,
23+
onHelpClick: suspend () -> Unit,
2424
onGotoNextScreen: (allowInsecureConnection: Boolean, serverId: Int) -> Unit,
2525
onShowSnackbar: suspend (message: String, action: String?) -> Boolean,
2626
) {

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/locationsharing/LocationSharingScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ private val MaxContentWidth = MaxButtonWidth
4040

4141
@Composable
4242
internal fun LocationSharingScreen(
43-
onHelpClick: () -> Unit,
43+
onHelpClick: suspend () -> Unit,
4444
onGoToNextScreen: () -> Unit,
4545
viewModel: LocationSharingViewModel,
4646
modifier: Modifier = Modifier,
@@ -55,7 +55,7 @@ internal fun LocationSharingScreen(
5555

5656
@Composable
5757
internal fun LocationSharingScreen(
58-
onHelpClick: () -> Unit,
58+
onHelpClick: suspend () -> Unit,
5959
onGoToNextScreen: () -> Unit,
6060
onLocationSharingResponse: (enabled: Boolean) -> Unit,
6161
modifier: Modifier = Modifier,

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/locationsharing/navigation/LocationSharingNavigation.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ internal fun NavController.navigateToLocationSharing(
2121
}
2222

2323
internal fun NavGraphBuilder.locationSharingScreen(
24-
onHelpClick: () -> Unit,
24+
onHelpClick: suspend () -> Unit,
2525
onGotoNextScreen: (serverId: Int, hasPlainTextAccess: Boolean) -> Unit,
2626
) {
2727
composable<LocationSharingRoute> {

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/manualserver/ManualServerScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ private val delayBeforeError = 500.milliseconds
5353
internal fun ManualServerScreen(
5454
onBackClick: () -> Unit,
5555
onConnectTo: (URL) -> Unit,
56-
onHelpClick: () -> Unit,
56+
onHelpClick: suspend () -> Unit,
5757
viewModel: ManualServerViewModel,
5858
modifier: Modifier = Modifier,
5959
) {
@@ -79,7 +79,7 @@ internal fun ManualServerScreen(
7979
isServerUrlValid: Boolean,
8080
onBackClick: () -> Unit,
8181
onConnectClick: () -> Unit,
82-
onHelpClick: () -> Unit,
82+
onHelpClick: suspend () -> Unit,
8383
onServerUrlChange: (String) -> Unit,
8484
serverUrl: String,
8585
modifier: Modifier = Modifier,

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/manualserver/navigation/ManualServerNavigation.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ internal fun NavController.navigateToManualServer(navOptions: NavOptions? = null
1919
internal fun NavGraphBuilder.manualServerScreen(
2020
onBackClick: () -> Unit,
2121
onConnectTo: (URL) -> Unit,
22-
onHelpClick: () -> Unit,
22+
onHelpClick: suspend () -> Unit,
2323
) {
2424
composable<ManualServerRoute> {
2525
ManualServerScreen(

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/nameyourdevice/NameYourDeviceScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ import io.homeassistant.companion.android.util.compose.HAPreviews
4646
@Composable
4747
internal fun NameYourDeviceScreen(
4848
onBackClick: () -> Unit,
49-
onHelpClick: () -> Unit,
49+
onHelpClick: suspend () -> Unit,
5050
viewModel: NameYourDeviceViewModel,
5151
modifier: Modifier = Modifier,
5252
) {
@@ -68,7 +68,7 @@ internal fun NameYourDeviceScreen(
6868

6969
@Composable
7070
internal fun NameYourDeviceScreen(
71-
onHelpClick: () -> Unit,
71+
onHelpClick: suspend () -> Unit,
7272
onBackClick: () -> Unit,
7373
deviceName: String,
7474
onDeviceNameChange: (String) -> Unit,

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/nameyourdevice/navigation/NameYourDeviceNavigation.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ internal fun NavGraphBuilder.nameYourDeviceScreen(
2525
onBackClick: () -> Unit,
2626
onDeviceNamed: (serverId: Int, hasPlainTextAccess: Boolean, isPubliclyAccessible: Boolean) -> Unit,
2727
onShowSnackbar: suspend (message: String, action: String?) -> Boolean,
28-
onHelpClick: () -> Unit,
28+
onHelpClick: suspend () -> Unit,
2929
) {
3030
composable<NameYourDeviceRoute> {
3131
val viewModel: NameYourDeviceViewModel = hiltViewModel()

app/src/main/kotlin/io/homeassistant/companion/android/onboarding/nameyourweardevice/navigation/NameYourWearDeviceNavigation.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ internal fun NavController.navigateToNameYourWearDevice(
3535

3636
internal fun NavGraphBuilder.nameYourWearDeviceScreen(
3737
onBackClick: () -> Unit,
38-
onHelpClick: () -> Unit,
38+
onHelpClick: suspend () -> Unit,
3939
onDeviceNamed: (deviceName: String, serverUrl: String, authCode: String, neededMTLS: Boolean) -> Unit,
4040
) {
4141
composable<NameYourWearDeviceRoute> {

0 commit comments

Comments
 (0)