Fix ComposeModifierMissing lint warnings (#6324)

Author: crippa9

app/lint-baseline.xml

@@ -49,7 +49,7 @@ private sealed class CatalogScreen(val title: String, val icon: ImageVector) {
 }
 
 @Composable
-fun HAComposeCatalogScreen() {
+fun HAComposeCatalogScreen(modifier: Modifier = Modifier) {
     val screens = listOf(
         CatalogScreen.ButtonsAndIndicators,
         CatalogScreen.UserInput,
@@ -83,6 +83,7 @@ fun HAComposeCatalogScreen() {
                     }
                 }
             },
+            modifier = modifier,
         ) { scaffoldPadding ->
             val layoutDirection = LocalLayoutDirection.current
             LazyColumn(
@@ -106,7 +107,7 @@ fun HAComposeCatalogScreen() {
 }
 
 @Composable
-private fun VariantDropdownMenu(onVariantClick: (ButtonVariant) -> Unit, modifier: Modifier) {
+private fun VariantDropdownMenu(onVariantClick: (ButtonVariant) -> Unit, modifier: Modifier = Modifier) {
     var expanded by remember { mutableStateOf(false) }
 
     Box(modifier = modifier.padding(HADimens.SPACE4)) {

app/src/debug/kotlin/io/homeassistant/companion/android/developer/catalog/HAComposeCatalogScreen.kt

@@ -11,8 +11,9 @@ import io.homeassistant.companion.android.common.compose.theme.HADimens
 import io.homeassistant.companion.android.common.compose.theme.HATextStyle
 
 @Composable
-fun CatalogRow(content: @Composable () -> Unit) {
+fun CatalogRow(modifier: Modifier = Modifier, content: @Composable () -> Unit) {
     FlowRow(
+        modifier = modifier,
         horizontalArrangement = Arrangement.spacedBy(HADimens.SPACE4),
         verticalArrangement = Arrangement.spacedBy(HADimens.SPACE4),
     ) {

app/src/debug/kotlin/io/homeassistant/companion/android/developer/catalog/Shared.kt

@@ -55,6 +55,7 @@ fun MatterCommissioningView(
     onConfirmCommissioning: () -> Unit,
     onClose: () -> Unit,
     onContinue: () -> Unit,
+    modifier: Modifier = Modifier,
 ) {
     if (step == CommissioningFlowStep.NotStarted) return
 
@@ -66,7 +67,7 @@ fun MatterCommissioningView(
     )
 
     Box(
-        modifier = Modifier
+        modifier = modifier
             .fillMaxWidth()
             .verticalScroll(rememberScrollState()),
     ) {
@@ -208,8 +209,8 @@ fun MatterCommissioningView(
 }
 
 @Composable
-fun MatterCommissioningViewHeader() {
-    Column(modifier = Modifier.fillMaxWidth()) {
+fun MatterCommissioningViewHeader(modifier: Modifier = Modifier) {
+    Column(modifier = modifier.fillMaxWidth()) {
         Spacer(modifier = Modifier.height(32.dp))
         Image(
             imageVector = ImageVector.vectorResource(R.drawable.ic_matter),
@@ -231,7 +232,7 @@ fun MatterCommissioningViewHeader() {
 
 @Preview
 @Composable
-fun PreviewMatterCommissioningView(
+private fun PreviewMatterCommissioningView(
     @PreviewParameter(MatterCommissioningViewPreviewStates::class) step: CommissioningFlowStep,
 ) {
     HomeAssistantAppTheme {

app/src/full/kotlin/io/homeassistant/companion/android/matter/views/MatterCommissioningView.kt

@@ -43,6 +43,7 @@ fun LoadWearFavoritesSettings(
     settingsWearViewModel: SettingsWearViewModel,
     onBackClicked: () -> Unit,
     events: SharedFlow<String>,
+    modifier: Modifier = Modifier,
 ) {
     val lazyListState = rememberLazyListState()
     val reorderState = rememberReorderableLazyListState(lazyListState) { from, to ->
@@ -73,6 +74,7 @@ fun LoadWearFavoritesSettings(
     }
 
     Scaffold(
+        modifier = modifier,
         scaffoldState = scaffoldState,
         snackbarHost = {
             SnackbarHost(

app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearFavoritesView.kt

@@ -33,10 +33,15 @@ fun LoadSettingsHomeView(
     deviceName: String,
     loginWearOs: () -> Unit,
     onStartBackClicked: () -> Unit,
+    modifier: Modifier = Modifier,
 ) {
     HomeAssistantAppTheme {
         val navController = rememberNavController()
-        NavHost(navController = navController, startDestination = SettingsWearMainView.LANDING) {
+        NavHost(
+            navController = navController,
+            startDestination = SettingsWearMainView.LANDING,
+            modifier = modifier,
+        ) {
             composable(SettingsWearMainView.FAVORITES) {
                 LoadWearFavoritesSettings(
                     settingsWearViewModel = settingsWearViewModel,
@@ -102,11 +107,16 @@ fun LoadSettingsHomeView(
 }
 
 @Composable
-fun SettingsWearTopAppBar(title: @Composable () -> Unit, onBackClicked: () -> Unit, docsLink: String? = null) {
+fun SettingsWearTopAppBar(
+    title: @Composable () -> Unit,
+    onBackClicked: () -> Unit,
+    modifier: Modifier = Modifier,
+    docsLink: String? = null,
+) {
     val context = LocalContext.current
     TopAppBar(
         title = title,
-        modifier = Modifier.windowInsetsPadding(safeTopWindowInsets()),
+        modifier = modifier.windowInsetsPadding(safeTopWindowInsets()),
         navigationIcon = {
             IconButton(onClick = onBackClicked) {
                 Image(

app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearHomeView.kt

@@ -44,6 +44,7 @@ fun SettingWearLandingView(
     loginWearOs: () -> Unit,
     onBackClicked: () -> Unit,
     events: Flow<String>,
+    modifier: Modifier = Modifier,
 ) {
     val scaffoldState = rememberScaffoldState()
     LaunchedEffect("snackbar") {
@@ -53,6 +54,7 @@ fun SettingWearLandingView(
     }
 
     Scaffold(
+        modifier = modifier,
         scaffoldState = scaffoldState,
         snackbarHost = {
             SnackbarHost(

app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearLandingView.kt

@@ -51,7 +51,8 @@ class SettingsWearMainView : AppCompatActivity() {
                 settingsWearViewModel,
                 currentNodes.firstOrNull()?.displayName ?: "unknown",
                 this::loginWearOs,
-            ) { onBackPressedDispatcher.onBackPressed() }
+                onStartBackClicked = { onBackPressedDispatcher.onBackPressed() },
+            )
         }
 
         if (registerUrl != null) {

app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearMainView.kt

@@ -55,8 +55,10 @@ fun SettingsWearTemplateTile(
     onContentChanged: (String) -> Unit,
     onRefreshIntervalChanged: (Int) -> Unit,
     onBackClicked: () -> Unit,
+    modifier: Modifier = Modifier,
 ) {
     Scaffold(
+        modifier = modifier,
         topBar = {
             SettingsWearTopAppBar(
                 title = { Text(stringResource(commonR.string.template_tile)) },

app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearTemplateTile.kt

@@ -27,8 +27,10 @@ fun SettingsWearTemplateTileList(
     templateTiles: Map<Int, TemplateTileConfig>,
     onTemplateTileClicked: (tileId: Int) -> Unit,
     onBackClicked: () -> Unit,
+    modifier: Modifier = Modifier,
 ) {
     Scaffold(
+        modifier = modifier,
         topBar = {
             SettingsWearTopAppBar(
                 title = { Text(stringResource(commonR.string.template_tiles)) },