Replies: 2 comments 1 reply
-
I think this would be a great idea, I can see the need for a |
Beta Was this translation helpful? Give feedback.
0 replies
-
While I generally like this idea, we should be mindful of unnecessary complexity where we don't need a split right now, and making it accessible to new contributors. The current structure is easy enough to follow; if you have to edit 6 modules to add one feature that might be a bit daunting. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Today we have already multiple Gradle modules
:build-logic:convention
:app
:automotive
:common
:lint
:testing-unit
:wear
This is allowing us a separation of concern at a high level. The current split is not very flexible every application module depends on
:common
, but we might want to share things between 2 app modules and not with:wear
for instance.Instead we could make the app modules smaller and put the features into dedicated module like
:onboarding
,:settings
,:webview
. This would allow us to compose an application module with the features we want using the compose navigation framework and hilt.We could push the idea further and split
:common
into smaller pieces more specific to reduce the scope of each module, and avoid having compose code and network code in the same module.Don't hesitate to share your pros/cons.
Beta Was this translation helpful? Give feedback.
All reactions