Ensure go2rtc server starts using posix_spawn/vfork (#129196)

bdraco · web-flow · commit 59227116f3e7 · 2024-10-26T06:51:29.000+02:00
diff --git a/homeassistant/components/go2rtc/server.py b/homeassistant/components/go2rtc/server.py
@@ -62,6 +62,7 @@ async def start(self) -> None:
             config_file,
             stdout=asyncio.subprocess.PIPE,
             stderr=asyncio.subprocess.STDOUT,
+            close_fds=False,  # required for posix_spawn on CPython < 3.13
         )
 
         self._hass.async_create_background_task(
diff --git a/tests/components/go2rtc/test_server.py b/tests/components/go2rtc/test_server.py
@@ -67,6 +67,7 @@ async def test_server_run_success(
         "test.yaml",
         stdout=subprocess.PIPE,
         stderr=subprocess.STDOUT,
+        close_fds=False,
     )
 
     # Verify that the config file was written

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@ async def start(self) -> None:`
`62`	`62`	`config_file,`
`63`	`63`	`stdout=asyncio.subprocess.PIPE,`
`64`	`64`	`stderr=asyncio.subprocess.STDOUT,`
	`65`	`+ close_fds=False, # required for posix_spawn on CPython < 3.13`
`65`	`66`	`)`
`66`	`67`
`67`	`68`	`self._hass.async_create_background_task(`
Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,7 @@ async def test_server_run_success(`
`67`	`67`	`"test.yaml",`
`68`	`68`	`stdout=subprocess.PIPE,`
`69`	`69`	`stderr=subprocess.STDOUT,`
	`70`	`+ close_fds=False,`
`70`	`71`	`)`
`71`	`72`
`72`	`73`	`# Verify that the config file was written`