Skip to content

Commit 60b8392

Browse files
thomasddnthomasddn
authored
Fix device tracker name & icon for Volvo integration (#155667)
1 parent 7145fb9 commit 60b8392

File tree

3 files changed

+37
-24
lines changed

3 files changed

+37
-24
lines changed

‎homeassistant/components/volvo/icons.json‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,14 @@
283283
"default": "mdi:alarm-light"
284284
}
285285
},
286+
"device_tracker": {
287+
"location": {
288+
"default": "mdi:car",
289+
"state": {
290+
"not_home": "mdi:car-arrow-right"
291+
}
292+
}
293+
},
286294
"sensor": {
287295
"availability": {
288296
"default": "mdi:car-connected"

‎homeassistant/components/volvo/strings.json‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,11 @@
210210
"name": "Honk & flash"
211211
}
212212
},
213+
"device_tracker": {
214+
"location": {
215+
"name": "Location"
216+
}
217+
},
213218
"lock": {
214219
"lock": {
215220
"name": "[%key:component::lock::title%]"

‎tests/components/volvo/snapshots/test_device_tracker.ambr‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# serializer version: 1
2-
# name: test_device_tracker[ex30_2024][device_tracker.volvo_ex30_none-entry]
2+
# name: test_device_tracker[ex30_2024][device_tracker.volvo_ex30_location-entry]
33
EntityRegistryEntrySnapshot({
44
'aliases': set({
55
}),
@@ -12,7 +12,7 @@
1212
'disabled_by': None,
1313
'domain': 'device_tracker',
1414
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
15-
'entity_id': 'device_tracker.volvo_ex30_none',
15+
'entity_id': 'device_tracker.volvo_ex30_location',
1616
'has_entity_name': True,
1717
'hidden_by': None,
1818
'icon': None,
@@ -24,7 +24,7 @@
2424
}),
2525
'original_device_class': None,
2626
'original_icon': None,
27-
'original_name': None,
27+
'original_name': 'Location',
2828
'platform': 'volvo',
2929
'previous_unique_id': None,
3030
'suggested_object_id': None,
@@ -34,24 +34,24 @@
3434
'unit_of_measurement': None,
3535
})
3636
# ---
37-
# name: test_device_tracker[ex30_2024][device_tracker.volvo_ex30_none-state]
37+
# name: test_device_tracker[ex30_2024][device_tracker.volvo_ex30_location-state]
3838
StateSnapshot({
3939
'attributes': ReadOnlyDict({
40-
'friendly_name': 'Volvo EX30 None',
40+
'friendly_name': 'Volvo EX30 Location',
4141
'gps_accuracy': 0,
4242
'latitude': 57.72537482589284,
4343
'longitude': 11.849843629550225,
4444
'source_type': <SourceType.GPS: 'gps'>,
4545
}),
4646
'context': <ANY>,
47-
'entity_id': 'device_tracker.volvo_ex30_none',
47+
'entity_id': 'device_tracker.volvo_ex30_location',
4848
'last_changed': <ANY>,
4949
'last_reported': <ANY>,
5050
'last_updated': <ANY>,
5151
'state': 'not_home',
5252
})
5353
# ---
54-
# name: test_device_tracker[s90_diesel_2018][device_tracker.volvo_s90_none-entry]
54+
# name: test_device_tracker[s90_diesel_2018][device_tracker.volvo_s90_location-entry]
5555
EntityRegistryEntrySnapshot({
5656
'aliases': set({
5757
}),
@@ -64,7 +64,7 @@
6464
'disabled_by': None,
6565
'domain': 'device_tracker',
6666
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
67-
'entity_id': 'device_tracker.volvo_s90_none',
67+
'entity_id': 'device_tracker.volvo_s90_location',
6868
'has_entity_name': True,
6969
'hidden_by': None,
7070
'icon': None,
@@ -76,7 +76,7 @@
7676
}),
7777
'original_device_class': None,
7878
'original_icon': None,
79-
'original_name': None,
79+
'original_name': 'Location',
8080
'platform': 'volvo',
8181
'previous_unique_id': None,
8282
'suggested_object_id': None,
@@ -86,24 +86,24 @@
8686
'unit_of_measurement': None,
8787
})
8888
# ---
89-
# name: test_device_tracker[s90_diesel_2018][device_tracker.volvo_s90_none-state]
89+
# name: test_device_tracker[s90_diesel_2018][device_tracker.volvo_s90_location-state]
9090
StateSnapshot({
9191
'attributes': ReadOnlyDict({
92-
'friendly_name': 'Volvo S90 None',
92+
'friendly_name': 'Volvo S90 Location',
9393
'gps_accuracy': 0,
9494
'latitude': 57.72537482589284,
9595
'longitude': 11.849843629550225,
9696
'source_type': <SourceType.GPS: 'gps'>,
9797
}),
9898
'context': <ANY>,
99-
'entity_id': 'device_tracker.volvo_s90_none',
99+
'entity_id': 'device_tracker.volvo_s90_location',
100100
'last_changed': <ANY>,
101101
'last_reported': <ANY>,
102102
'last_updated': <ANY>,
103103
'state': 'not_home',
104104
})
105105
# ---
106-
# name: test_device_tracker[xc40_electric_2024][device_tracker.volvo_xc40_none-entry]
106+
# name: test_device_tracker[xc40_electric_2024][device_tracker.volvo_xc40_location-entry]
107107
EntityRegistryEntrySnapshot({
108108
'aliases': set({
109109
}),
@@ -116,7 +116,7 @@
116116
'disabled_by': None,
117117
'domain': 'device_tracker',
118118
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
119-
'entity_id': 'device_tracker.volvo_xc40_none',
119+
'entity_id': 'device_tracker.volvo_xc40_location',
120120
'has_entity_name': True,
121121
'hidden_by': None,
122122
'icon': None,
@@ -128,7 +128,7 @@
128128
}),
129129
'original_device_class': None,
130130
'original_icon': None,
131-
'original_name': None,
131+
'original_name': 'Location',
132132
'platform': 'volvo',
133133
'previous_unique_id': None,
134134
'suggested_object_id': None,
@@ -138,24 +138,24 @@
138138
'unit_of_measurement': None,
139139
})
140140
# ---
141-
# name: test_device_tracker[xc40_electric_2024][device_tracker.volvo_xc40_none-state]
141+
# name: test_device_tracker[xc40_electric_2024][device_tracker.volvo_xc40_location-state]
142142
StateSnapshot({
143143
'attributes': ReadOnlyDict({
144-
'friendly_name': 'Volvo XC40 None',
144+
'friendly_name': 'Volvo XC40 Location',
145145
'gps_accuracy': 0,
146146
'latitude': 57.72537482589284,
147147
'longitude': 11.849843629550225,
148148
'source_type': <SourceType.GPS: 'gps'>,
149149
}),
150150
'context': <ANY>,
151-
'entity_id': 'device_tracker.volvo_xc40_none',
151+
'entity_id': 'device_tracker.volvo_xc40_location',
152152
'last_changed': <ANY>,
153153
'last_reported': <ANY>,
154154
'last_updated': <ANY>,
155155
'state': 'not_home',
156156
})
157157
# ---
158-
# name: test_device_tracker[xc90_petrol_2019][device_tracker.volvo_xc90_none-entry]
158+
# name: test_device_tracker[xc90_petrol_2019][device_tracker.volvo_xc90_location-entry]
159159
EntityRegistryEntrySnapshot({
160160
'aliases': set({
161161
}),
@@ -168,7 +168,7 @@
168168
'disabled_by': None,
169169
'domain': 'device_tracker',
170170
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
171-
'entity_id': 'device_tracker.volvo_xc90_none',
171+
'entity_id': 'device_tracker.volvo_xc90_location',
172172
'has_entity_name': True,
173173
'hidden_by': None,
174174
'icon': None,
@@ -180,7 +180,7 @@
180180
}),
181181
'original_device_class': None,
182182
'original_icon': None,
183-
'original_name': None,
183+
'original_name': 'Location',
184184
'platform': 'volvo',
185185
'previous_unique_id': None,
186186
'suggested_object_id': None,
@@ -190,17 +190,17 @@
190190
'unit_of_measurement': None,
191191
})
192192
# ---
193-
# name: test_device_tracker[xc90_petrol_2019][device_tracker.volvo_xc90_none-state]
193+
# name: test_device_tracker[xc90_petrol_2019][device_tracker.volvo_xc90_location-state]
194194
StateSnapshot({
195195
'attributes': ReadOnlyDict({
196-
'friendly_name': 'Volvo XC90 None',
196+
'friendly_name': 'Volvo XC90 Location',
197197
'gps_accuracy': 0,
198198
'latitude': 57.72537482589284,
199199
'longitude': 11.849843629550225,
200200
'source_type': <SourceType.GPS: 'gps'>,
201201
}),
202202
'context': <ANY>,
203-
'entity_id': 'device_tracker.volvo_xc90_none',
203+
'entity_id': 'device_tracker.volvo_xc90_location',
204204
'last_changed': <ANY>,
205205
'last_reported': <ANY>,
206206
'last_updated': <ANY>,

0 commit comments

Comments
 (0)