Skip to content

Commit f94154d

Browse files
committed
Update suggested display values for some sensors
1 parent d381155 commit f94154d

File tree

2 files changed

+24
-16
lines changed

2 files changed

+24
-16
lines changed

homeassistant/components/powerwall/sensor.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,8 @@ def _get_battery_charge(battery_data: BatteryResponse) -> float:
328328
state_class=SensorStateClass.MEASUREMENT,
329329
device_class=SensorDeviceClass.ENERGY_STORAGE,
330330
native_unit_of_measurement=UnitOfEnergy.WATT_HOUR,
331+
suggested_unit_of_measurement=UnitOfEnergy.KILO_WATT_HOUR,
332+
suggested_display_precision=1,
331333
value_fn=lambda battery_data: battery_data.capacity,
332334
),
333335
PowerwallSensorEntityDescription[BatteryResponse, float](
@@ -370,6 +372,8 @@ def _get_battery_charge(battery_data: BatteryResponse) -> float:
370372
state_class=SensorStateClass.TOTAL_INCREASING,
371373
device_class=SensorDeviceClass.ENERGY,
372374
native_unit_of_measurement=UnitOfEnergy.WATT_HOUR,
375+
suggested_unit_of_measurement=UnitOfEnergy.KILO_WATT_HOUR,
376+
suggested_display_precision=0,
373377
value_fn=lambda battery_data: battery_data.energy_discharged,
374378
),
375379
PowerwallSensorEntityDescription[BatteryResponse, float](
@@ -378,6 +382,8 @@ def _get_battery_charge(battery_data: BatteryResponse) -> float:
378382
state_class=SensorStateClass.TOTAL_INCREASING,
379383
device_class=SensorDeviceClass.ENERGY,
380384
native_unit_of_measurement=UnitOfEnergy.WATT_HOUR,
385+
suggested_unit_of_measurement=UnitOfEnergy.KILO_WATT_HOUR,
386+
suggested_display_precision=0,
381387
value_fn=lambda battery_data: battery_data.energy_charged,
382388
),
383389
PowerwallSensorEntityDescription[BatteryResponse, int](
@@ -386,6 +392,8 @@ def _get_battery_charge(battery_data: BatteryResponse) -> float:
386392
state_class=SensorStateClass.MEASUREMENT,
387393
device_class=SensorDeviceClass.ENERGY_STORAGE,
388394
native_unit_of_measurement=UnitOfEnergy.WATT_HOUR,
395+
suggested_unit_of_measurement=UnitOfEnergy.KILO_WATT_HOUR,
396+
suggested_display_precision=1,
389397
value_fn=lambda battery_data: battery_data.energy_remaining,
390398
),
391399
PowerwallSensorEntityDescription[BatteryResponse, float](

tests/components/powerwall/test_sensor.py

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,8 @@ async def test_sensors(
133133
assert hass.states.get("sensor.mysite_backup_reserve").state == STATE_UNKNOWN
134134

135135
assert (
136-
int(hass.states.get("sensor.mysite_tg0123456789ab_battery_capacity").state)
137-
== 14715
136+
float(hass.states.get("sensor.mysite_tg0123456789ab_battery_capacity").state)
137+
== 14.715
138138
)
139139
assert (
140140
float(hass.states.get("sensor.mysite_tg0123456789ab_battery_voltage").state)
@@ -146,25 +146,25 @@ async def test_sensors(
146146
assert float(hass.states.get("sensor.mysite_tg0123456789ab_current").state) == 0.3
147147
assert int(hass.states.get("sensor.mysite_tg0123456789ab_power").state) == -100
148148
assert (
149-
int(hass.states.get("sensor.mysite_tg0123456789ab_battery_export").state)
150-
== 2358235
149+
float(hass.states.get("sensor.mysite_tg0123456789ab_battery_export").state)
150+
== 2358.235
151151
)
152152
assert (
153-
int(hass.states.get("sensor.mysite_tg0123456789ab_battery_import").state)
154-
== 2693355
153+
float(hass.states.get("sensor.mysite_tg0123456789ab_battery_import").state)
154+
== 2693.355
155155
)
156156
assert (
157-
int(hass.states.get("sensor.mysite_tg0123456789ab_battery_remaining").state)
158-
== 14715
157+
float(hass.states.get("sensor.mysite_tg0123456789ab_battery_remaining").state)
158+
== 14.715
159159
)
160160
assert float(hass.states.get("sensor.mysite_tg0123456789ab_charge").state) == 100.0
161161
assert (
162162
str(hass.states.get("sensor.mysite_tg0123456789ab_grid_state").state)
163163
== "grid_compliant"
164164
)
165165
assert (
166-
int(hass.states.get("sensor.mysite_tg9876543210ba_battery_capacity").state)
167-
== 15137
166+
float(hass.states.get("sensor.mysite_tg9876543210ba_battery_capacity").state)
167+
== 15.137
168168
)
169169
assert (
170170
float(hass.states.get("sensor.mysite_tg9876543210ba_battery_voltage").state)
@@ -176,16 +176,16 @@ async def test_sensors(
176176
assert float(hass.states.get("sensor.mysite_tg9876543210ba_current").state) == 0.1
177177
assert int(hass.states.get("sensor.mysite_tg9876543210ba_power").state) == -100
178178
assert (
179-
int(hass.states.get("sensor.mysite_tg9876543210ba_battery_export").state)
180-
== 509907
179+
float(hass.states.get("sensor.mysite_tg9876543210ba_battery_export").state)
180+
== 509.907
181181
)
182182
assert (
183-
int(hass.states.get("sensor.mysite_tg9876543210ba_battery_import").state)
184-
== 610483
183+
float(hass.states.get("sensor.mysite_tg9876543210ba_battery_import").state)
184+
== 610.483
185185
)
186186
assert (
187-
int(hass.states.get("sensor.mysite_tg9876543210ba_battery_remaining").state)
188-
== 15137
187+
float(hass.states.get("sensor.mysite_tg9876543210ba_battery_remaining").state)
188+
== 15.137
189189
)
190190
assert float(hass.states.get("sensor.mysite_tg9876543210ba_charge").state) == 100.0
191191
assert (

0 commit comments

Comments
 (0)