Skip to content

Conversation

@wollew
Copy link
Contributor

@wollew wollew commented Oct 29, 2025

Proposed change

This PR adds the KLF 200 gateway as its own device and makes it the via_device for all other devices. Currently there are no entities associated with the gateway device, but the PR prepares to add a button in a next step which can reboot the gateway and eventually replace the reboot_gateway service. So the plan is to follow up this PR with two more once it is merged, one to add the reboot-button and the second to deprecate the service.

Follow-up PRs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Julius2342, @DeerMaximum, @pawlizio, mind taking a look at this pull request as it has been labeled with an integration (velux) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of velux can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign velux Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Velux integration to introduce a gateway device and improve the data structure by wrapping runtime data in a dataclass. The changes enable proper device hierarchy where Velux devices (windows, lights, covers) are connected via the KLF 200 Gateway.

Key changes:

  • Introduced VeluxData dataclass to store both the PyVLX instance and gateway device identifier
  • Created a gateway device entry in the device registry during setup
  • Updated all entities to link to the gateway via via_device
  • Renamed config parameter to config_entry across platform setup functions for consistency

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/velux/__init__.py Adds VeluxData dataclass, creates gateway device in device registry, updates type hint for VeluxConfigEntry
homeassistant/components/velux/entity.py Updates VeluxEntity.__init__ to accept VeluxConfigEntry instead of string ID, adds via_device to device info
homeassistant/components/velux/binary_sensor.py Updates platform setup to use new data structure and passes config_entry to entity constructors
homeassistant/components/velux/cover.py Updates platform setup to use new data structure and passes config_entry to entity constructors
homeassistant/components/velux/light.py Updates platform setup to use new data structure and passes config_entry to entity constructors
homeassistant/components/velux/scene.py Updates platform setup to use new data structure (scenes don't use VeluxEntity)
tests/components/velux/test_binary_sensor.py Adds test verification for gateway device association via via_device_id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant