-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Deprecate velux reboot action #155549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Deprecate velux reboot action #155549
Conversation
|
Hey there @Julius2342, @DeerMaximum, @pawlizio, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
draft until the predecessors are merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a button entity for rebooting the Velux KLF 200 Gateway and deprecates the existing velux.reboot_gateway service. The changes introduce proper device hierarchy with the gateway as the parent device for all child devices.
Key changes:
- Added a new button entity (
VeluxGatewayRebootButton) for gateway reboot functionality - Introduced
VeluxDatadataclass to store gateway device identifier alongside PyVLX instance - Deprecated the
velux.reboot_gatewayservice with a repair issue notification - Updated all platform implementations to pass
VeluxConfigEntryinstead of just entry ID - Established proper device hierarchy with gateway as parent (
via_device)
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/velux/init.py | Introduced VeluxData dataclass, created gateway device entry, and deprecated reboot service |
| homeassistant/components/velux/button.py | Added new button entity for gateway reboot functionality |
| homeassistant/components/velux/entity.py | Updated to pass config_entry and set via_device for proper device hierarchy |
| homeassistant/components/velux/binary_sensor.py | Updated to pass config_entry instead of entry_id |
| homeassistant/components/velux/cover.py | Updated to pass config_entry instead of entry_id |
| homeassistant/components/velux/light.py | Updated to pass config_entry instead of entry_id |
| homeassistant/components/velux/scene.py | Updated to access pyvlx through runtime_data.pyvlx |
| homeassistant/components/velux/const.py | Added Platform.BUTTON to PLATFORMS list |
| homeassistant/components/velux/strings.json | Added button entity translations, exception translations, and deprecation issue description |
| tests/components/velux/conftest.py | Added setup_integration fixture and platform fixture for testing |
| tests/components/velux/test_button.py | Added comprehensive tests for button entity setup and functionality |
| tests/components/velux/test_binary_sensor.py | Added test verification for via_device gateway hierarchy |
Comments suppressed due to low confidence (1)
tests/components/velux/conftest.py:1
- Corrected spelling of 'platfo' to 'platform'.
"""Configuration for Velux tests."""
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
9a48b75 to
8c5e44c
Compare
Breaking change
Proposed change
This is the last PR in a series of 3, creating a deprecation issue for users of the
velux.reboot_gatewayservice, which was replaced by a more convenient reboot button for the gateway device.It thus depends on #155547 which depends on #155434.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: