Skip to content

Conversation

@wollew
Copy link
Contributor

@wollew wollew commented Oct 31, 2025

Breaking change

Proposed change

This is the last PR in a series of 3, creating a deprecation issue for users of the velux.reboot_gateway service, which was replaced by a more convenient reboot button for the gateway device.

It thus depends on #155547 which depends on #155434.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Julius2342, @DeerMaximum, @pawlizio, mind taking a look at this pull request as it has been labeled with an integration (velux) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of velux can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign velux Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@wollew wollew marked this pull request as draft October 31, 2025 11:26
@wollew
Copy link
Contributor Author

wollew commented Oct 31, 2025

draft until the predecessors are merged

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a button entity for rebooting the Velux KLF 200 Gateway and deprecates the existing velux.reboot_gateway service. The changes introduce proper device hierarchy with the gateway as the parent device for all child devices.

Key changes:

  • Added a new button entity (VeluxGatewayRebootButton) for gateway reboot functionality
  • Introduced VeluxData dataclass to store gateway device identifier alongside PyVLX instance
  • Deprecated the velux.reboot_gateway service with a repair issue notification
  • Updated all platform implementations to pass VeluxConfigEntry instead of just entry ID
  • Established proper device hierarchy with gateway as parent (via_device)

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
homeassistant/components/velux/init.py Introduced VeluxData dataclass, created gateway device entry, and deprecated reboot service
homeassistant/components/velux/button.py Added new button entity for gateway reboot functionality
homeassistant/components/velux/entity.py Updated to pass config_entry and set via_device for proper device hierarchy
homeassistant/components/velux/binary_sensor.py Updated to pass config_entry instead of entry_id
homeassistant/components/velux/cover.py Updated to pass config_entry instead of entry_id
homeassistant/components/velux/light.py Updated to pass config_entry instead of entry_id
homeassistant/components/velux/scene.py Updated to access pyvlx through runtime_data.pyvlx
homeassistant/components/velux/const.py Added Platform.BUTTON to PLATFORMS list
homeassistant/components/velux/strings.json Added button entity translations, exception translations, and deprecation issue description
tests/components/velux/conftest.py Added setup_integration fixture and platform fixture for testing
tests/components/velux/test_button.py Added comprehensive tests for button entity setup and functionality
tests/components/velux/test_binary_sensor.py Added test verification for via_device gateway hierarchy
Comments suppressed due to low confidence (1)

tests/components/velux/conftest.py:1

  • Corrected spelling of 'platfo' to 'platform'.
"""Configuration for Velux tests."""

@wollew wollew force-pushed the deprecate_reboot_action branch from 9a48b75 to 8c5e44c Compare October 31, 2025 15:02
@epenet epenet changed the title Deprecate reboot action Deprecate velux reboot action Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant