Skip to content

Conversation

@mik-laj
Copy link
Contributor

@mik-laj mik-laj commented Oct 31, 2025

Breaking change

Proposed change

This PR adds the PARALLEL_UPDATES = 0 constant to the WLED platform to specify unlimited concurrent entity updates, which is appropriate for coordinator-based integrations.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings October 31, 2025 23:26
@mik-laj mik-laj requested a review from frenck as a code owner October 31, 2025 23:26
@home-assistant
Copy link

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (wled) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of wled can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign wled Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mik-laj mik-laj mentioned this pull request Oct 31, 2025
75 tasks
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds PARALLEL_UPDATES = 0 to three WLED platform files (button, sensor, and update) to ensure unlimited parallel updates for coordinator-based entities. The change aligns these platforms with the existing pattern already established in other WLED platforms (light, switch, number, select).

Key Changes

  • Added PARALLEL_UPDATES = 0 constant to button.py, sensor.py, and update.py
  • Included explanatory comments indicating coordinator-based updates
  • Ensures consistency across all WLED platform files

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
homeassistant/components/wled/button.py Added PARALLEL_UPDATES = 0 with comment for coordinator-based entity
homeassistant/components/wled/sensor.py Added PARALLEL_UPDATES = 0 with comment for coordinator-based entities
homeassistant/components/wled/update.py Added PARALLEL_UPDATES = 0 with comment for coordinator-based entity

Comment on lines 15 to 16
# Coordinator is used to centralize the data updates
PARALLEL_UPDATES = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually not quite true. The coordinator only parallelizes the incoming data updates. Outgoing, like pressing the buttons, are not parallelized. So is the API able to handle potentially parallell requests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. We have only one button - Reset and I think there should be no parallelism here.

Changed PARALLEL_UPDATES from 0 to 1 to allow concurrent data updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants