Skip to content

Conversation

@lboue
Copy link
Contributor

@lboue lboue commented Nov 1, 2025

Proposed change

Add Ecovacs Deebot to Matter fixtures
This is to diversify testing with several different brands.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 1, 2025

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@lboue lboue marked this pull request as ready for review November 1, 2025 08:24
@lboue lboue requested a review from a team as a code owner November 1, 2025 08:24
Copilot AI review requested due to automatic review settings November 1, 2025 08:24
@lboue lboue changed the title Add Ecovacs Ecodeebot to Matter fixtures Add Ecovacs Deebot to Matter fixtures Nov 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds test coverage for the Ecovacs Deebot vacuum cleaner device to the Matter integration. The changes introduce a new device fixture and corresponding test snapshots to ensure proper entity creation and state handling.

  • Adds a new test fixture file ecovacs_deebot.json with device configuration data
  • Adds test snapshots for vacuum, sensor, select, and button entities
  • Registers the new fixture in the parameterized test configuration

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/components/matter/conftest.py Adds "ecovacs_deebot" to the parameterized test fixture list
tests/components/matter/fixtures/nodes/ecovacs_deebot.json New test fixture containing device attributes and configuration for the Ecovacs Deebot vacuum
tests/components/matter/snapshots/test_vacuum.ambr Adds snapshot tests for vacuum entity registration and state
tests/components/matter/snapshots/test_sensor.ambr Adds snapshot tests for battery, operational state, and phase sensors
tests/components/matter/snapshots/test_select.ambr Adds snapshot test for clean mode selection entity
tests/components/matter/snapshots/test_button.ambr Adds snapshot test for identify button entity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants