-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Add Ecovacs Deebot to Matter fixtures #155587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Updated snapshots for ecovacs_deebot vacuum entity.
|
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds test coverage for the Ecovacs Deebot vacuum cleaner device to the Matter integration. The changes introduce a new device fixture and corresponding test snapshots to ensure proper entity creation and state handling.
- Adds a new test fixture file
ecovacs_deebot.jsonwith device configuration data - Adds test snapshots for vacuum, sensor, select, and button entities
- Registers the new fixture in the parameterized test configuration
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/components/matter/conftest.py | Adds "ecovacs_deebot" to the parameterized test fixture list |
| tests/components/matter/fixtures/nodes/ecovacs_deebot.json | New test fixture containing device attributes and configuration for the Ecovacs Deebot vacuum |
| tests/components/matter/snapshots/test_vacuum.ambr | Adds snapshot tests for vacuum entity registration and state |
| tests/components/matter/snapshots/test_sensor.ambr | Adds snapshot tests for battery, operational state, and phase sensors |
| tests/components/matter/snapshots/test_select.ambr | Adds snapshot test for clean mode selection entity |
| tests/components/matter/snapshots/test_button.ambr | Adds snapshot test for identify button entity |
Proposed change
Add Ecovacs Deebot to Matter fixtures
This is to diversify testing with several different brands.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: