-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Support for deactivating oneTimeCharge #155592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Christian Kemper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @CFenner, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great addition as long as we do not have a switch entity! Unfortunately 2025.11.0 is already in the making, so it would only reach production in 2025.12.0.
Proposed change
For optimizing power usage it is currently possible to activate oneTimeDHW - but you are not able to stop it. With this little enhancement it should be possible to stop it. It could be used for optimizing the PV power usage.
The oneTimeDHW feature is better than simply raising the hot water temperature because it enables the circulation pump during the last minutes of heating (the water is better mixed).
Type of change
Additional information
Be patient ;-)
I am very new to python and know the code, but not all topics, etc. related with Home Assistant.
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
No changes in beahaiviour with this PR.
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: